<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/git.git, branch sb/diff-delta-remove-needless-comparison</title>
<subtitle>github.com: git/git.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/'/>
<entry>
<title>create_delta_index: simplify condition always evaluating to true</title>
<updated>2013-08-18T19:56:23+00:00</updated>
<author>
<name>Stefan Beller</name>
<email>stefanbeller@googlemail.com</email>
</author>
<published>2013-08-16T21:22:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=f7466e94375b3be27f229c78873f0acf8301c0a5'/>
<id>f7466e94375b3be27f229c78873f0acf8301c0a5</id>
<content type='text'>
The code sequence  ' (1u &lt;&lt; i) &lt; hsize &amp;&amp; i &lt; 31 ' is a multi step
process, whose first step requires that 'i' is already less that 31,
otherwise the result (1u &lt;&lt; i)  is undefined (and  'undef_val &lt; hsize'
can therefore be assumed to be 'false'), and so the later test  i &lt; 31
can always be optimized away as dead code ('i' is already less than 31,
or the short circuit 'and' applies).

So we need to get rid of that code. One way would be to exchange the
order of the conditions, so the expression 'i &lt; 31 &amp;&amp; (1u &lt;&lt; i) &lt; hsize'
would remove that optimized unstable code already.

However when checking the previous lines in that function, we can deduce
that 'hsize' must always be smaller than (1u&lt;&lt;31), since 506049c7df2c6
(fix &gt;4GiB source delta assertion failure), because 'entries' is
capped at an upper bound of 0xfffffffeU, so 'hsize' contains a maximum
value of 0x3fffffff, which is smaller than (1u&lt;&lt;31), so the value of
'i' will never be larger than 31 and we can remove that condition
entirely.

Signed-off-by: Stefan Beller &lt;stefanbeller@googlemail.com&gt;
Acked-by: Nicolas Pitre &lt;nico@fluxnic.net&gt;
Acked-by: Philip Oakley &lt;philipoakley@iee.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The code sequence  ' (1u &lt;&lt; i) &lt; hsize &amp;&amp; i &lt; 31 ' is a multi step
process, whose first step requires that 'i' is already less that 31,
otherwise the result (1u &lt;&lt; i)  is undefined (and  'undef_val &lt; hsize'
can therefore be assumed to be 'false'), and so the later test  i &lt; 31
can always be optimized away as dead code ('i' is already less than 31,
or the short circuit 'and' applies).

So we need to get rid of that code. One way would be to exchange the
order of the conditions, so the expression 'i &lt; 31 &amp;&amp; (1u &lt;&lt; i) &lt; hsize'
would remove that optimized unstable code already.

However when checking the previous lines in that function, we can deduce
that 'hsize' must always be smaller than (1u&lt;&lt;31), since 506049c7df2c6
(fix &gt;4GiB source delta assertion failure), because 'entries' is
capped at an upper bound of 0xfffffffeU, so 'hsize' contains a maximum
value of 0x3fffffff, which is smaller than (1u&lt;&lt;31), so the value of
'i' will never be larger than 31 and we can remove that condition
entirely.

Signed-off-by: Stefan Beller &lt;stefanbeller@googlemail.com&gt;
Acked-by: Nicolas Pitre &lt;nico@fluxnic.net&gt;
Acked-by: Philip Oakley &lt;philipoakley@iee.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Git 1.8.3</title>
<updated>2013-05-24T18:34:46+00:00</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2013-05-24T18:34:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=edca4152560522a431a51fc0a06147fc680b5b18'/>
<id>edca4152560522a431a51fc0a06147fc680b5b18</id>
<content type='text'>
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>remote-hg: fix order of configuration comments</title>
<updated>2013-05-21T16:33:24+00:00</updated>
<author>
<name>Felipe Contreras</name>
<email>felipe.contreras@gmail.com</email>
</author>
<published>2013-05-21T03:47:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=5e49f30c85ecacec98631462fa73f1148a01637c'/>
<id>5e49f30c85ecacec98631462fa73f1148a01637c</id>
<content type='text'>
The other configurations were added in the wrong place.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The other configurations were added in the wrong place.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>remote-hg: trivial configuration note cleanup</title>
<updated>2013-05-21T16:33:21+00:00</updated>
<author>
<name>Felipe Contreras</name>
<email>felipe.contreras@gmail.com</email>
</author>
<published>2013-05-21T03:47:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=92c4369907533d942385311cb72d9852a86290d5'/>
<id>92c4369907533d942385311cb72d9852a86290d5</id>
<content type='text'>
Follow the style of the previous configurations.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Follow the style of the previous configurations.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>completion: regression fix for zsh</title>
<updated>2013-05-21T16:28:45+00:00</updated>
<author>
<name>Felipe Contreras</name>
<email>felipe.contreras@gmail.com</email>
</author>
<published>2013-05-21T00:33:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=737044517f403c1080886a674845fad9c42d6bc0'/>
<id>737044517f403c1080886a674845fad9c42d6bc0</id>
<content type='text'>
zsh completion wrapper doesn't reimplement __gitcompadd(). Although it
should be trivial to do that, let's use __gitcomp_nl() which achieves
exactly the same thing, specially since the suffix ($4) has to be empty.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
zsh completion wrapper doesn't reimplement __gitcompadd(). Although it
should be trivial to do that, let's use __gitcomp_nl() which achieves
exactly the same thing, specially since the suffix ($4) has to be empty.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge git://git.bogomips.org/git-svn</title>
<updated>2013-05-20T23:06:48+00:00</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2013-05-20T23:06:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=9134a460e3ebfc93790e98d74b3cda2bcca8eb8b'/>
<id>9134a460e3ebfc93790e98d74b3cda2bcca8eb8b</id>
<content type='text'>
* git://git.bogomips.org/git-svn:
  git-svn: introduce --parents parameter for commands branch and tag
  git-svn: clarify explanation of --destination argument
  git-svn: multiple fetch/branches/tags keys are supported
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* git://git.bogomips.org/git-svn:
  git-svn: introduce --parents parameter for commands branch and tag
  git-svn: clarify explanation of --destination argument
  git-svn: multiple fetch/branches/tags keys are supported
</pre>
</div>
</content>
</entry>
<entry>
<title>git-svn: introduce --parents parameter for commands branch and tag</title>
<updated>2013-05-20T22:05:54+00:00</updated>
<author>
<name>Tobias Schulte</name>
<email>tobias.schulte@gliderpilot.de</email>
</author>
<published>2013-05-15T20:14:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=f4f4c7fc00e8acf91150c717cf005fc36c1dd120'/>
<id>f4f4c7fc00e8acf91150c717cf005fc36c1dd120</id>
<content type='text'>
This parameter is equivalent to the parameter --parents on svn cp commands
and is useful for non-standard repository layouts.

Signed-off-by: Tobias Schulte &lt;tobias.schulte@gliderpilot.de&gt;
Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This parameter is equivalent to the parameter --parents on svn cp commands
and is useful for non-standard repository layouts.

Signed-off-by: Tobias Schulte &lt;tobias.schulte@gliderpilot.de&gt;
Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>git-svn: clarify explanation of --destination argument</title>
<updated>2013-05-20T22:05:47+00:00</updated>
<author>
<name>Jonathan Nieder</name>
<email>jrnieder@gmail.com</email>
</author>
<published>2011-12-20T01:24:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=7d82b4af1cefe55b825f524f250cd0002dbba4ab'/>
<id>7d82b4af1cefe55b825f524f250cd0002dbba4ab</id>
<content type='text'>
The existing documentation for "-d" does not make it obvious whether
its argument is supposed to be a full svn path, a partial svn path,
the glob from the config file, or what.  Clarify the text and add an
example to get the reader started.

Reported-by: Nathan Gray &lt;n8gray@n8gray.org&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The existing documentation for "-d" does not make it obvious whether
its argument is supposed to be a full svn path, a partial svn path,
the glob from the config file, or what.  Clarify the text and add an
example to get the reader started.

Reported-by: Nathan Gray &lt;n8gray@n8gray.org&gt;
Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>git-svn: multiple fetch/branches/tags keys are supported</title>
<updated>2013-05-20T22:05:47+00:00</updated>
<author>
<name>Nathan Gray</name>
<email>n8gray@n8gray.org</email>
</author>
<published>2011-12-20T01:23:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=eff714bddafd3d49cde0eac6ae670970da024fb4'/>
<id>eff714bddafd3d49cde0eac6ae670970da024fb4</id>
<content type='text'>
"git svn" can be configured to use multiple fetch, branches, and tags
refspecs by passing multiple --branches or --tags options at init time
or editing the configuration file later, which can be handy when
working with messy Subversion repositories.  Add a note to the
configuration section documenting how this works.

Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
"git svn" can be configured to use multiple fetch, branches, and tags
refspecs by passing multiple --branches or --tags options at init time
or editing the configuration file later, which can be handy when
working with messy Subversion repositories.  Add a note to the
configuration section documenting how this works.

Signed-off-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Eric Wong &lt;normalperson@yhbt.net&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>remote-hg: set stdout to binary mode on win32</title>
<updated>2013-05-20T18:18:43+00:00</updated>
<author>
<name>Amit Bakshi</name>
<email>ambakshi@gmail.com</email>
</author>
<published>2013-05-19T11:53:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/git.git/commit/?id=5dbe064d8cf37142f8c76f73ae0866286a8fb018'/>
<id>5dbe064d8cf37142f8c76f73ae0866286a8fb018</id>
<content type='text'>
git clone hangs on windows, and file.write would return errno 22 inside
of mercurial's windows.winstdout wrapper class. This patch sets stdout's
mode to binary, fixing both issues.

[fc: cleaned up]

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git clone hangs on windows, and file.write would return errno 22 inside
of mercurial's windows.winstdout wrapper class. This patch sets stdout's
mode to binary, fixing both issues.

[fc: cleaned up]

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
