delta/git.git, branch nd/fopen-errors

configure.ac: loosen FREAD_READS_DIRECTORIES test program

2017-06-15T21:14:33+00:00

We added an FREAD_READS_DIRECTORIES Makefile knob long ago
in cba22528f (Add compat/fopen.c which returns NULL on
attempt to open directory, 2008-02-08) to handle systems
where reading from a directory returned garbage. This works
by catching the problem at the fopen() stage and returning
NULL.

More recently, we found that there is a class of systems
(including Linux) where fopen() succeeds but fread() fails.
Since the solution is the same (having fopen return NULL),
they use the same Makefile knob as of e2d90fd1c
(config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and
FreeBSD, 2017-05-03).

This works fine except for one thing: the autoconf test in
configure.ac to set FREAD_READS_DIRECTORIES actually checks
whether fread succeeds. Which means that on Linux systems,
the knob isn't set (and we even override the config.mak.uname
default). t1308 catches the failure.

We can fix this by tweaking the autoconf test to cover both
cases. In theory we might care about the distinction between
the traditional "fread reads directories" case and the new
"fopen opens directories". But since our solution catches
the problem at the fopen stage either way, we don't actually
need to know the difference. The "fopen" case is a superset.

This does mean the FREAD_READS_DIRECTORIES name is slightly
misleading. Probably FOPEN_OPENS_DIRECTORIES would be more
accurate. But it would be disruptive to simply change the
name (people's existing build configs would fail), and it's
not worth the complexity of handling both. Let's just add a
comment in the knob description.

Reported-by: Øyvind A. Holm 
Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

mingw_fopen: report ENOENT for invalid file names

2017-06-02T01:40:04+00:00

On Windows, certain characters are prohibited in file names, most
prominently the colon. When fopen() is called with such an invalid file
name, the underlying Windows API actually reports a particular error,
but since there is no suitable errno value, this error is translated
to EINVAL. Detect the case and report ENOENT instead.

Signed-off-by: Johannes Sixt 
Signed-off-by: Junio C Hamano

mingw: verify that paths are not mistaken for remote nicknames

2017-06-02T01:39:50+00:00

This added test case simply verifies that users will not be bothered
with bogus complaints à la

	warning: unable to access '.git/remotes/D:\repo': Invalid argument

when fetching from a Windows path (in this case, D:\repo).

[j6t: mark the new test as test_expect_failure]

Signed-off-by: Johannes Schindelin 
Signed-off-by: Johannes Sixt 
Signed-off-by: Junio C Hamano

log: fix memory leak in open_next_file()

2017-05-26T03:33:56+00:00

Noticed-by: Jeff King 
Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Junio C Hamano

rerere.c: move error_errno() closer to the source system call

2017-05-26T03:33:56+00:00

We are supposed to report errno from fopen(). fclose() between fopen()
and the report function could either change errno or reset it.

Signed-off-by: Junio C Hamano

print errno when reporting a system call error

2017-05-26T03:33:56+00:00

Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Junio C Hamano

wrapper.c: make warn_on_inaccessible() static

2017-05-26T03:33:56+00:00

After the last patch, this function is not used outside anymore. Keep it
static.

Noticed-by: Ramsay Jones 
Signed-off-by: Junio C Hamano

wrapper.c: add and use fopen_or_warn()

2017-05-26T03:33:56+00:00

When fopen() returns NULL, it could be because the given path does not
exist, but it could also be some other errors and the caller has to
check. Add a wrapper so we don't have to repeat the same error check
everywhere.

Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Junio C Hamano

wrapper.c: add and use warn_on_fopen_errors()

2017-05-26T03:33:55+00:00

In many places, Git warns about an inaccessible file after a fopen()
failed. To discern these cases from other cases where we want to warn
about inaccessible files, introduce a new helper specifically to test
whether fopen() failed because the current user lacks the permission to
open file in question.

Signed-off-by: Nguyễn Thái Ngọc Duy 
Signed-off-by: Junio C Hamano

config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, too

2017-05-26T03:33:55+00:00

Signed-off-by: Junio C Hamano