delta/git.git, branch mh/ref-api-rest github.com: git/git.git repack_without_ref(): call clear_packed_ref_cache() 2011-12-12T17:08:57+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:58+00:00 84c14bbcacc53a318a65dc3c59e4aa319463184a Call clear_packed_ref_cache() from repack_without_ref(). This is a more logical place to call it than from delete_ref(). Also, repack_without_ref() is smart enough to know that it doesn't have to invalidate the cache if the reference was not found among the packed refs. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Call clear_packed_ref_cache() from repack_without_ref().  This is a
more logical place to call it than from delete_ref().  Also,
repack_without_ref() is smart enough to know that it doesn't have to
invalidate the cache if the reference was not found among the packed
refs.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
read_packed_refs(): keep track of the directory being worked in 2011-12-12T17:08:57+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:57+00:00 6a871b0a34230a977534d341b2e10182a0565b19 Packed references are stored in $GIT_DIR/packed-refs sorted, so adjacent ones are pretty likely to be in the same directory. So while reading them, keep track of the last directory used, and reuse it if possible to avoid searching the reference namespace from the root each time. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Packed references are stored in $GIT_DIR/packed-refs sorted, so
adjacent ones are pretty likely to be in the same directory.  So while
reading them, keep track of the last directory used, and reuse it if
possible to avoid searching the reference namespace from the root each
time.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
is_refname_available(): query only possibly-conflicting references 2011-12-12T17:08:57+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:56+00:00 bce637326daf875b27f370c23e00ffb2c8354d76 Instead of iterating through all of the references, inquire more pointedly about the references that could conflict with the new name. This requires checking for a few individual references, plus iterating through a small subtree of the rest of the references (and usually the subtree iteration ends without having to recurse). A big benefit is that populating the whole loose reference cache (which can be very expensive) can usually be avoided. Also, simplify name_conflict_fn(). Since it now will only be called for possibly-conflicting references, there is necessarily a conflict if it is called for *any* reference besides "oldrefname". Remove function names_conflict(), which is now unused. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Instead of iterating through all of the references, inquire more
pointedly about the references that could conflict with the new name.
This requires checking for a few individual references, plus iterating
through a small subtree of the rest of the references (and usually the
subtree iteration ends without having to recurse).  A big benefit is
that populating the whole loose reference cache (which can be very
expensive) can usually be avoided.

Also, simplify name_conflict_fn().  Since it now will only be called
for possibly-conflicting references, there is necessarily a conflict
if it is called for *any* reference besides "oldrefname".

Remove function names_conflict(), which is now unused.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs: read loose references lazily 2011-12-12T17:08:57+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:55+00:00 5c3e7e81e7a024d6bdd1f42b7c3a9d0af70ed4c2 Instead of reading the whole directory of loose references the first time any are needed, only read them on demand, one directory at a time. Use a new ref_entry flag value REF_DIR_INCOMPLETE to indicate that the entry represents a REF_DIR that hasn't been read yet. Whenever any entries from such a directory are needed, read all of the loose references from that directory. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Instead of reading the whole directory of loose references the first
time any are needed, only read them on demand, one directory at a
time.

Use a new ref_entry flag value REF_DIR_INCOMPLETE to indicate that the
entry represents a REF_DIR that hasn't been read yet.  Whenever any
entries from such a directory are needed, read all of the loose
references from that directory.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
read_loose_refs(): take a (ref_entry *) as argument 2011-12-12T17:08:57+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:54+00:00 3fe95345190f4590722ee4c1662cab727c64fb70 Rename get_ref_dir() to read_loose_refs(), and change its signature. This is another step towards reading loose references one directory at a time. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Rename get_ref_dir() to read_loose_refs(), and change its signature.
This is another step towards reading loose references one directory
at a time.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
struct ref_dir: store a reference to the enclosing ref_cache 2011-12-12T17:08:56+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:53+00:00 21969924c3835de3af353181ea015a17211b118a This means that it contains enough information to serve as the sole argument to get_ref_dir(), which will be changed in the next commit. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
This means that it contains enough information to serve as the sole
argument to get_ref_dir(), which will be changed in the next commit.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sort_ref_dir(): take (ref_entry *) instead of (ref_dir *) 2011-12-12T17:08:56+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:52+00:00 dd7c62b468a233d5378860243f18cb86955776de Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
do_for_each_ref_in_dir*(): take (ref_entry *) instead of (ref_dir *) 2011-12-12T17:08:56+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:51+00:00 2e412d079123f02a280199a21b5048b251325252 Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
add_entry(): take (ref_entry *) instead of (ref_dir *) 2011-12-12T17:08:56+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:50+00:00 22f332cab6bbeb7f28892f8d1be6268c715a76fa Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
search_ref_dir(): take (ref_entry *) instead of (ref_dir *) 2011-12-12T17:08:56+00:00 Michael Haggerty mhagger@alum.mit.edu 2011-12-12T05:38:49+00:00 e6c23f4562086ecb6092ae5b790f2b1db2cc7f11 Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>