delta/git.git, branch js/bs-is-a-dir-sep-on-windows

Windows: do not treat a path with backslashes as a remote's nick name

2017-05-25T23:05:32+00:00

On Windows, the remote repository name in, e.g., `git fetch foo\bar`
is clearly not a nickname for a configured remote repository. However,
the function valid_remote_nick() does not account for backslashes.
Use is_dir_sep() to check for both slashes and backslashes on Windows.

This was discovered while playing with Duy's patches that warn after
fopen() failures. The functions that read the branches and remotes
files are protected by a valid_remote_nick() check. Without this
change, a Windows style absolute path is incorrectly regarded as
nickname and is concatenated to a prefix and used with fopen(). This
triggers warnings because a colon in a path name is not allowed:

C:\Temp\gittest>git fetch C:\Temp\gittest
warning: unable to access '.git/remotes/C:\Temp\gittest': Invalid argument
warning: unable to access '.git/branches/C:\Temp\gittest': Invalid argument
From C:\Temp\gittest
 * branch            HEAD       -> FETCH_HEAD

Signed-off-by: Johannes Sixt 
Signed-off-by: Junio C Hamano

mingw.h: permit arguments with side effects for is_dir_sep

2017-05-23T12:42:14+00:00

Taking git-compat-util.h's cue (which uses an inline function to back
is_dir_sep()), let's use an inline function to back also the Windows
version of is_dir_sep(). This avoids problems when calling the function
with arguments that do more than just provide a single character, e.g.
incrementing a pointer. Example:

    is_dir_sep(*p++)

Signed-off-by: Johannes Sixt 
Signed-off-by: Junio C Hamano

Git 2.10.3

2017-05-05T04:24:10+00:00

Signed-off-by: Junio C Hamano

Merge branch 'maint-2.9' into maint-2.10

2017-05-05T04:21:52+00:00

Git 2.9.4

2017-05-05T04:19:10+00:00

Signed-off-by: Junio C Hamano

Merge branch 'maint-2.8' into maint-2.9

2017-05-05T04:13:48+00:00

Git 2.8.5

2017-05-05T04:08:54+00:00

Signed-off-by: Junio C Hamano

Merge branch 'maint-2.7' into maint-2.8

2017-05-05T04:05:03+00:00

Git 2.7.5

2017-05-05T04:03:40+00:00

Signed-off-by: Junio C Hamano

Merge branch 'maint-2.6' into maint-2.7

2017-05-05T03:59:16+00:00