delta/git.git, branch jh/object-filtering

oidset: don't return value from oidset_init

2018-01-08T23:24:35+00:00

c3a9ad3117 ("oidset: add iterator methods to oidset", 2017-11-21)
introduced a 'oidset_init()' function in oidset.h, which has void as
return type, but returns an expression.

This makes the solaris compiler fail with:

    "oidset.h", line 30: void function cannot return value

As the return type is void, and even the return type of the expression
we're trying to return (oidmap_init) is void just remove the return
statement to fix the compiler error.

Signed-off-by: Thomas Gummerer 
Signed-off-by: Junio C Hamano

rev-list: support --no-filter argument

2017-12-05T17:44:37+00:00

Teach rev-list to support --no-filter to override a
previous --filter= argument.  This is
to be consistent with commands that use OPT_PARSE
macros.

Signed-off-by: Jeff Hostetler 
Signed-off-by: Junio C Hamano

list-objects-filter-options: support --no-filter

2017-12-05T17:44:36+00:00

Teach opt_parse_list_objects_filter() to take --no-filter
option and to free the contents of struct filter_options.
This command line argument will be automatically inherited
by commands using OPT_PARSE_LIST_OBJECTS_FILTER(); this
includes pack-objects.

Signed-off-by: Jeff Hostetler 
Signed-off-by: Junio C Hamano

list-objects-filter-options: fix 'keword' typo in comment

2017-12-05T17:44:35+00:00

Signed-off-by: Christian Couder 
Signed-off-by: Jeff Hostetler 
Signed-off-by: Junio C Hamano

pack-objects: add list-objects filtering

2017-11-22T05:11:57+00:00

Teach pack-objects to use the filtering provided by the
traverse_commit_list_filtered() interface to omit unwanted
objects from the resulting packfile.

Filtering requires the use of the "--stdout" option.

Add t5317 test.

In the future, we will introduce a "partial clone" mechanism
wherein an object in a repo, obtained from a remote, may
reference a missing object that can be dynamically fetched from
that remote once needed.  This "partial clone" mechanism will
have a way, sometimes slow, of determining if a missing link
is one of the links expected to be produced by this mechanism.

This patch introduces handling of missing objects to help
debugging and development of the "partial clone" mechanism,
and once the mechanism is implemented, for a power user to
perform operations that are missing-object aware without
incurring the cost of checking if a missing link is expected.

Signed-off-by: Jeff Hostetler 
Reviewed-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

rev-list: add list-objects filtering support

2017-11-22T05:11:57+00:00

Teach rev-list to use the filtering provided by the
traverse_commit_list_filtered() interface to omit
unwanted objects from the result.

Object filtering is only allowed when one of the "--objects*"
options are used.

When the "--filter-print-omitted" option is used, the omitted
objects are printed at the end.  These are marked with a "~".
This option can be combined with "--quiet" to get a list of
just the omitted objects.

Add t6112 test.

In the future, we will introduce a "partial clone" mechanism
wherein an object in a repo, obtained from a remote, may
reference a missing object that can be dynamically fetched from
that remote once needed.  This "partial clone" mechanism will
have a way, sometimes slow, of determining if a missing link
is one of the links expected to be produced by this mechanism.

This patch introduces handling of missing objects to help
debugging and development of the "partial clone" mechanism,
and once the mechanism is implemented, for a power user to
perform operations that are missing-object aware without
incurring the cost of checking if a missing link is expected.

Signed-off-by: Jeff Hostetler 
Reviewed-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

list-objects: filter objects in traverse_commit_list

2017-11-22T05:11:57+00:00

Create traverse_commit_list_filtered() and add filtering
interface to allow certain objects to be omitted from the
traversal.

Update traverse_commit_list() to be a wrapper for the above
with a null filter to minimize the number of callers that
needed to be changed.

Object filtering will be used in a future commit by rev-list
and pack-objects for partial clone and fetch to omit unwanted
objects from the result.

traverse_bitmap_commit_list() does not work with filtering.
If a packfile bitmap is present, it will not be used.  It
should be possible to extend such support in the future (at
least to simple filters that do not require object pathnames),
but that is beyond the scope of this patch series.

Signed-off-by: Jeff Hostetler 
Reviewed-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

oidset: add iterator methods to oidset

2017-11-22T05:11:56+00:00

Add the usual iterator methods to oidset.
Add oidset_remove().

Signed-off-by: Jeff Hostetler 
Reviewed-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

oidmap: add oidmap iterator methods

2017-11-22T05:11:56+00:00

Add the usual map iterator functions to oidmap.

Signed-off-by: Jeff Hostetler 
Reviewed-by: Jonathan Tan 
Signed-off-by: Junio C Hamano

dir: allow exclusions from blob in addition to file

2017-11-22T05:11:56+00:00

Refactor add_excludes() to separate the reading of the
exclude file into a buffer and the parsing of the buffer
into exclude_list items.

Add add_excludes_from_blob_to_list() to allow an exclude
file be specified with an OID without assuming a local
worktree or index exists.

Refactor read_skip_worktree_file_from_index() and add
do_read_blob() to eliminate duplication of preliminary
processing of blob contents.

Signed-off-by: Jeff Hostetler 
Reviewed-by: Jonathan Tan 
Signed-off-by: Junio C Hamano