delta/git.git, branch bl/gitweb-project-filter

gitweb: Harden and improve $project_filter page title

2012-02-13T06:11:31+00:00

Commit 19d2d23 (gitweb: add project_filter to limit project list
to a subdirectory, 2012-01-30) added also support for displaying
$project_filter, if present, in page title.

Unfortunately it forgot to treat $project_filter as path, and escape
it using esc_path(), like it is done for $filename.

Also, it was not obvious that "$site_name - $project_filter" is about
project filtering: use "$site_name - projects in '$project_filter'".

Signed-off-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: Make project search respect project_filter

2012-02-01T20:52:50+00:00

Make gitweb search within filtered projects (i.e. projects shown), and
change "List all projects" to "List all projects in '$project_filter/'"
if project_filter is used.

Signed-off-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: improve usability of projects search form

2012-02-01T20:52:50+00:00

Refactor generating project search form into git_project_search_form().

Make text field wider and add on mouse over explanation (via "title"
attribute), add an option to use regular expressions, and replace
'Search:' label with [Search] button.

Also add "List all projects" link to make it easier to go back from search
result to list of all projects (note that an empty search term is
disallowed).

Signed-off-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: place links to parent directories in page header

2012-02-01T20:52:50+00:00

Change html page headers to not only link the project root and the
currently selected project but also the directories in between using
project_filter. (Allowing to jump to a list of all projects within
that intermediate directory directly and making the project_filter
feature visible to users).

Signed-off-by: Bernhard R. Link 
Acked-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: show active project_filter in project_list page header

2012-02-01T20:52:49+00:00

In the page header of a project_list view with a project_filter
given show breadcrumbs in the page headers showing which directory
it is currently limited to and also containing links to the parent
directories.

Signed-off-by: Bernhard R. Link 
Acked-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: limit links to alternate forms of project_list to active project_filter

2012-02-01T20:52:49+00:00

If project_list action is given a project_filter argument, pass that to
TXT and OPML formats.

This way [OPML] and [TXT] links provide the same list of projects as
the projects_list page they are linked from.

Signed-off-by: Bernhard R. Link 
Acked-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: add project_filter to limit project list to a subdirectory

2012-02-01T20:52:49+00:00

This commit changes the project listing views (project_list,
project_index and opml) to limit the output to only projects in a
subdirectory if the new optional parameter ?pf=directory name is
used.

The implementation of the filter reuses the implementation used for
the 'forks' action (i.e. listing all projects within that directory
from the projects list file (GITWEB_LIST) or only projects in the
given subdirectory of the project root directory without a projects
list file).

Reusing $project instead of adding a new parameter would have been
nicer from a UI point-of-view (including PATH_INFO support) but
would complicate the $project validating code that is currently
being used to ensure nothing is exported that should not be viewable.

Signed-off-by: Bernhard R. Link 
Acked-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: prepare git_get_projects_list for use outside 'forks'.

2012-02-01T20:52:49+00:00

Use of the filter option of git_get_projects_list is currently limited
to forks. It currently assumes the project belonging to the filter
directory was already validated to be visible in the project list.

To make it more generic add an optional argument to denote visibility
verification is still needed.

If there is a projects list file (GITWEB_LIST) only projects from
this list are returned anyway, so no more checks needed.

If there is no projects list file and the caller requests strict
checking (GITWEB_STRICT_EXPORT), do not jump directly to the
given directory but instead do a normal search and filter the
results instead.

The only effect of GITWEB_STRICT_EXPORT without GITWEB_LIST is to make
sure no project can be viewed without also be found starting from
project root. git_get_projects_list without this patch does not enforce
this but all callers only call it with a filter already checked this
way. With this parameter a caller can request this check if the filter
cannot be checked this way.

Signed-off-by: Bernhard R. Link 
Acked-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

gitweb: move hard coded .git suffix out of git_get_projects_list

2012-02-01T20:52:33+00:00

Use of the filter option of git_get_projects_list is currently
limited to forks. It hard codes removal of ".git" suffixes from
the filter.

To make it more generic move the .git suffix removal to the callers.

Signed-off-by: Bernhard R. Link 
Acked-by: Jakub Narebski 
Signed-off-by: Junio C Hamano

Git 1.7.9

2012-01-27T19:31:02+00:00

Signed-off-by: Junio C Hamano