From 9fbc44259355b00d1271c21bf14493d039160ccf Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 18 Nov 2016 03:53:50 +0000 Subject: gf_w32.c: silence the -Wmaybe-uninitialized warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit in gf_w32_cfmgk_multiply_region_from_single(), follow warning is reported by gcc: gf-complete/src/gf_w32.c:410:5: warning: ‘a’ may be used uninitialized in this function [-Wmaybe-uninitialized] g = _mm_insert_epi64 (a, g_star, 0); ^ actually, we are using `a` as a dummy parameter for initializing `g` and `q`. and only the lower lower 64 bits of them are used when doing calculation. but their lower 64 bits are always initialized using _mm_insert_epi64(). so this is a false alarm. but we can silence this warning by moving the statement initializing `a` up before passing it to _mm_insert_epi64(). this change does not hurt the performance. Signed-off-by: Kefu Chai --- src/gf_w32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gf_w32.c b/src/gf_w32.c index bb22894..92dba87 100644 --- a/src/gf_w32.c +++ b/src/gf_w32.c @@ -407,9 +407,9 @@ gf_w32_cfmgk_multiply_region_from_single(gf_t *gf, void *src, void *dest, uint32 q_plus = *(uint64_t *) h->private; g_star = *((uint64_t *) h->private + 1); + a = _mm_insert_epi32 (_mm_setzero_si128(), val, 0); g = _mm_insert_epi64 (a, g_star, 0); q = _mm_insert_epi64 (a, q_plus, 0); - a = _mm_insert_epi32 (_mm_setzero_si128(), val, 0); s32 = (uint32_t *) src; d32 = (uint32_t *) dest; -- cgit v1.2.1