From f0fdd66ba4fa07d5ef314eab9aee404750ae3ef4 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Sat, 20 Oct 2001 06:26:45 +0000 Subject: Double.java: More Classpath merging * java/lang/Double.java: More Classpath merging (isInfinite): Don't use doubleToLongBits (isNaN (Object)): return v != v (initIDs): make native * java/lang/Float.java: Ditto (isInfinite): Don't use floatToIntBits (isNaN (Object)): return v != v * java/lang/natDouble.cc: add empty initIDs() From-SVN: r46370 --- libjava/java/lang/Float.java | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) (limited to 'libjava/java/lang/Float.java') diff --git a/libjava/java/lang/Float.java b/libjava/java/lang/Float.java index 91da0754d60..9e26143f773 100644 --- a/libjava/java/lang/Float.java +++ b/libjava/java/lang/Float.java @@ -215,6 +215,14 @@ public final class Float extends Number implements Comparable * instanceof Float, and represents * the same primitive float value return * true. Otherwise false is returned. + *

+ * Note that there are two differences between == and + * equals(). 0.0f == -0.0f returns true + * but new Float(0.0f).equals(new Float(-0.0f)) returns + * false. And Float.NaN == Float.NaN returns + * false, but + * new Float(Float.NaN).equals(new Float(Float.NaN)) returns + * true. * * @param obj the object to compare to * @return whether the objects are semantically equal. @@ -364,11 +372,9 @@ public final class Float extends Number implements Comparable */ public static boolean isNaN (float v) { - int bits = floatToIntBits (v); - int e = bits & 0x7f800000; - int f = bits & 0x007fffff; - - return e == 0x7f800000 && f != 0; + // This works since NaN != NaN is the only reflexive inequality + // comparison which returns true. + return v != v; } /** @@ -393,10 +399,7 @@ public final class Float extends Number implements Comparable */ public static boolean isInfinite (float v) { - int bits = floatToIntBits (v); - int f = bits & 0x7fffffff; - - return f == 0x7f800000; + return (v == POSITIVE_INFINITY || v == NEGATIVE_INFINITY); } /** -- cgit v1.2.1