From 1db0429a13b229a2a2ad43ca895786871f0b4834 Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Mon, 24 May 2010 14:36:32 +0000 Subject: re PR target/44132 (emutls is broken under a range of circumstances.) 2010-05-24 Iain Sandoe PR target/44132 PR middle-end/43602 * varasm.c (get_emutls_init_templ_addr): Copy DECL_PRESERVE_P, DECL_VISIBILITY_SPECIFIED. (emutls_decl): Set DECL_PRESERVE_P and copy DECL_VISIBILITY_SPECIFIED, DECL_RESTRICTED_P. (emutls_finalize_control_var): New callback. (emutls_finish): Finalize emutls control variables. * toplev.c (compile_file): Move the call to emutls_finish () before varpool_assemble_pending_decls (). From-SVN: r159781 --- gcc/varasm.c | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) (limited to 'gcc/varasm.c') diff --git a/gcc/varasm.c b/gcc/varasm.c index ef02994f315..3f8fd02aa8f 100644 --- a/gcc/varasm.c +++ b/gcc/varasm.c @@ -314,13 +314,14 @@ get_emutls_init_templ_addr (tree decl) to = build_decl (DECL_SOURCE_LOCATION (decl), VAR_DECL, name, TREE_TYPE (decl)); SET_DECL_ASSEMBLER_NAME (to, DECL_NAME (to)); - DECL_TLS_MODEL (to) = TLS_MODEL_EMULATED; + DECL_ARTIFICIAL (to) = 1; TREE_USED (to) = TREE_USED (decl); TREE_READONLY (to) = 1; DECL_IGNORED_P (to) = 1; DECL_CONTEXT (to) = DECL_CONTEXT (decl); DECL_SECTION_NAME (to) = DECL_SECTION_NAME (decl); + DECL_PRESERVE_P (to) = DECL_PRESERVE_P (decl); DECL_WEAK (to) = DECL_WEAK (decl); if (DECL_ONE_ONLY (decl)) @@ -333,6 +334,7 @@ get_emutls_init_templ_addr (tree decl) else TREE_STATIC (to) = 1; + DECL_VISIBILITY_SPECIFIED (to) = DECL_VISIBILITY_SPECIFIED (decl); DECL_INITIAL (to) = DECL_INITIAL (decl); DECL_INITIAL (decl) = NULL; @@ -385,6 +387,8 @@ emutls_decl (tree decl) DECL_TLS_MODEL (to) = TLS_MODEL_EMULATED; DECL_ARTIFICIAL (to) = 1; DECL_IGNORED_P (to) = 1; + /* FIXME: work around PR44132. */ + DECL_PRESERVE_P (to) = 1; TREE_READONLY (to) = 0; SET_DECL_ASSEMBLER_NAME (to, DECL_NAME (to)); if (DECL_ONE_ONLY (decl)) @@ -412,6 +416,10 @@ emutls_decl (tree decl) DECL_COMMON (to) = DECL_COMMON (decl); DECL_WEAK (to) = DECL_WEAK (decl); DECL_VISIBILITY (to) = DECL_VISIBILITY (decl); + DECL_VISIBILITY_SPECIFIED (to) = DECL_VISIBILITY_SPECIFIED (decl); + + /* Fortran might pass this to us. */ + DECL_RESTRICTED_P (to) = DECL_RESTRICTED_P (decl); return to; } @@ -450,16 +458,39 @@ emutls_common_1 (void **loc, void *xstmts) return 1; } +/* Callback to finalize one emutls control variable. */ + +static int +emutls_finalize_control_var (void **loc, + void *unused ATTRIBUTE_UNUSED) +{ + struct tree_map *h = *(struct tree_map **) loc; + if (h != NULL) + { + struct varpool_node *node = varpool_node (h->to); + /* Because varpool_finalize_decl () has side-effects, + only apply to un-finalized vars. */ + if (node && !node->finalized) + varpool_finalize_decl (h->to); + } + return 1; +} + +/* Finalize emutls control vars and add a static constructor if + required. */ + void emutls_finish (void) { + if (emutls_htab == NULL) + return; + htab_traverse_noresize (emutls_htab, + emutls_finalize_control_var, NULL); + if (targetm.emutls.register_common) { tree body = NULL_TREE; - if (emutls_htab == NULL) - return; - htab_traverse_noresize (emutls_htab, emutls_common_1, &body); if (body == NULL_TREE) return; -- cgit v1.2.1