From a8cf79e68422820c79e7cc8d78fea274d1b8080b Mon Sep 17 00:00:00 2001 From: uweigand Date: Mon, 21 Sep 2015 14:41:10 +0000 Subject: * config/spu/spu.c (spu_expand_insv): Avoid undefined behavior. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@227974 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 4 ++++ gcc/config/spu/spu.c | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9a2cf21f327..c25888aa09b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2015-09-21 Ulrich Weigand + + * config/spu/spu.c (spu_expand_insv): Avoid undefined behavior. + 2015-09-21 Richard Biener * passes.c (rest_of_decl_compilation): Do not call diff --git a/gcc/config/spu/spu.c b/gcc/config/spu/spu.c index 05c81f5ed73..482145377da 100644 --- a/gcc/config/spu/spu.c +++ b/gcc/config/spu/spu.c @@ -472,7 +472,7 @@ spu_expand_insv (rtx ops[]) { HOST_WIDE_INT width = INTVAL (ops[1]); HOST_WIDE_INT start = INTVAL (ops[2]); - HOST_WIDE_INT maskbits; + unsigned HOST_WIDE_INT maskbits; machine_mode dst_mode; rtx dst = ops[0], src = ops[3]; int dst_size; @@ -527,15 +527,15 @@ spu_expand_insv (rtx ops[]) switch (dst_size) { case 32: - maskbits = (-1ll << (32 - width - start)); + maskbits = (~(unsigned HOST_WIDE_INT)0 << (32 - width - start)); if (start) - maskbits += (1ll << (32 - start)); + maskbits += ((unsigned HOST_WIDE_INT)1 << (32 - start)); emit_move_insn (mask, GEN_INT (maskbits)); break; case 64: - maskbits = (-1ll << (64 - width - start)); + maskbits = (~(unsigned HOST_WIDE_INT)0 << (64 - width - start)); if (start) - maskbits += (1ll << (64 - start)); + maskbits += ((unsigned HOST_WIDE_INT)1 << (64 - start)); emit_move_insn (mask, GEN_INT (maskbits)); break; case 128: -- cgit v1.2.1