<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/flatpak.git, branch history-fix-for-1.12.x</title>
<subtitle>github.com: flatpak/flatpak.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/'/>
<entry>
<title>test-history.sh: Fix flakiness by moving sleep</title>
<updated>2022-01-20T17:11:58+00:00</updated>
<author>
<name>Phaedrus Leeds</name>
<email>mwleeds@protonmail.com</email>
</author>
<published>2022-01-05T17:19:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=d81b3caea0cfd35bb2e5a49dd45a35f5fe615ea6'/>
<id>d81b3caea0cfd35bb2e5a49dd45a35f5fe615ea6</id>
<content type='text'>
The history test fails sometimes in the CI due to the remote add
operation being missing from the history command's output:

+ diff history-log -
0a1
&gt; add remote			system (history-installation)	test-repo

Presumably this is due to that operation happening in the same second
that is passed to --since, so move the sleep statement to make sure a
second passes before we do anything.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The history test fails sometimes in the CI due to the remote add
operation being missing from the history command's output:

+ diff history-log -
0a1
&gt; add remote			system (history-installation)	test-repo

Presumably this is due to that operation happening in the same second
that is passed to --since, so move the sleep statement to make sure a
second passes before we do anything.
</pre>
</div>
</content>
</entry>
<entry>
<title>app: Don't use polkit agent in history command</title>
<updated>2022-01-20T17:11:58+00:00</updated>
<author>
<name>Phaedrus Leeds</name>
<email>mwleeds@protonmail.com</email>
</author>
<published>2021-11-17T18:33:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=fd7f821301c078b271f2397129e7847de3830333'/>
<id>fd7f821301c078b271f2397129e7847de3830333</id>
<content type='text'>
There's no need to use polkit in the history command, so don't start the
agent in flatpak-main.c. This means we can avoid a test failure in
test-history.sh which was caused by old versions of valgrind being
unaware of syscall sched_getattr, which is used in g_bus_get_sync(),
itself called by install_polkit_agent().

(cherry picked from commit dd9fe190661bce70adf4e3df972b8033a656d48a)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There's no need to use polkit in the history command, so don't start the
agent in flatpak-main.c. This means we can avoid a test failure in
test-history.sh which was caused by old versions of valgrind being
unaware of syscall sched_getattr, which is used in g_bus_get_sync(),
itself called by install_polkit_agent().

(cherry picked from commit dd9fe190661bce70adf4e3df972b8033a656d48a)
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a unit test for the history command</title>
<updated>2022-01-20T17:11:58+00:00</updated>
<author>
<name>Phaedrus Leeds</name>
<email>mwleeds@protonmail.com</email>
</author>
<published>2021-10-28T18:42:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=c47e1f45ed6817166df69ec4f3cc7e1ef01c8be6'/>
<id>c47e1f45ed6817166df69ec4f3cc7e1ef01c8be6</id>
<content type='text'>
(cherry picked from commit 1b6de2518bf3bd03b8308d5bc3c9c8aff85a6293)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(cherry picked from commit 1b6de2518bf3bd03b8308d5bc3c9c8aff85a6293)
</pre>
</div>
</content>
</entry>
<entry>
<title>history: Fix exclusion of temp repos</title>
<updated>2022-01-20T17:11:58+00:00</updated>
<author>
<name>Phaedrus Leeds</name>
<email>mwleeds@protonmail.com</email>
</author>
<published>2021-10-28T19:37:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=f8fab60eb8358ca0b4be851452847a2f90938092'/>
<id>f8fab60eb8358ca0b4be851452847a2f90938092</id>
<content type='text'>
Without this change there are history entries showing pulls into
temporary repos which we don't want.

(cherry picked from commit e18df8379a88fd1cd0272d6a6cbec4afc57d1397)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Without this change there are history entries showing pulls into
temporary repos which we don't want.

(cherry picked from commit e18df8379a88fd1cd0272d6a6cbec4afc57d1397)
</pre>
</div>
</content>
</entry>
<entry>
<title>history: Omit entries for appstream refs</title>
<updated>2022-01-20T17:11:58+00:00</updated>
<author>
<name>Phaedrus Leeds</name>
<email>mwleeds@protonmail.com</email>
</author>
<published>2021-10-28T18:16:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=cca5457e66cd4db5400c5aed09eb1a1c5333358b'/>
<id>cca5457e66cd4db5400c5aed09eb1a1c5333358b</id>
<content type='text'>
Currently we include entries in the output of the history command for
pulls of appstream refs, e.g. "appstream2/x86_64". However since they
don't have an application ID the Application column shows up blank and
it seems like a pull of nothing which is confusing. These are basically
an implementation detail like the temp repo pulls we already exclude, so
I think it makes sense to exclude them from the output.

It would also make sense to exclude pulls of ostree-metadata refs, but
for some reason I don't see those in practice, even with a collection ID
set on the remote.

(cherry picked from commit fbad9641b73632c0577d0dc9c38f1ea9c8aa6223)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently we include entries in the output of the history command for
pulls of appstream refs, e.g. "appstream2/x86_64". However since they
don't have an application ID the Application column shows up blank and
it seems like a pull of nothing which is confusing. These are basically
an implementation detail like the temp repo pulls we already exclude, so
I think it makes sense to exclude them from the output.

It would also make sense to exclude pulls of ostree-metadata refs, but
for some reason I don't see those in practice, even with a collection ID
set on the remote.

(cherry picked from commit fbad9641b73632c0577d0dc9c38f1ea9c8aa6223)
</pre>
</div>
</content>
</entry>
<entry>
<title>history: Fix printing refs</title>
<updated>2022-01-20T17:11:58+00:00</updated>
<author>
<name>Phaedrus Leeds</name>
<email>mwleeds@protonmail.com</email>
</author>
<published>2021-10-28T01:56:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=a5c1eff9e569cd3159be129495c9c3e7289edb60'/>
<id>a5c1eff9e569cd3159be129495c9c3e7289edb60</id>
<content type='text'>
The history command seems to have been broken since it was changed to
use FlatpakDecomposed, since that type only works for app or runtime
refs, resulting in errors such as:
$ flatpak history
error: appstream2/x86_64 is not application or runtime

Fix this by making the logic a bit smarter, and don't let any one
invalid ref entry prevent the whole command from working.

Fixes #4332
(cherry picked from commit e44b54856e98fb080ded77159979ddd6022981f2)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The history command seems to have been broken since it was changed to
use FlatpakDecomposed, since that type only works for app or runtime
refs, resulting in errors such as:
$ flatpak history
error: appstream2/x86_64 is not application or runtime

Fix this by making the logic a bit smarter, and don't let any one
invalid ref entry prevent the whole command from working.

Fixes #4332
(cherry picked from commit e44b54856e98fb080ded77159979ddd6022981f2)
</pre>
</div>
</content>
</entry>
<entry>
<title>dir: Fix typo of bundle</title>
<updated>2022-01-19T12:52:13+00:00</updated>
<author>
<name>Phaedrus Leeds</name>
<email>mwleeds@protonmail.com</email>
</author>
<published>2022-01-12T19:22:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=786f64dc5b7a69c8984676a79ee4f7ecaad12a7a'/>
<id>786f64dc5b7a69c8984676a79ee4f7ecaad12a7a</id>
<content type='text'>
(cherry picked from commit a626003d6d57d807bd5e6cfd2abbd77407961ecc)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(cherry picked from commit a626003d6d57d807bd5e6cfd2abbd77407961ecc)
</pre>
</div>
</content>
</entry>
<entry>
<title>Regenerate translation files for release</title>
<updated>2022-01-18T17:38:36+00:00</updated>
<author>
<name>Simon McVittie</name>
<email>smcv@collabora.com</email>
</author>
<published>2022-01-18T17:38:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=103ed5c02c8453580fac19e5122d150f44f6774f'/>
<id>103ed5c02c8453580fac19e5122d150f44f6774f</id>
<content type='text'>
Signed-off-by: Simon McVittie &lt;smcv@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Simon McVittie &lt;smcv@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Release v1.12.4</title>
<updated>2022-01-18T17:34:01+00:00</updated>
<author>
<name>Simon McVittie</name>
<email>smcv@collabora.com</email>
</author>
<published>2022-01-18T17:27:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=d19ed758f95cd1c285d7e63acac749f68aecbe6b'/>
<id>d19ed758f95cd1c285d7e63acac749f68aecbe6b</id>
<content type='text'>
Signed-off-by: Simon McVittie &lt;smcv@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Simon McVittie &lt;smcv@collabora.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>NEWS: Describe what is intended to appear in 1.12.4</title>
<updated>2022-01-18T16:35:28+00:00</updated>
<author>
<name>Simon McVittie</name>
<email>smcv@collabora.com</email>
</author>
<published>2022-01-18T15:43:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/flatpak.git/commit/?id=617494c63fc6f7a2ef9cd33cffe1c9c16ce6b014'/>
<id>617494c63fc6f7a2ef9cd33cffe1c9c16ce6b014</id>
<content type='text'>
Signed-off-by: Simon McVittie &lt;smcv@collabora.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Simon McVittie &lt;smcv@collabora.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
