From 32cebe903d39ef212b19f040e68cd35bcfe2b21b Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Mon, 25 Jun 2018 15:18:23 -0400 Subject: tests: split a large failure case for eina_file tests to provide more info Summary: each failure case should always be separate in order to provide the highest degree of detail available if a test fails Reviewers: devilhorns, ManMower Reviewed By: ManMower Subscribers: ManMower, cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6373 --- src/tests/eina/eina_test_file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tests/eina/eina_test_file.c b/src/tests/eina/eina_test_file.c index 5810d850c8..242922083f 100644 --- a/src/tests/eina/eina_test_file.c +++ b/src/tests/eina/eina_test_file.c @@ -774,7 +774,9 @@ EFL_START_TEST(eina_test_file_mktemp) errno = 0; tmpfile = NULL; fd = eina_file_mkstemp(patterns[k], &tmpfile); - fail_if((fd < 0) || !tmpfile || errno); + ck_assert(fd >= 0); + ck_assert(!!tmpfile); + ck_assert_msg(!errno, "ERROR(%s): %s\n", patterns[k], strerror(errno)); file = eina_file_open(tmpfile, EINA_FALSE); fail_if(!file); eina_file_close(file); -- cgit v1.2.1