From 1688b5d5116f2d422b21c4f540008b2c21bb4d42 Mon Sep 17 00:00:00 2001 From: Christopher Michael Date: Fri, 15 Mar 2019 08:57:24 -0400 Subject: elm_atspi_bridge: Fix resource leak Summary: Coverity reports a resource leak here because the dbus 'reply' message is never unref'd. Fix that. Fixes Coverity CID1399429 @fix Depends on D8344 Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8345 --- src/lib/elementary/elm_atspi_bridge.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/elementary/elm_atspi_bridge.c b/src/lib/elementary/elm_atspi_bridge.c index f9589a6ee4..e1dc3ef241 100644 --- a/src/lib/elementary/elm_atspi_bridge.c +++ b/src/lib/elementary/elm_atspi_bridge.c @@ -4707,6 +4707,8 @@ _elm_atspi_bridge_key_filter(void *data, void *loop EINA_UNUSED, int type, void if (!eldbus_message_arguments_get(reply, "b", &ret)) ERR("Invalid answer signature"); + eldbus_message_unref(reply); + if (ret) return EINA_FALSE; -- cgit v1.2.1