From b8c74742c0238fe15b1cdc9a7f6ee021d038368f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= Date: Tue, 21 May 2019 12:19:38 +0200 Subject: Tighter pcase or-pattern member function selection (bug#36139) * lisp/emacs-lisp/pcase.el (pcase--u1): Use the most specific of `memq', `memql' and `member' in or-patterns with constant cases. This improves performance and may help the byte-code compiler generate a switch. * test/lisp/emacs-lisp/pcase-tests.el (pcase-tests-member): Add mixed-type or-pattern test cases. --- test/lisp/emacs-lisp/pcase-tests.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'test/lisp/emacs-lisp/pcase-tests.el') diff --git a/test/lisp/emacs-lisp/pcase-tests.el b/test/lisp/emacs-lisp/pcase-tests.el index af8c9a3f3c3..e8c0b8219c5 100644 --- a/test/lisp/emacs-lisp/pcase-tests.el +++ b/test/lisp/emacs-lisp/pcase-tests.el @@ -51,9 +51,11 @@ (ert-deftest pcase-tests-member () (should (pcase-tests-grep - 'memql (macroexpand-all '(pcase x ((or 1 2 3) body))))) + 'memq (macroexpand-all '(pcase x ((or 'a 'b 'c) body))))) (should (pcase-tests-grep - 'member (macroexpand-all '(pcase x ((or "a" 2 3) body))))) + 'memql (macroexpand-all '(pcase x ((or 1 2 3 'a) body))))) + (should (pcase-tests-grep + 'member (macroexpand-all '(pcase x ((or "a" 2 3 'a) body))))) (should-not (pcase-tests-grep 'memq (macroexpand-all '(pcase x ((or "a" 2 3) body))))) (should-not (pcase-tests-grep -- cgit v1.2.1