From f4eb8900295d75c4afec256f75aea22494376fde Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 30 Sep 2016 12:14:04 -0700 Subject: =?UTF-8?q?Limit=20=E2=80=99s=20includes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This follows up on recent problems with the fact that config.h includes stdlib.h etc.; some files need to include stdlib.h later. config.h generally should limit itself to includes that are universally safe; outside of MS-Windows, only stdbool.h makes the cut among the files currently included. So, move the other includes to just the files that need them (Bug#24506). * configure.ac (config_opsysfile): Remove, as this generic hook is no longer needed. * lib-src/etags.c, src/unexmacosx.c, src/w32.c, src/w32notify.c: * src/w32proc.c (_GNU_SOURCE): Remove, as it’s OK for config.h to do this now. * src/conf_post.h: Include , instead of the generic config_opsysfile, for simplicity as this old way of configuring is now done only for the MS-Windows port. Do not include if DEFER_MS_W32_H, for the benefit of the few files that want its effects later. Do not include , , or . Other files modified to include these headers as needed, or to not include headers that are no longer needed. * src/lisp.h: Include and here, since some of the inline functions need them. * src/regex.c: Include if not emacs. (If emacs, we can rely on SAFE_ALLOCA.) There is no longer any need to worry about HAVE_ALLOCA_H. * src/unexmacosx.c: Rely on config.h not including stdlib.h. * src/w32.c, src/w32notify.c, src/w32proc.c (DEFER_MS_W32_H): Define before including first, and include after the troublesome headers. --- src/unexcw.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/unexcw.c') diff --git a/src/unexcw.c b/src/unexcw.c index 6343b38bcff..c0d1bc176a5 100644 --- a/src/unexcw.c +++ b/src/unexcw.c @@ -21,7 +21,6 @@ along with GNU Emacs. If not, see . */ #include #include "unexec.h" #include "lisp.h" -#include #include #include #include -- cgit v1.2.1