From 47679e63230da94cffed568a4d5167ffc1baea96 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 31 Jan 2019 15:31:41 -0800 Subject: Prefer static to extern where either will do MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * src/charset.c (charset_table_size): * src/pdumper.c (dump_private): * src/sysdep.c (init_sigsegv): * src/window.c (old_selected_window): Now static. * src/charset.c (charset_table_size): Now int, since the value always fits in int. * src/gtkutil.c (xg_gtk_initialized): Now present only if HAVE_XWIDGETS, to make it clearer that this is an xwidgets hack. All uses changed. * src/lread.c (ndefsubr): Remove; unused. * src/pdumper.h: Use usual GNU indenting style for functions, since my static-vs-extern checking hack relies on it. (dump_public): Always declare; simpler and doesn’t hurt. (pdumper_handle_page_fault): Remove unused decl. --- src/pdumper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/pdumper.c') diff --git a/src/pdumper.c b/src/pdumper.c index d4fbc4b0494..301a52804f0 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -5019,7 +5019,7 @@ struct pdumper_loaded_dump_private }; struct pdumper_loaded_dump dump_public; -struct pdumper_loaded_dump_private dump_private; +static struct pdumper_loaded_dump_private dump_private; /* Return a pointer to offset OFFSET within the dump, which begins at DUMP_BASE. DUMP_BASE must be equal to the current dump load -- cgit v1.2.1