From 0adc75af1833cd46aab339ce7f1ca5d6919c70af Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 15 Jan 2015 20:37:05 -0800 Subject: Give up on -Wsuggest-attribute=const The attribute doesn't help performance significantly, and the warning seems to be more trouble than it's worth. See the thread at: http://lists.gnu.org/archive/html/emacs-devel/2015-01/msg00361.html * configure.ac (WERROR_CFLAGS): Don't use -Wsuggest-attribute=const. * lib-src/make-docfile.c (write_globals): Remove special hack for Fnext_read_file_uses_dialog_p. * src/decompress.c (Fzlib_available_p): * src/gnutls.c (Fgnutls_available_p): * src/gtkutil.h (xg_uses_old_file_dialog): * src/xdisp.c (Ftool_bar_height): * src/xmenu.c (popup_activated): No longer const, since it's not const on at lest some configurations, and we shouldn't lie to the compiler. --- configure.ac | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'configure.ac') diff --git a/configure.ac b/configure.ac index 4cad214e928..9db4bdecfcc 100644 --- a/configure.ac +++ b/configure.ac @@ -892,6 +892,10 @@ else # Emacs's use of alloca inhibits protecting the stack. nw="$nw -Wstack-protector" + # Emacs's use of partly-const functions such as Fgnutls_available_p + # make this option problematic. + nw="$nw -Wsuggest-attribute=const" + # Emacs's use of partly-pure functions such as CHECK_TYPE make this # option problematic. nw="$nw -Wsuggest-attribute=pure" @@ -1974,7 +1978,6 @@ fi if test "$window_system" = none && test "$gl_gcc_warnings" = yes; then # Too many warnings for now. nw= - nw="$nw -Wsuggest-attribute=const" nw="$nw -Wsuggest-attribute=noreturn" gl_MANYWARN_COMPLEMENT([WARN_CFLAGS], [$WARN_CFLAGS], [$nw]) -- cgit v1.2.1