From 55ad194922d357e7ee2c0d728a51dbfee54bcf0c Mon Sep 17 00:00:00 2001 From: Lars Ingebrigtsen Date: Thu, 20 Feb 2020 14:44:16 +0100 Subject: Fix submit button rendering in eww * lisp/net/eww.el (eww-form-submit): Use the contents of the for the string if there is no value (bug#39326). --- lisp/net/eww.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 811d7c69209..c83884fd259 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1107,11 +1107,13 @@ just re-display the HTML already fetched." (defun eww-form-submit (dom) (let ((start (point)) (value (dom-attr dom 'value))) - (setq value - (if (zerop (length value)) - "Submit" - value)) - (insert value) + (if (null value) + (shr-generic dom) + (insert value)) + ;; If the contents of the turns out to be + ;; empty, or the value was blank, default to this: + (when (= (point) start) + (insert "Submit")) (add-face-text-property start (point) 'eww-form-submit) (put-text-property start (point) 'eww-form (list :eww-form eww-form -- cgit v1.2.1