From 2bdc419f51630eb433deb139da67e419000c7694 Mon Sep 17 00:00:00 2001 From: Konstantin Kharlamov Date: Thu, 16 May 2019 00:25:53 +0300 Subject: Do potentially destructive operations in prepare-commit-msg * build-aux/git-hooks/prepare-commit-msg: If someone occasionally puts Signed-off line, it will likely get there through -s option of git. Exploit this fact to abort before a user got a chance to type commit message. (Bug#35368) --- autogen.sh | 2 +- build-aux/git-hooks/prepare-commit-msg | 45 ++++++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100755 build-aux/git-hooks/prepare-commit-msg diff --git a/autogen.sh b/autogen.sh index 7972f01b387..bf8d61f0c65 100755 --- a/autogen.sh +++ b/autogen.sh @@ -323,7 +323,7 @@ git_config diff.texinfo.xfuncname \ tailored_hooks= sample_hooks= -for hook in commit-msg pre-commit; do +for hook in commit-msg pre-commit prepare-commit-msg; do cmp -- build-aux/git-hooks/$hook "$hooks/$hook" >/dev/null 2>&1 || tailored_hooks="$tailored_hooks $hook" done diff --git a/build-aux/git-hooks/prepare-commit-msg b/build-aux/git-hooks/prepare-commit-msg new file mode 100755 index 00000000000..3562a802234 --- /dev/null +++ b/build-aux/git-hooks/prepare-commit-msg @@ -0,0 +1,45 @@ +#!/bin/sh +# Check the format of GNU Emacs change log entries. + +# Copyright 2019 Free Software Foundation, Inc. + +# This file is part of GNU Emacs. + +# GNU Emacs is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# GNU Emacs is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with GNU Emacs. If not, see . + +COMMIT_MSG_FILE=$1 +COMMIT_SOURCE=$2 +SHA1=$3 + +# Prefer gawk if available, as it handles NUL bytes properly. +if type gawk >/dev/null 2>&1; then + awk=gawk +else + awk=awk +fi + +exec $awk ' + # Catch the case when someone ran git-commit with -s option, + # which automatically adds Signed-off-by. + /^Signed-off-by: / { + print "'\''Signed-off-by:'\'' in commit message" + status = 1 + } + END { + if (status != 0) { + print "Commit aborted; please see the file 'CONTRIBUTE'" + } + exit status + } +' <"$COMMIT_MSG_FILE" -- cgit v1.2.1 From 5d24af87c15d9baa9db96fe3c3200d5585d58c4e Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Fri, 17 May 2019 09:58:15 +0300 Subject: Remove from docs references to obsolete MULE variables * src/search.c (search_buffer): Remove obsolete text from a comment. * src/fns.c (Fstring_make_unibyte): Remove obsolete text from a doc string. --- src/fns.c | 6 ++---- src/search.c | 7 +------ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/fns.c b/src/fns.c index d6299755201..8db2a86a725 100644 --- a/src/fns.c +++ b/src/fns.c @@ -1042,10 +1042,8 @@ string the same way whether it is unibyte or multibyte.) */) DEFUN ("string-make-unibyte", Fstring_make_unibyte, Sstring_make_unibyte, 1, 1, 0, doc: /* Return the unibyte equivalent of STRING. -Multibyte character codes are converted to unibyte according to -`nonascii-translation-table' or, if that is nil, `nonascii-insert-offset'. -If the lookup in the translation table fails, this function takes just -the low 8 bits of each character. */) +Multibyte character codes above 255 are converted to unibyte +by taking just the low 8 bits of each character's code. */) (Lisp_Object string) { CHECK_STRING (string); diff --git a/src/search.c b/src/search.c index 9bde884bc53..db7fecd9bab 100644 --- a/src/search.c +++ b/src/search.c @@ -1341,12 +1341,7 @@ search_buffer (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, } else { - /* Converting multibyte to single-byte. - - ??? Perhaps this conversion should be done in a special way - by subtracting nonascii-insert-offset from each non-ASCII char, - so that only the multibyte chars which really correspond to - the chosen single-byte character set can possibly match. */ + /* Converting multibyte to single-byte. */ raw_pattern_size = SCHARS (string); raw_pattern_size_byte = SCHARS (string); raw_pattern = SAFE_ALLOCA (raw_pattern_size + 1); -- cgit v1.2.1