From 2eedce110ac090c55aed4756152b6deb16229cdd Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Thu, 14 Apr 2016 21:32:55 +0200 Subject: libdwfl: Fix memory leak in proc_maps_report on bad file mapping. Normally last_file is freed inside report(), but in the case of a bad file mapping we don't call report. Signed-off-by: Mark Wielaard --- libdwfl/ChangeLog | 5 +++++ libdwfl/linux-proc-maps.c | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) (limited to 'libdwfl') diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index 5d400bb1..60ed7009 100644 --- a/libdwfl/ChangeLog +++ b/libdwfl/ChangeLog @@ -1,3 +1,8 @@ +2016-04-14 Mark Wielaard + + * linux-proc-maps.c (proc_maps_report): Free last_file on bad file + mapping. + 2016-03-01 Steven Chamberlain * linux-pid-attach.c: Removed unused pid_thread_callbacks, diff --git a/libdwfl/linux-proc-maps.c b/libdwfl/linux-proc-maps.c index 94b26d59..4ae1e74a 100644 --- a/libdwfl/linux-proc-maps.c +++ b/libdwfl/linux-proc-maps.c @@ -250,7 +250,10 @@ proc_maps_report (Dwfl *dwfl, FILE *f, GElf_Addr sysinfo_ehdr, pid_t pid) { /* This is another portion of the same file's mapping. */ if (strcmp (last_file, file) != 0) - goto bad_report; + { + free (last_file); + goto bad_report; + } high = end; } else -- cgit v1.2.1