delta/docker.git/libnetwork/ipamapi, branch master github.com: dotcloud/docker.git libnetwork: drop DatastoreConfig discovery type 2023-01-27T16:47:43+00:00 Cory Snider csnider@mirantis.com 2023-01-24T23:49:24+00:00 a08a254df38840be8f6b561c91d98cf8acf8d82e The DatastoreConfig discovery type is unused. Remove the constant and any resulting dead code. Today's biggest loser is the IPAM Allocator: DatastoreConfig was the only type of discovery event it was listening for, and there was no other place where a non-nil datastore could be passed into the allocator. Strip out all the dead persistence code from Allocator, leaving it as purely an in-memory implementation. There is no more need to check the consistency of the allocator's bit-sequences as there is no persistent storage for inconsistent bit sequences to be loaded from. Signed-off-by: Cory Snider <csnider@mirantis.com> 
The DatastoreConfig discovery type is unused. Remove the constant and
any resulting dead code. Today's biggest loser is the IPAM Allocator:
DatastoreConfig was the only type of discovery event it was listening
for, and there was no other place where a non-nil datastore could be
passed into the allocator. Strip out all the dead persistence code from
Allocator, leaving it as purely an in-memory implementation.

There is no more need to check the consistency of the allocator's
bit-sequences as there is no persistent storage for inconsistent bit
sequences to be loaded from.

Signed-off-by: Cory Snider <csnider@mirantis.com>
libnet: un-plumb datastores from IPAM inits 2023-01-27T16:47:42+00:00 Cory Snider csnider@mirantis.com 2023-01-24T19:26:03+00:00 d478e13639980aba8af3a25cb9cbfefb19eaf1f9 The datastore arguments to the IPAM driver Init() functions are always nil, even in Swarmkit. The only IPAM driver which consumed the datastores was builtin; all others (null, remote, windowsipam) simply ignored it. As the signatures of the IPAM driver init functions cannot be changed without breaking the Swarmkit build, they have to be left with the same signatures for the time being. Assert that nil datastores are always passed into the builtin IPAM driver's init function so that there is no ambiguity the datastores are no longer respected. Add new Register functions for the IPAM drivers which are free from the legacy baggage of the Init functions. (The legacy Init functions can be removed once Swarmkit is migrated to using the Register functions.) As the remote IPAM driver is the only one which depends on a PluginGetter, pass it in explicitly as an argument to Register. The other IPAM drivers should not be forced to depend on a GetPluginGetter() method they do not use (Interface Segregation Principle). Signed-off-by: Cory Snider <csnider@mirantis.com> 
The datastore arguments to the IPAM driver Init() functions are always
nil, even in Swarmkit. The only IPAM driver which consumed the
datastores was builtin; all others (null, remote, windowsipam) simply
ignored it. As the signatures of the IPAM driver init functions cannot
be changed without breaking the Swarmkit build, they have to be left
with the same signatures for the time being. Assert that nil datastores
are always passed into the builtin IPAM driver's init function so that
there is no ambiguity the datastores are no longer respected.

Add new Register functions for the IPAM drivers which are free from the
legacy baggage of the Init functions. (The legacy Init functions can be
removed once Swarmkit is migrated to using the Register functions.) As
the remote IPAM driver is the only one which depends on a PluginGetter,
pass it in explicitly as an argument to Register. The other IPAM drivers
should not be forced to depend on a GetPluginGetter() method they do not
use (Interface Segregation Principle).

Signed-off-by: Cory Snider <csnider@mirantis.com>
libnetwork/ipamapi: godoc fixes 2021-08-27T14:52:46+00:00 Sebastiaan van Stijn github@gone.nl 2021-08-26T08:10:19+00:00 c23eae311470c831228bcb4749f176a21174c807 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Fixup libnetwork lint errors 2021-06-01T23:48:32+00:00 Brian Goff cpuguy83@gmail.com 2021-05-28T00:15:56+00:00 4b981436fe26724883cee71c15f218993ab53c5b Signed-off-by: Brian Goff <cpuguy83@gmail.com> 
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Fix libnetwork imports 2021-06-01T21:51:23+00:00 Brian Goff cpuguy83@gmail.com 2021-04-06T00:24:47+00:00 a0a473125bad04b66042aaafb331243dfd2d77f9 After moving libnetwork to this repo, we need to update all the import paths for libnetwork to point to docker/docker/libnetwork instead of docker/libnetwork. This change implements that. Signed-off-by: Brian Goff <cpuguy83@gmail.com> 
After moving libnetwork to this repo, we need to update all the import
paths for libnetwork to point to docker/docker/libnetwork instead of
docker/libnetwork.
This change implements that.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Adding a unit case to verify rollover 2017-10-03T19:15:34+00:00 Abhinandan Prativadi abhi@docker.com 2017-06-01T02:41:21+00:00 3d4497599543a1314318565ebd9b27e9c0f7d6b1 Signed-off-by: Abhinandan Prativadi <abhi@docker.com> 
Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
Internal interface to differentiate built-in drivers from remote 2016-12-19T13:17:42+00:00 Madhu Venugopal madhu@docker.com 2016-12-19T03:56:34+00:00 1b28c5e01d1cab44672899382ea145878490e796 Signed-off-by: Madhu Venugopal <madhu@docker.com> 
Signed-off-by: Madhu Venugopal <madhu@docker.com>
Update plugingetter import path. 2016-10-07T19:00:57+00:00 Anusha Ragunathan anusha@docker.com 2016-10-07T18:58:10+00:00 5c77ba43e26aa9523cf5c2335466d6da6f364185 Signed-off-by: Anusha Ragunathan <anusha@docker.com> 
Signed-off-by: Anusha Ragunathan <anusha@docker.com>
Make libnetwork understand pluginv2. 2016-09-27T22:29:10+00:00 Anusha Ragunathan anusha@docker.com 2016-09-27T20:54:25+00:00 003e04775b1a937e2cfb1f0c25c6406141e3a14b As part of daemon init, network and ipam drivers are passed a pluginstore object that implements the plugin/getter interface. Use this interface methods in libnetwork to interact with network plugins. This interface provides the new and improved pluginv2 functionality and falls back to pluginv1 (legacy) if necessary. Signed-off-by: Anusha Ragunathan <anusha@docker.com> 
As part of daemon init, network and ipam drivers are passed a
pluginstore object that implements the plugin/getter interface. Use this
interface methods in libnetwork to interact with network plugins. This
interface provides the new and improved pluginv2 functionality and falls
back to pluginv1 (legacy) if necessary.

Signed-off-by: Anusha Ragunathan <anusha@docker.com>
Merge pull request #1205 from allencloud/fix-typos 2016-08-01T16:49:31+00:00 Jana Radhakrishnan mrjana@docker.com 2016-08-01T16:49:31+00:00 8a225de00dc95bca0c967ed3467763a667eebe61 use grep to find a/an misuse 
use grep to find a/an misuse