<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/docker.git/libnetwork/drivers/windows/overlay, branch master</title>
<subtitle>github.com: dotcloud/docker.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/'/>
<entry>
<title>libnetwork: remove unused props from windows overlay driver</title>
<updated>2023-04-06T17:33:04+00:00</updated>
<author>
<name>Albin Kerouanton</name>
<email>albinker@gmail.com</email>
</author>
<published>2023-02-10T15:03:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=c8d2c6ea770c7f2c19f6394cfa23128f2c1099b8'/>
<id>c8d2c6ea770c7f2c19f6394cfa23128f2c1099b8</id>
<content type='text'>
The overlay driver was creating a global store whenever
netlabel.GlobalKVClient was specified in its config argument. This
specific label is unused anymore since 142b522 (moby/moby#44875).

It was also creating a local store whenever netlabel.LocalKVClient was
specificed in its config argument. This store is unused since
moby/libnetwork@9e72136 (moby/libnetwork#1636).

Finally, the sync.Once properties are never used and thus can be
deleted.

Signed-off-by: Albin Kerouanton &lt;albinker@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The overlay driver was creating a global store whenever
netlabel.GlobalKVClient was specified in its config argument. This
specific label is unused anymore since 142b522 (moby/moby#44875).

It was also creating a local store whenever netlabel.LocalKVClient was
specificed in its config argument. This store is unused since
moby/libnetwork@9e72136 (moby/libnetwork#1636).

Finally, the sync.Once properties are never used and thus can be
deleted.

Signed-off-by: Albin Kerouanton &lt;albinker@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libnet: convert to new-style driver registration</title>
<updated>2023-01-27T16:47:42+00:00</updated>
<author>
<name>Cory Snider</name>
<email>csnider@mirantis.com</email>
</author>
<published>2023-01-24T23:19:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=28edc8e2d692cb47f1ec6bb32a6e346777e1250d'/>
<id>28edc8e2d692cb47f1ec6bb32a6e346777e1250d</id>
<content type='text'>
Per the Interface Segregation Principle, network drivers should not have
to depend on GetPluginGetter methods they do not use. The remote network
driver is the only one which needs a PluginGetter, and it is already
special-cased in Controller so there is no sense warping the interfaces
to achieve a foolish consistency. Replace all other network drivers' Init
functions with Register functions which take a driverapi.Registerer
argument instead of a driverapi.DriverCallback. Add back in Init wrapper
functions for only the drivers which Swarmkit references so that
Swarmkit can continue to build.

Refactor the libnetwork Controller to use the new drvregistry.Networks
and drvregistry.IPAMs driver registries in place of the legacy ones.

Signed-off-by: Cory Snider &lt;csnider@mirantis.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Per the Interface Segregation Principle, network drivers should not have
to depend on GetPluginGetter methods they do not use. The remote network
driver is the only one which needs a PluginGetter, and it is already
special-cased in Controller so there is no sense warping the interfaces
to achieve a foolish consistency. Replace all other network drivers' Init
functions with Register functions which take a driverapi.Registerer
argument instead of a driverapi.DriverCallback. Add back in Init wrapper
functions for only the drivers which Swarmkit references so that
Swarmkit can continue to build.

Refactor the libnetwork Controller to use the new drvregistry.Networks
and drvregistry.IPAMs driver registries in place of the legacy ones.

Signed-off-by: Cory Snider &lt;csnider@mirantis.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libnetwork/windows/overlay: drop unused variables</title>
<updated>2023-01-24T19:44:19+00:00</updated>
<author>
<name>Bjorn Neergaard</name>
<email>bneergaard@mirantis.com</email>
</author>
<published>2023-01-21T23:25:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=390532cbc677b2796c8aeeff74b1a17a3ba97c31'/>
<id>390532cbc677b2796c8aeeff74b1a17a3ba97c31</id>
<content type='text'>
These package-level variables were copied over from the Linux
implementation; drop them for clarity's sake.

Signed-off-by: Bjorn Neergaard &lt;bneergaard@mirantis.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These package-level variables were copied over from the Linux
implementation; drop them for clarity's sake.

Signed-off-by: Bjorn Neergaard &lt;bneergaard@mirantis.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Windows: require Windows Server RS5 / ltsc2019 (build 17763) as minimum</title>
<updated>2022-02-18T21:58:28+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2022-02-17T16:08:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=1b3fef5333544687f374658d0dd9e8571630287f'/>
<id>1b3fef5333544687f374658d0dd9e8571630287f</id>
<content type='text'>
Windows Server 2016 (RS1) reached end of support, and Docker Desktop requires
Windows 10 V19H2 (version 1909, build 18363) as a minimum.

This patch makes Windows Server RS5 /  ltsc2019 (build 17763) the minimum version
to run the daemon, and removes some hacks for older versions of Windows.

There is one check remaining that checks for Windows RS3 for a workaround
on older versions, but recent changes in Windows seemed to have regressed
on the same issue, so I kept that code for now to check if we may need that
workaround (again);

https://github.com/moby/moby/blob/085c6a98d54720e70b28354ccec6da9b1b9e7fcf/daemon/graphdriver/windows/windows.go#L319-L341

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Windows Server 2016 (RS1) reached end of support, and Docker Desktop requires
Windows 10 V19H2 (version 1909, build 18363) as a minimum.

This patch makes Windows Server RS5 /  ltsc2019 (build 17763) the minimum version
to run the daemon, and removes some hacks for older versions of Windows.

There is one check remaining that checks for Windows RS3 for a workaround
on older versions, but recent changes in Windows seemed to have regressed
on the same issue, so I kept that code for now to check if we may need that
workaround (again);

https://github.com/moby/moby/blob/085c6a98d54720e70b28354ccec6da9b1b9e7fcf/daemon/graphdriver/windows/windows.go#L319-L341

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix libnetwork imports</title>
<updated>2021-06-01T21:51:23+00:00</updated>
<author>
<name>Brian Goff</name>
<email>cpuguy83@gmail.com</email>
</author>
<published>2021-04-06T00:24:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=a0a473125bad04b66042aaafb331243dfd2d77f9'/>
<id>a0a473125bad04b66042aaafb331243dfd2d77f9</id>
<content type='text'>
After moving libnetwork to this repo, we need to update all the import
paths for libnetwork to point to docker/docker/libnetwork instead of
docker/libnetwork.
This change implements that.

Signed-off-by: Brian Goff &lt;cpuguy83@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After moving libnetwork to this repo, we need to update all the import
paths for libnetwork to point to docker/docker/libnetwork instead of
docker/libnetwork.
This change implements that.

Signed-off-by: Brian Goff &lt;cpuguy83@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace use of deprecated functions</title>
<updated>2020-09-11T23:49:42+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2020-08-31T18:18:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=bf28003c99ef6900d0b006450cd9b6bdf3a23f72'/>
<id>bf28003c99ef6900d0b006450cd9b6bdf3a23f72</id>
<content type='text'>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Pick a random host port if the user does not specify a host port.</title>
<updated>2019-04-22T17:43:27+00:00</updated>
<author>
<name>Pradip Dhara</name>
<email>pradipd@microsoft.com</email>
</author>
<published>2019-04-17T17:54:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=1909ecb27aa11ccac47465f170dd2e17d94ea4d7'/>
<id>1909ecb27aa11ccac47465f170dd2e17d94ea4d7</id>
<content type='text'>
For overlay, l2bridge, and l2tunnel, if the user does not specify a host port, windows driver will select a random port for them.  This matches linux behavior.
For ics and nat networks the windows OS will choose the port.

Signed-off-by: Pradip Dhara &lt;pradipd@microsoft.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For overlay, l2bridge, and l2tunnel, if the user does not specify a host port, windows driver will select a random port for them.  This matches linux behavior.
For ics and nat networks the windows OS will choose the port.

Signed-off-by: Pradip Dhara &lt;pradipd@microsoft.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Adding error log if peerAdd fails</title>
<updated>2019-04-06T03:31:17+00:00</updated>
<author>
<name>Madhu Venugopal</name>
<email>madhu@docker.com</email>
</author>
<published>2019-04-06T01:20:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=5c6423fb2931622a83b5116bfe3b740c2e8589f6'/>
<id>5c6423fb2931622a83b5116bfe3b740c2e8589f6</id>
<content type='text'>
Signed-off-by: Madhu Venugopal &lt;madhu@docker.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Madhu Venugopal &lt;madhu@docker.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Adding synchronization to endpoint addition/deletion to prevent network connectivity issue</title>
<updated>2019-04-05T21:19:19+00:00</updated>
<author>
<name>Pradip Dhara</name>
<email>pradipd@microsoft.com</email>
</author>
<published>2019-04-05T16:23:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=94ab7b2df62d246cf08f497b780d3933e5abc7b7'/>
<id>94ab7b2df62d246cf08f497b780d3933e5abc7b7</id>
<content type='text'>
Signed-off-by: Pradip Dhara &lt;pradipd@microsoft.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Pradip Dhara &lt;pradipd@microsoft.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Use fmt precision to limit string length</title>
<updated>2018-07-05T21:44:04+00:00</updated>
<author>
<name>Chris Telfer</name>
<email>ctelfer@docker.com</email>
</author>
<published>2018-07-05T20:33:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=06922d2d81efb12dc2f400c6cc4cdac03db2086c'/>
<id>06922d2d81efb12dc2f400c6cc4cdac03db2086c</id>
<content type='text'>
The previous code used string slices to limit the length of certain
fields like endpoint or sandbox IDs.  This assumes that these strings
are at least as long as the slice length.  Unfortunately, some sandbox
IDs can be smaller than 7 characters.   This fix addresses this issue
by systematically converting format string calls that were taking
fixed-slice arguments to use a precision specifier in the string format
itself.  From the golang fmt package documentation:

    For strings, byte slices and byte arrays, however, precision limits
    the length of the input to be formatted (not the size of the output),
    truncating if necessary. Normally it is measured in runes, but for
    these types when formatted with the %x or %X format it is measured
    in bytes.

This nicely fits the desired behavior: it will limit the number of
runes considered for string interpolation to the precision value.

Signed-off-by: Chris Telfer &lt;ctelfer@docker.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The previous code used string slices to limit the length of certain
fields like endpoint or sandbox IDs.  This assumes that these strings
are at least as long as the slice length.  Unfortunately, some sandbox
IDs can be smaller than 7 characters.   This fix addresses this issue
by systematically converting format string calls that were taking
fixed-slice arguments to use a precision specifier in the string format
itself.  From the golang fmt package documentation:

    For strings, byte slices and byte arrays, however, precision limits
    the length of the input to be formatted (not the size of the output),
    truncating if necessary. Normally it is measured in runes, but for
    these types when formatted with the %x or %X format it is measured
    in bytes.

This nicely fits the desired behavior: it will limit the number of
runes considered for string interpolation to the precision value.

Signed-off-by: Chris Telfer &lt;ctelfer@docker.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
