<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/docker.git/integration/plugin/common, branch master</title>
<subtitle>github.com: dotcloud/docker.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/'/>
<entry>
<title>Merge pull request #45507 from corhere/cleanup-reexec-inits</title>
<updated>2023-05-10T09:49:11+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>thaJeztah@users.noreply.github.com</email>
</author>
<published>2023-05-10T09:49:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=3f7fde76c2e4e7c234e85c9a8634e2d7639f4f6d'/>
<id>3f7fde76c2e4e7c234e85c9a8634e2d7639f4f6d</id>
<content type='text'>
[chore] clean up reexec.Init() calls</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[chore] clean up reexec.Init() calls</pre>
</div>
</content>
</entry>
<entry>
<title>[chore] clean up reexec.Init() calls</title>
<updated>2023-05-09T23:13:17+00:00</updated>
<author>
<name>Cory Snider</name>
<email>csnider@mirantis.com</email>
</author>
<published>2023-05-09T22:27:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=4e0319c87857f180b01f9b072603cc385d7fcee1'/>
<id>4e0319c87857f180b01f9b072603cc385d7fcee1</id>
<content type='text'>
Now that most uses of reexec have been replaced with non-reexec
solutions, most of the reexec.Init() calls peppered throughout the test
suites are unnecessary. Furthermore, most of the reexec.Init() calls in
test code neglects to check the return value to determine whether to
exit, which would result in the reexec'ed subprocesses proceeding to run
the tests, which would reexec another subprocess which would proceed to
run the tests, recursively. (That would explain why every reexec
callback used to unconditionally call os.Exit() instead of returning...)

Remove unneeded reexec.Init() calls from test and example code which no
longer needs it, and fix the reexec.Init() calls which are not inert to
exit after a reexec callback is invoked.

Signed-off-by: Cory Snider &lt;csnider@mirantis.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now that most uses of reexec have been replaced with non-reexec
solutions, most of the reexec.Init() calls peppered throughout the test
suites are unnecessary. Furthermore, most of the reexec.Init() calls in
test code neglects to check the return value to determine whether to
exit, which would result in the reexec'ed subprocesses proceeding to run
the tests, which would reexec another subprocess which would proceed to
run the tests, recursively. (That would explain why every reexec
callback used to unconditionally call os.Exit() instead of returning...)

Remove unneeded reexec.Init() calls from test and example code which no
longer needs it, and fix the reexec.Init() calls which are not inert to
exit after a reexec callback is invoked.

Signed-off-by: Cory Snider &lt;csnider@mirantis.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fixing consistent aliases for OCI spec imports</title>
<updated>2023-05-08T09:57:52+00:00</updated>
<author>
<name>Jeyanthinath Muthuram</name>
<email>jeyanthinath10@gmail.com</email>
</author>
<published>2023-05-08T09:57:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=307b09e7eb14e48a66752b036fb2a2eb53fa599c'/>
<id>307b09e7eb14e48a66752b036fb2a2eb53fa599c</id>
<content type='text'>
Signed-off-by: Jeyanthinath Muthuram &lt;jeyanthinath10@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jeyanthinath Muthuram &lt;jeyanthinath10@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>integration/plugin: fix duplicate import</title>
<updated>2023-03-14T15:23:09+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2023-03-14T15:23:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=127cd9def1814a4d333c45d36963e171faf4e4c4'/>
<id>127cd9def1814a4d333c45d36963e171faf4e4c4</id>
<content type='text'>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>testutil, integration: use types/registry.AuthConfig</title>
<updated>2022-07-29T21:05:21+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2022-03-03T09:33:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=2b7416ef345a7f483fad677d42028e62ad2268b0'/>
<id>2b7416ef345a7f483fad677d42028e62ad2268b0</id>
<content type='text'>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>api/server/httputils: add ReadJSON() utility</title>
<updated>2022-04-11T19:37:51+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2022-04-05T09:43:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=0c9ff0b45a70061d43655672b2e8227e1b51684f'/>
<id>0c9ff0b45a70061d43655672b2e8227e1b51684f</id>
<content type='text'>
Implement a ReadJSON() utility to help reduce some code-duplication,
and to make sure we handle JSON requests consistently (e.g. always
check for the content-type).

Differences compared to current handling:

- prevent possible panic if request.Body is nil ("should never happen")
- always require Content-Type to be "application/json"
- be stricter about additional content after JSON (previously ignored)
- but, allow the body to be empty (an empty body is not invalid);
  update TestContainerInvalidJSON accordingly, which was testing the
  wrong expectation.
- close body after reading (some code did this)

We should consider to add a "max body size" on this function, similar to
https://github.com/moby/moby/blob/7b9275c0da707b030e62c96b679a976f31f929d3/api/server/middleware/debug.go#L27-L40

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implement a ReadJSON() utility to help reduce some code-duplication,
and to make sure we handle JSON requests consistently (e.g. always
check for the content-type).

Differences compared to current handling:

- prevent possible panic if request.Body is nil ("should never happen")
- always require Content-Type to be "application/json"
- be stricter about additional content after JSON (previously ignored)
- but, allow the body to be empty (an empty body is not invalid);
  update TestContainerInvalidJSON accordingly, which was testing the
  wrong expectation.
- close body after reading (some code did this)

We should consider to add a "max body size" on this function, similar to
https://github.com/moby/moby/blob/7b9275c0da707b030e62c96b679a976f31f929d3/api/server/middleware/debug.go#L27-L40

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vendor: github.com/opencontainers/image-spec v1.0.2</title>
<updated>2021-11-17T23:00:05+00:00</updated>
<author>
<name>Sebastiaan van Stijn</name>
<email>github@gone.nl</email>
</author>
<published>2021-11-17T20:56:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=cef0a7c14efdef430b1e84140bb68dc3e4c4f8e7'/>
<id>cef0a7c14efdef430b1e84140bb68dc3e4c4f8e7</id>
<content type='text'>
- Bring mediaType out of reserved status
- specs-go: adding mediaType to the index and manifest structures

full diff: https://github.com/opencontainers/image-spec/compare/v1.0.1...v1.0.2

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Bring mediaType out of reserved status
- specs-go: adding mediaType to the index and manifest structures

full diff: https://github.com/opencontainers/image-spec/compare/v1.0.1...v1.0.2

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: move from io/ioutil to io and os package</title>
<updated>2021-08-27T06:56:57+00:00</updated>
<author>
<name>Eng Zer Jun</name>
<email>engzerjun@gmail.com</email>
</author>
<published>2021-08-24T10:10:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=c55a4ac7795c7606b548b38e24673733481e2167'/>
<id>c55a4ac7795c7606b548b38e24673733481e2167</id>
<content type='text'>
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.

Signed-off-by: Eng Zer Jun &lt;engzerjun@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.

Signed-off-by: Eng Zer Jun &lt;engzerjun@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>integration: copy loop variable into parallel test closures</title>
<updated>2021-07-22T20:46:12+00:00</updated>
<author>
<name>Roman Volosatovs</name>
<email>roman.volosatovs@docker.com</email>
</author>
<published>2021-07-22T20:41:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=dd01abf9bf73ceab048464b8d5ee1358adfec800'/>
<id>dd01abf9bf73ceab048464b8d5ee1358adfec800</id>
<content type='text'>
Discovered a few instances, where loop variable is incorrectly used
within a test closure, which is marked as parallel.
Few of these were actually loops over singleton slices, therefore the issue
might not have surfaced there (yet), but it is good to fix there as
well, as this is an incorrect pattern used across different tests.

Signed-off-by: Roman Volosatovs &lt;roman.volosatovs@docker.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Discovered a few instances, where loop variable is incorrectly used
within a test closure, which is marked as parallel.
Few of these were actually loops over singleton slices, therefore the issue
might not have surfaced there (yet), but it is good to fix there as
well, as this is an incorrect pattern used across different tests.

Signed-off-by: Roman Volosatovs &lt;roman.volosatovs@docker.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Use docker media type for plugin layers</title>
<updated>2021-04-05T21:46:53+00:00</updated>
<author>
<name>Brian Goff</name>
<email>cpuguy83@gmail.com</email>
</author>
<published>2021-03-26T22:07:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/docker.git/commit/?id=a876ede24f4c6e13717f56897fb34f6c73914602'/>
<id>a876ede24f4c6e13717f56897fb34f6c73914602</id>
<content type='text'>
This was changed as part of a refactor to use containerd dist code. The
problem is the OCI media types are not compatible with older versions of
Docker.

Signed-off-by: Brian Goff &lt;cpuguy83@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was changed as part of a refactor to use containerd dist code. The
problem is the OCI media types are not compatible with older versions of
Docker.

Signed-off-by: Brian Goff &lt;cpuguy83@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
