<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/distcc-git.git/src/sendfile.c, branch python3</title>
<subtitle>github.com: distcc/distcc.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/'/>
<entry>
<title>GNU/Hurd also provides sendfile(2)</title>
<updated>2013-05-27T08:10:22+00:00</updated>
<author>
<name>mandyke</name>
<email>mandyke@gmail.com</email>
</author>
<published>2013-05-27T08:10:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=1fd8ff5036a056d495f7ef03d18efcd68f0560eb'/>
<id>1fd8ff5036a056d495f7ef03d18efcd68f0560eb</id>
<content type='text'>
* src/sendfile.c (sys_sendfile): Expose this function on GNU/Hurd,
  which provides the same interface as Linux.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* src/sendfile.c (sys_sendfile): Expose this function on GNU/Hurd,
  which provides the same interface as Linux.</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for $DISTCC_IO_TIMEOUT.</title>
<updated>2010-02-10T03:31:34+00:00</updated>
<author>
<name>zhanglei</name>
<email>zhanglei@gmail.com</email>
</author>
<published>2010-02-10T03:31:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=6ef4e4177bf19a0a78c1fe3e21538696b4ff720c'/>
<id>6ef4e4177bf19a0a78c1fe3e21538696b4ff720c</id>
<content type='text'>
Reviewed by Fergus Henderson.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reviewed by Fergus Henderson.
</pre>
</div>
</content>
</entry>
<entry>
<title>Normalize the copyright text, to the latest version of the GPLv2 text</title>
<updated>2008-05-23T22:24:20+00:00</updated>
<author>
<name>Craig Silverstein</name>
<email>csilvers@khanacademy.org</email>
</author>
<published>2008-05-23T22:24:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=51f440cfad4a7b861b774dffb0d8e92db09ca84c'/>
<id>51f440cfad4a7b861b774dffb0d8e92db09ca84c</id>
<content type='text'>
(typically the only change is in the FSF street address).  Add Google
copyright line in some places it was missing.  Add GPLv2 notice to
avahi patches.

OKed by fergus
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(typically the only change is in the FSF street address).  Add Google
copyright line in some places it was missing.  Add GPLv2 notice to
avahi patches.

OKed by fergus
</pre>
</div>
</content>
</entry>
<entry>
<title>Change C++-style // comments to /**/.</title>
<updated>2008-05-20T18:16:38+00:00</updated>
<author>
<name>Craig Silverstein</name>
<email>csilvers@khanacademy.org</email>
</author>
<published>2008-05-20T18:16:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=458b09d3c0df853a872a2fb214dfbe2aaf7117f8'/>
<id>458b09d3c0df853a872a2fb214dfbe2aaf7117f8</id>
<content type='text'>
Also, fix the emacs var-setting line: it was missing a semicolon
before, which means the entire line was being ignored.

No contentful change.

Reviewed by fergus@google.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also, fix the emacs var-setting line: it was missing a semicolon
before, which means the entire line was being ignored.

No contentful change.

Reviewed by fergus@google.com
</pre>
</div>
</content>
</entry>
<entry>
<title>Turned all tabs into 4 spaces.  Got rid of whitespace at the end of</title>
<updated>2008-05-20T06:13:28+00:00</updated>
<author>
<name>Craig Silverstein</name>
<email>csilvers@khanacademy.org</email>
</author>
<published>2008-05-20T06:13:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=41b794c77d881e29b260d5fccd14293af499b768'/>
<id>41b794c77d881e29b260d5fccd14293af499b768</id>
<content type='text'>
lines.  Fixed up resulting mis-indented code I noticed (mostly in
files that used 8 space indents, or used 4-space and 8-space indents
in the same file (!)).  Added the emacs tab-var setting for all files,
not just some of them.

I also added in copyright notices for files I noticed that didn't have
them.  We'll want to do another pass-through to fix these up properly,
though.

I used the following perl snippet to check for mis-indented code after
converting tabs to whitespace:

  $ for i in *.{c,h}; do echo $i; perl -nle 'if ($indent &gt; 0) {$sp=" " x $indent; /^$sp[^ ]/ &amp;&amp; print "$.: $_"; $indent=0;}; if (/^( *).*{/ ) {$indent=length($1);} else {$indent=0;}' $i; done | less

It had false positives, but hopefully didn't miss anything.

Reviewed by klarlund@google.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
lines.  Fixed up resulting mis-indented code I noticed (mostly in
files that used 8 space indents, or used 4-space and 8-space indents
in the same file (!)).  Added the emacs tab-var setting for all files,
not just some of them.

I also added in copyright notices for files I noticed that didn't have
them.  We'll want to do another pass-through to fix these up properly,
though.

I used the following perl snippet to check for mis-indented code after
converting tabs to whitespace:

  $ for i in *.{c,h}; do echo $i; perl -nle 'if ($indent &gt; 0) {$sp=" " x $indent; /^$sp[^ ]/ &amp;&amp; print "$.: $_"; $indent=0;}; if (/^( *).*{/ ) {$indent=length($1);} else {$indent=0;}' $i; done | less

It had false positives, but hopefully didn't miss anything.

Reviewed by klarlund@google.com
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a consistent emacs-variable header to all source files.  This</title>
<updated>2008-05-15T02:40:13+00:00</updated>
<author>
<name>Craig Silverstein</name>
<email>csilvers@khanacademy.org</email>
</author>
<published>2008-05-15T02:40:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=b5f25c91c6251fb8320d9d679db9b26516a57aef'/>
<id>b5f25c91c6251fb8320d9d679db9b26516a57aef</id>
<content type='text'>
affects the way emacs users will see these files, when visiting them
in emacs.  In particular, tabs will show up as 4 spaces, which is
(clearly) the setting the original distcc author used when writing the
code.

We also set an emacs variable to never insert new tabs, but use spaces
instead.  This will help stop the problem we have now with mixed tabs
and spaces.  In a future cleanup, we may replace all tabs with 4
spaces, and make other whitespace improvements.

The final new variable set, is to set line-wrapping at 78 chars.
Personally, I would have made it more like 72, but some existing files
already had the 78 limit, so I just do that everywhere, to be
consistent.

Reviewed by fergus@google.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
affects the way emacs users will see these files, when visiting them
in emacs.  In particular, tabs will show up as 4 spaces, which is
(clearly) the setting the original distcc author used when writing the
code.

We also set an emacs variable to never insert new tabs, but use spaces
instead.  This will help stop the problem we have now with mixed tabs
and spaces.  In a future cleanup, we may replace all tabs with 4
spaces, and make other whitespace improvements.

The final new variable set, is to set line-wrapping at 78 chars.
Personally, I would have made it more like 72, but some existing files
already had the 78 limit, so I just do that everywhere, to be
consistent.

Reviewed by fergus@google.com
</pre>
</div>
</content>
</entry>
<entry>
<title>No matter what the reason, if we can't use sendfile() but it's still</title>
<updated>2008-05-10T06:54:58+00:00</updated>
<author>
<name>Craig Silverstein</name>
<email>csilvers@khanacademy.org</email>
</author>
<published>2008-05-10T06:54:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=e4bd4105953587faecb142d27e2818f772eb94ff'/>
<id>e4bd4105953587faecb142d27e2818f772eb94ff</id>
<content type='text'>
safe to fall back on readwrite(), do that.  Before we only did this
for certain errors, but we might as well do it for any error we don't
expect to be able to recover from.

Tested by running on mac os x 10.4, which has a problem with sendfile
failing sometimes.  The relevant test succeeds after this patch.

Reviewed by fergus@google.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
safe to fall back on readwrite(), do that.  Before we only did this
for certain errors, but we might as well do it for any error we don't
expect to be able to recover from.

Tested by running on mac os x 10.4, which has a problem with sendfile
failing sometimes.  The relevant test succeeds after this patch.

Reviewed by fergus@google.com
</pre>
</div>
</content>
</entry>
<entry>
<title>Make handling of config.h sound.</title>
<updated>2008-05-09T18:15:18+00:00</updated>
<author>
<name>klarlund</name>
<email>klarlund@gmail.com</email>
</author>
<published>2008-05-09T18:15:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=a31b5d6a22150bc54c93166910ba9f351081c659'/>
<id>a31b5d6a22150bc54c93166910ba9f351081c659</id>
<content type='text'>
(1) Correct order of -Is in Makefile.

(2) remove unnessary PATH modification in configure.ac (this is fergus's
suggestion -- hopefully this will do, this replaces a circumvention mechanism I
had originally concocted.

(3) Fix place of the include of popt in CPPFLAGS.

(4) Convert quoted includes of config.h to angle bracket includes so that the
build version, not the source version, of this file is picked up.

The order of -Is in the build system is wrong: it contradicts the
VPATH mechanism.  

This means that builds in a build directory different from that
of the source (distribution) directory will find wrong files even
after the hapless developer has issued only a 'configure' command
in the source directory (but not actually 'made' any thing
there).  For in that case, the src/config.h will be generated in
the source directory and this will be the file picked in the
build directory even if that directory has it's own src/config.h.
This can lead to wrong builds and it can be hard to diagnose the
problem.

Currently, this what CPPFLAGS end up being (as found in the
generated Makefile):

  CPPFLAGS =  -DHAVE_CONFIG_H -D_GNU_SOURCE \
              -I../distcc/popt -I../distcc/src \
              ${DIR_DEFS} \
              -Isrc -Ilzo \
              -I"$(srcdir)/src" -I"$(srcdir)/lzo" \

Here my source dir was ../distcc.  

The presence of '-I../distcc/popt' in front of -Isrc is the exact
opposite of the semantics of VPATH mechanism, which looks for
files in the build directory, then in the source directory.  

Also, note the remarks in:

  http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers

(they do not quite correctly discuss the search path, btw).

TESTING: I verified that with a corrupted config.h file in the source directory,
building now succeeds.

Also: make distcheck (it fails the same place as before: this is corrected in
another change of mine --- I'll verify that with that change in place, this
change makes 'make distcheck' succeed.)

REVIEWERS: fergus@google.com, csilvers@google.com

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(1) Correct order of -Is in Makefile.

(2) remove unnessary PATH modification in configure.ac (this is fergus's
suggestion -- hopefully this will do, this replaces a circumvention mechanism I
had originally concocted.

(3) Fix place of the include of popt in CPPFLAGS.

(4) Convert quoted includes of config.h to angle bracket includes so that the
build version, not the source version, of this file is picked up.

The order of -Is in the build system is wrong: it contradicts the
VPATH mechanism.  

This means that builds in a build directory different from that
of the source (distribution) directory will find wrong files even
after the hapless developer has issued only a 'configure' command
in the source directory (but not actually 'made' any thing
there).  For in that case, the src/config.h will be generated in
the source directory and this will be the file picked in the
build directory even if that directory has it's own src/config.h.
This can lead to wrong builds and it can be hard to diagnose the
problem.

Currently, this what CPPFLAGS end up being (as found in the
generated Makefile):

  CPPFLAGS =  -DHAVE_CONFIG_H -D_GNU_SOURCE \
              -I../distcc/popt -I../distcc/src \
              ${DIR_DEFS} \
              -Isrc -Ilzo \
              -I"$(srcdir)/src" -I"$(srcdir)/lzo" \

Here my source dir was ../distcc.  

The presence of '-I../distcc/popt' in front of -Isrc is the exact
opposite of the semantics of VPATH mechanism, which looks for
files in the build directory, then in the source directory.  

Also, note the remarks in:

  http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers

(they do not quite correctly discuss the search path, btw).

TESTING: I verified that with a corrupted config.h file in the source directory,
building now succeeds.

Also: make distcheck (it fails the same place as before: this is corrected in
another change of mine --- I'll verify that with that change in place, this
change makes 'make distcheck' succeed.)

REVIEWERS: fergus@google.com, csilvers@google.com

</pre>
</div>
</content>
</entry>
<entry>
<title>Treat ENOTSOCK errors from sendfile() the same way that we treat</title>
<updated>2008-05-02T18:49:44+00:00</updated>
<author>
<name>fergus.henderson</name>
<email>fergushenderson@users.noreply.github.com</email>
</author>
<published>2008-05-02T18:49:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=cefa185bb869ee01816d8bf5b2b78f420c2f5668'/>
<id>cefa185bb869ee01816d8bf5b2b78f420c2f5668</id>
<content type='text'>
ENONSYS and EINVAL errors: fall back to using read() and write().
This fixes the failure of SyntaxError_Case and MissingCompiler_Case
on FreeBSD.

Tested by "make check".

Reviewers: Craig Silverstein

</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ENONSYS and EINVAL errors: fall back to using read() and write().
This fixes the failure of SyntaxError_Case and MissingCompiler_Case
on FreeBSD.

Tested by "make check".

Reviewers: Craig Silverstein

</pre>
</div>
</content>
</entry>
<entry>
<title>OS X added sendfile support in 10.5, so add this case to sendfile.c.</title>
<updated>2008-04-28T21:52:34+00:00</updated>
<author>
<name>Craig Silverstein</name>
<email>csilvers@khanacademy.org</email>
</author>
<published>2008-04-28T21:52:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/distcc-git.git/commit/?id=77c2239dcbb8b811ce7649ec51109997acd776f4'/>
<id>77c2239dcbb8b811ce7649ec51109997acd776f4</id>
<content type='text'>
Looking at the man pages, it looks like os x sendfile is pretty much
the same as BSD's, so I copied much of the code from the existing BSD
case.

Tested by ensuring the code compiles and links on os x 10.5.  No
attempt to see if it runs correctly, though.

Reviewed by fergus@google.com
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Looking at the man pages, it looks like os x sendfile is pretty much
the same as BSD's, so I copied much of the code from the existing BSD
case.

Tested by ensuring the code compiles and links on os x 10.5.  No
attempt to see if it runs correctly, though.

Reviewed by fergus@google.com
</pre>
</div>
</content>
</entry>
</feed>
