to do a better job of error checking.

       * src/emaillog.c (dcc_maybe_send_email): Pacify GCC's warnings
       about format strings by getting rid of a useless temporary
       string.

This will hopefully fix issue 39 <http://code.google.com/p/distcc/issues/detail?id=39>.
Some header files were using #if statements that depended on macros defined in config.h
without #including config.h first.  The result was a compilation error, because
"#if !HAVE_DECL_SNPRINTF" was evaluating to true because config.h hadn't been included,
causing us to declare snprintf() when we shouldn't, leading to a conflict with the
declaration in the standard header files.

(The alternative solution would have been to add "#include <config.h>"
to every header file that uses '#if'.  I decided not to do that, just
for consistency with the existing code.)

by fergus.

(typically the only change is in the FSF street address).  Add Google
copyright line in some places it was missing.  Add GPLv2 notice to
avahi patches.

OKed by fergus

Also, fix the emacs var-setting line: it was missing a semicolon
before, which means the entire line was being ignored.

No contentful change.

Reviewed by fergus@google.com

lines.  Fixed up resulting mis-indented code I noticed (mostly in
files that used 8 space indents, or used 4-space and 8-space indents
in the same file (!)).  Added the emacs tab-var setting for all files,
not just some of them.

I also added in copyright notices for files I noticed that didn't have
them.  We'll want to do another pass-through to fix these up properly,
though.

I used the following perl snippet to check for mis-indented code after
converting tabs to whitespace:

  $ for i in *.{c,h}; do echo $i; perl -nle 'if ($indent > 0) {$sp=" " x $indent; /^$sp[^ ]/ && print "$.: $_"; $indent=0;}; if (/^( *).*{/ ) {$indent=length($1);} else {$indent=0;}' $i; done | less

It had false positives, but hopefully didn't miss anything.

Reviewed by klarlund@google.com

Reviewers: fergus@google.com
Tests: manual (both with and without DISTCC_EMAILLOG_WHOM_TO_BLAME set).

the unittests to pass, on FreeBSD 6.0, Solaris 10 x86, and OS X
Leopard.  You have to use gmake instead of standard bsd make, though,
because neither bsd nor solari make understand 'include */*.d' and
'CFLAGS += $(POPT_FLAGS).'  These may be fixable later.

Most changes fall into four categories:
1) #include differences
2) New errors due to some #ifdef paths being taken differently
3) Undefined functions (see, eg, the new HAVE_STRSEP)
4) Type differences (eg tv_usec is an int on os x, not a long int)

As one concrete example, snprintf.c is an empty file on linux, where
all the functionality is part of glibc.  But on Solaris, some of its
functionality is useful.  This turned up a bug where if you have
vsnprintf on your system but not vasnprintf, then dopr() was not being
used but was being defined, leading to an "unused static function"
warning in gcc.

As another, solaris would complain about "index" being used as a
variable, since it's also a function name.  The var was renamed idx.

Tested by compiling on FreeBSD, Solaris 10, and OS X leopard (x86).  I
also compiled and ran unittests under Linux Ubuntu, to make sure
this change didn't break anything there.

Reviewed by fergus@google.com

level.  I'm doing this in two stages, because I don't understand svn
enough to be confident to do it in one.  This first stage just copies
all the files from distcc/FOO to FOO.  Now there are two copies of
each file under distcc; the Makefile/etc uses the one in distcc and
ignores the one at the top level.

The next commit will delete everything under distcc, and rewrite the
Makefile/etc to use the top-level versions instead.