Reviewed by Craig Silverstein.

to do a better job of error checking.

This will hopefully fix issue 39 <http://code.google.com/p/distcc/issues/detail?id=39>.
Some header files were using #if statements that depended on macros defined in config.h
without #including config.h first.  The result was a compilation error, because
"#if !HAVE_DECL_SNPRINTF" was evaluating to true because config.h hadn't been included,
causing us to declare snprintf() when we shouldn't, leading to a conflict with the
declaration in the standard header files.

(The alternative solution would have been to add "#include <config.h>"
to every header file that uses '#if'.  I decided not to do that, just
for consistency with the existing code.)

Some more bug fixes to make the test case pass.

Also, make the DashWpMD_Case test a bit more strict: disable
fallbacks, so that it tests that we can distribute such jobs.

by fergus.

(typically the only change is in the FSF street address).  Add Google
copyright line in some places it was missing.  Add GPLv2 notice to
avahi patches.

OKed by fergus

Also, fix the emacs var-setting line: it was missing a semicolon
before, which means the entire line was being ignored.

No contentful change.

Reviewed by fergus@google.com

lines.  Fixed up resulting mis-indented code I noticed (mostly in
files that used 8 space indents, or used 4-space and 8-space indents
in the same file (!)).  Added the emacs tab-var setting for all files,
not just some of them.

I also added in copyright notices for files I noticed that didn't have
them.  We'll want to do another pass-through to fix these up properly,
though.

I used the following perl snippet to check for mis-indented code after
converting tabs to whitespace:

  $ for i in *.{c,h}; do echo $i; perl -nle 'if ($indent > 0) {$sp=" " x $indent; /^$sp[^ ]/ && print "$.: $_"; $indent=0;}; if (/^( *).*{/ ) {$indent=length($1);} else {$indent=0;}' $i; done | less

It had false positives, but hopefully didn't miss anything.

Reviewed by klarlund@google.com

to str_startswith() were in the wrong order, and in one place I had
wrongly passed 'argv' instead of 'new_argv'.

Move the call to dcc_expand_preprocessor_options() from
dcc_get_dotd_info() to gcc_build_somewhere(), so that it is pretty
much the first thing done to argv.  Not sure if this is really needed,
but it seems like a good idea.

Fix various memory management problems, including some introduced by
moving the call to dcc_expand_preprocessor_options().  One problem
was that dcc_find_compiler() was producing a result that was sometimes
allocated with malloc() and sometimes not, so the caller couldn't
safely deallocate it.  I changed dcc_find_compiler to always return
a dynamically allocated result.

Fix some places where return values were being ignored.
Also fix one place where distcc was inconsistenly calling exit()
rather than returning a return code.

Like my previous change, this one is necessary, but perhaps not
sufficient, for building the Linux kernel with distcc-pump.

Tested by "make valgrind-check", and by building and installing the
debian package and the building Linux 2.6.25 in pump mode using the
benchmark.py script.

Reviewers