From aa427663405284853f42923fb272e195b7b4c3ac Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Fri, 17 Aug 2018 15:42:17 +0100 Subject: activation: Don't leak if delivering activation message is forbidden This is technically a denial of service because the dbus-daemon will run out of memory eventually, but it's a very slow and noisy one, because all the rejected messages are also very likely to have been logged to the system log. Detected by AddressSanitizer. Signed-off-by: Simon McVittie Resolves: https://gitlab.freedesktop.org/dbus/dbus/issues/234 Reviewed-by: pwithnall --- bus/activation.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bus/activation.c b/bus/activation.c index 6f009f5c..99404b92 100644 --- a/bus/activation.c +++ b/bus/activation.c @@ -1267,6 +1267,7 @@ bus_activation_send_pending_auto_activation_messages (BusActivation *activation entry->activation_message); } + dbus_error_free (&error); link = next; continue; } -- cgit v1.2.1