From b863c22f6ad4a367cf8526b4fd3b1b265ab70842 Mon Sep 17 00:00:00 2001 From: Jacek Bukarewicz Date: Wed, 17 Jun 2015 18:53:41 +0100 Subject: Fix memleak in GetConnectionCredentials handler Reply message was not unreferenced when GetConnectionCredentials handler was successful. Signed-off-by: Jacek Bukarewicz [smcv: changed bus_message_unref() to dbus_message_unref()] Reviewed-by: Simon McVittie Bug: https://bugs.freedesktop.org/show_bug.cgi?id=91008 --- bus/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bus/driver.c b/bus/driver.c index f5d3ebe2..888c7ca7 100644 --- a/bus/driver.c +++ b/bus/driver.c @@ -1613,6 +1613,8 @@ bus_driver_handle_get_connection_credentials (DBusConnection *connection, goto oom; } + dbus_message_unref (reply); + return TRUE; oom: -- cgit v1.2.1 From 1b892db6ddb25ecb68c92c96a5fa74644c9d71b9 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Wed, 17 Jun 2015 20:40:51 +0100 Subject: NEWS --- NEWS | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e21f0824..9749a340 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,10 @@ D-Bus 1.8.20 (UNRELEASED) == -... +Fixes: + +• Fix a memory leak when GetConnectionCredentials() succeeds + (fd.o #91008, Jacek Bukarewicz) D-Bus 1.8.18 (2015-05-14) == -- cgit v1.2.1