From 4a0867a8fc2db6a23dba68667d0e6010e3082fe8 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 23 Aug 2018 09:01:03 +0100 Subject: Do not apply __attribute__((__malloc__)) to dbus_realloc() As noted in GLib commit c879f50f, gcc's interpretation of the malloc attribute has become more strict over time, which could result in miscompilation. The new definition is that in addition to assuming that the returned memory block is newly-allocated, gcc now assumes that it does not contain any valid pointers. This is OK for uninitialized or zero-initialized memory returned by dbus_malloc() or dbus_malloc0(), but not valid for dbus_realloc(), which might be used for a dynamically-sized array of (structures containing) valid pointers. See https://gitlab.gnome.org/GNOME/glib/issues/1465 Signed-off-by: Simon McVittie Reviewed-by: Philip Withnall Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107741 --- dbus/dbus-memory.h | 1 - 1 file changed, 1 deletion(-) diff --git a/dbus/dbus-memory.h b/dbus/dbus-memory.h index 4fd56bd6..c575b46f 100644 --- a/dbus/dbus-memory.h +++ b/dbus/dbus-memory.h @@ -48,7 +48,6 @@ DBUS_ALLOC_SIZE(1) void* dbus_malloc0 (size_t bytes); DBUS_EXPORT -DBUS_MALLOC DBUS_ALLOC_SIZE(2) void* dbus_realloc (void *memory, size_t bytes); -- cgit v1.2.1