From e8e656c845c9b1fe4480ecc02aedb2110fb8dd59 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 26 Aug 2021 07:43:34 +0200 Subject: curl: better error message when -O fails to get a good name Due to how this currently works internally, it needs a working initial file name to store contents in, so it may still fail even with -J is used (and thus accepting a name from content-disposition:) if the file name part of the URL isn't "good enough". Fixes #7628 Closes #7635 --- src/tool_operate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tool_operate.c b/src/tool_operate.c index 74221599d..960f3020a 100644 --- a/src/tool_operate.c +++ b/src/tool_operate.c @@ -950,8 +950,11 @@ static CURLcode single_transfer(struct GlobalConfig *global, if(!per->outfile) { /* extract the file name from the URL */ result = get_url_file_name(&per->outfile, per->this_url); - if(result) + if(result) { + errorf(global, "Failed to extract a sensible file name" + " from the URL to use for storage!\n"); break; + } if(!*per->outfile && !config->content_disposition) { errorf(global, "Remote file name has no length!\n"); result = CURLE_WRITE_ERROR; -- cgit v1.2.1