From 60e3d1f2102f226e2f1514f4f3d4c31b2022f957 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Mon, 5 Nov 2018 09:51:33 +0100 Subject: unittest: make 1652 stable across collations The previous coding used a format string whose output depended on the current locale of the environment running the test. Since the gist of the test is to have a format string, with the actual formatting being less important, switch to a more stable formatstring with decimals. Reported-by: Marcel Raad Closes #3234 Reviewed-by: Daniel Stenberg Reviewed-by: Marcel Raad --- tests/unit/unit1652.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/unit1652.c b/tests/unit/unit1652.c index 923c870f0..496ab3cb2 100644 --- a/tests/unit/unit1652.c +++ b/tests/unit/unit1652.c @@ -85,8 +85,8 @@ Curl_infof(data, "%s", input); fail_unless(strcmp(result, input) == 0, "Simple string test"); /* Injecting a few different variables with a format */ -Curl_infof(data, "%s %u testing %.1f\n", input, 42, 43.0123324); -fail_unless(strcmp(result, "Simple Test 42 testing 43.0\n") == 0, +Curl_infof(data, "%s %u testing %lu\n", input, 42, 43L); +fail_unless(strcmp(result, "Simple Test 42 testing 43\n") == 0, "Format string"); /* Variations of empty strings */ -- cgit v1.2.1