delta/curl.git/tests/unit, branch bagder/https-cookie-secure github.com: bagder/curl.git printf: fix format specifiers 2019-01-04T22:50:48+00:00 Rikard Falkeborn rikard.falkeborn@gmail.com 2018-09-16T20:04:49+00:00 fa2d6ba84d7f87148738f3cbccf29016dd324f87 Closes #3426 
Closes #3426
urlapi: fix parsing ipv6 with zone index 2018-12-30T19:11:57+00:00 Daniel Gustafsson daniel@yesql.se 2018-12-30T19:11:57+00:00 a4482b21bd8bb0ac7cfb3471bad32bf84f829805 The previous fix for parsing IPv6 URLs with a zone index was a paddle short for URLs without an explicit port. This patch fixes that case and adds a unit test case. This bug was highlighted by issue #3408, and while it's not the full fix for the problem there it is an isolated bug that should be fixed regardless. Closes #3411 Reported-by: GitYuanQu on github Reviewed-by: Daniel Stenberg <daniel@haxx.se> 
The previous fix for parsing IPv6 URLs with a zone index was a paddle
short for URLs without an explicit port. This patch fixes that case
and adds a unit test case.

This bug was highlighted by issue #3408, and while it's not the full
fix for the problem there it is an isolated bug that should be fixed
regardless.

Closes #3411
Reported-by: GitYuanQu on github
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
urlapi: Fix port parsing of eol colon 2018-12-12T10:48:04+00:00 Daniel Gustafsson daniel@yesql.se 2018-12-12T10:45:09+00:00 d8607da1a68f2482302ccdbb7cf457210b9ccfc9 A URL with a single colon without a portnumber should use the default port, discarding the colon. Fix, add a testcase and also do little bit of comment wordsmithing. Closes #3365 Reviewed-by: Daniel Stenberg <daniel@haxx.se> 
A URL with a single colon without a portnumber should use the default
port, discarding the colon. Fix, add a testcase and also do little bit
of comment wordsmithing.

Closes #3365
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
tests: add urlapi unittest 2018-12-11T14:02:24+00:00 Daniel Gustafsson daniel@yesql.se 2018-12-11T14:02:24+00:00 e1be2ecba485e49c740286b7bc431592507aa8f0 This adds a new unittest intended to cover the internal functions in the urlapi code, starting with parse_port(). In order to avoid name collisions in debug builds, parse_port() is renamed Curl_parse_port() since it will be exported. Reviewed-by: Daniel Stenberg <daniel@haxx.se> Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com> 
This adds a new unittest intended to cover the internal functions in
the urlapi code, starting with parse_port(). In order to avoid name
collisions in debug builds, parse_port() is renamed Curl_parse_port()
since it will be exported.

Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
snprintf: renamed and we now only use msnprintf() 2018-11-23T07:26:51+00:00 Daniel Stenberg daniel@haxx.se 2018-11-22T08:01:24+00:00 dcd6f810255785d52b89150e18460fb0899d4f7e The function does not return the same value as snprintf() normally does, so readers may be mislead into thinking the code works differently than it actually does. A different function name makes this easier to detect. Reported-by: Tomas Hoger Assisted-by: Daniel Gustafsson Fixes #3296 Closes #3297 
The function does not return the same value as snprintf() normally does,
so readers may be mislead into thinking the code works differently than
it actually does. A different function name makes this easier to detect.

Reported-by: Tomas Hoger
Assisted-by: Daniel Gustafsson
Fixes #3296
Closes #3297
netrc: don't ignore the login name specified with "--user" 2018-11-05T19:34:01+00:00 Michael Kaufmann mail@michael-kaufmann.ch 2018-11-03T15:58:18+00:00 53db15ba5524584196eedb3abe8d2e97fb5a3cc0 - for "--netrc", don't ignore the login/password specified with "--user", only ignore the login/password in the URL. This restores the netrc behaviour of curl 7.61.1 and earlier. - fix the documentation of CURL_NETRC_REQUIRED - improve the detection of login/password changes when reading .netrc - don't read .netrc if both login and password are already set Fixes #3213 Closes #3224 
- for "--netrc", don't ignore the login/password specified with "--user",
  only ignore the login/password in the URL.
  This restores the netrc behaviour of curl 7.61.1 and earlier.
- fix the documentation of CURL_NETRC_REQUIRED
- improve the detection of login/password changes when reading .netrc
- don't read .netrc if both login and password are already set

Fixes #3213
Closes #3224
unittest: make 1652 stable across collations 2018-11-05T08:51:33+00:00 Daniel Gustafsson daniel@yesql.se 2018-11-05T08:51:33+00:00 60e3d1f2102f226e2f1514f4f3d4c31b2022f957 The previous coding used a format string whose output depended on the current locale of the environment running the test. Since the gist of the test is to have a format string, with the actual formatting being less important, switch to a more stable formatstring with decimals. Reported-by: Marcel Raad Closes #3234 Reviewed-by: Daniel Stenberg <daniel@haxx.se> Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com> 
The previous coding used a format string whose output depended on the
current locale of the environment running the test. Since the gist of
the test is to have a format string, with the actual formatting being
less important, switch to a more stable formatstring with decimals.

Reported-by: Marcel Raad
Closes #3234
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
infof: clearly indicate truncation 2018-11-03T19:54:18+00:00 Daniel Gustafsson daniel@yesql.se 2018-11-03T19:54:18+00:00 c37b66aaaed0a36bcb1b19596e897d7ac6219611 The internal buffer in infof() is limited to 2048 bytes of payload plus an additional byte for NULL termination. Servers with very long error messages can however cause truncation of the string, which currently isn't very clear, and leads to badly formatted output. This appends a "...\n" (or just "..." in case the format didn't with a newline char) marker to the end of the string to clearly show that it has been truncated. Also include a unittest covering infof() to try and catch any bugs introduced in this quite important function. Closes #3216 Reviewed-by: Daniel Stenberg <daniel@haxx.se> Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com> 
The internal buffer in infof() is limited to 2048 bytes of payload plus
an additional byte for NULL termination. Servers with very long error
messages can however cause truncation of the string, which currently
isn't very clear, and leads to badly formatted output.

This appends a "...\n" (or just "..." in case the format didn't with a
newline char) marker to the end of the string to clearly show
that it has been truncated.

Also include a unittest covering infof() to try and catch any bugs
introduced in this quite important function.

Closes #3216
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
axtls: removed 2018-11-01T09:29:53+00:00 Daniel Stenberg daniel@haxx.se 2018-10-30T09:00:00+00:00 302d125b42ed39580fad65ad87fa376ddeaba305 As has been outlined in the DEPRECATE.md document, the axTLS code has been disabled for 6 months and is hereby removed. Use a better supported TLS library! Assisted-by: Daniel Gustafsson Closes #3194 
As has been outlined in the DEPRECATE.md document, the axTLS code has
been disabled for 6 months and is hereby removed.

Use a better supported TLS library!

Assisted-by: Daniel Gustafsson
Closes #3194
unit1650: fix "null pointer passed as argument 1 to memcmp" 2018-10-29T15:14:40+00:00 Daniel Stenberg daniel@haxx.se 2018-10-29T09:27:04+00:00 5728229a4fd209421fdd324dab5fd445d5917508 Detected by UndefinedBehaviorSanitizer Closes #3187 
Detected by UndefinedBehaviorSanitizer

Closes #3187