<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/curl.git/tests/unit/unit1652.c, branch bagder/https-proxy-tests</title>
<subtitle>github.com: bagder/curl.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/'/>
<entry>
<title>snprintf: renamed and we now only use msnprintf()</title>
<updated>2018-11-23T07:26:51+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-11-22T08:01:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=dcd6f810255785d52b89150e18460fb0899d4f7e'/>
<id>dcd6f810255785d52b89150e18460fb0899d4f7e</id>
<content type='text'>
The function does not return the same value as snprintf() normally does,
so readers may be mislead into thinking the code works differently than
it actually does. A different function name makes this easier to detect.

Reported-by: Tomas Hoger
Assisted-by: Daniel Gustafsson
Fixes #3296
Closes #3297
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function does not return the same value as snprintf() normally does,
so readers may be mislead into thinking the code works differently than
it actually does. A different function name makes this easier to detect.

Reported-by: Tomas Hoger
Assisted-by: Daniel Gustafsson
Fixes #3296
Closes #3297
</pre>
</div>
</content>
</entry>
<entry>
<title>unittest: make 1652 stable across collations</title>
<updated>2018-11-05T08:51:33+00:00</updated>
<author>
<name>Daniel Gustafsson</name>
<email>daniel@yesql.se</email>
</author>
<published>2018-11-05T08:51:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=60e3d1f2102f226e2f1514f4f3d4c31b2022f957'/>
<id>60e3d1f2102f226e2f1514f4f3d4c31b2022f957</id>
<content type='text'>
The previous coding used a format string whose output depended on the
current locale of the environment running the test. Since the gist of
the test is to have a format string, with the actual formatting being
less important, switch to a more stable formatstring with decimals.

Reported-by: Marcel Raad
Closes #3234
Reviewed-by: Daniel Stenberg &lt;daniel@haxx.se&gt;
Reviewed-by: Marcel Raad &lt;Marcel.Raad@teamviewer.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The previous coding used a format string whose output depended on the
current locale of the environment running the test. Since the gist of
the test is to have a format string, with the actual formatting being
less important, switch to a more stable formatstring with decimals.

Reported-by: Marcel Raad
Closes #3234
Reviewed-by: Daniel Stenberg &lt;daniel@haxx.se&gt;
Reviewed-by: Marcel Raad &lt;Marcel.Raad@teamviewer.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>infof: clearly indicate truncation</title>
<updated>2018-11-03T19:54:18+00:00</updated>
<author>
<name>Daniel Gustafsson</name>
<email>daniel@yesql.se</email>
</author>
<published>2018-11-03T19:54:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=c37b66aaaed0a36bcb1b19596e897d7ac6219611'/>
<id>c37b66aaaed0a36bcb1b19596e897d7ac6219611</id>
<content type='text'>
The internal buffer in infof() is limited to 2048 bytes of payload plus
an additional byte for NULL termination. Servers with very long error
messages can however cause truncation of the string, which currently
isn't very clear, and leads to badly formatted output.

This appends a "...\n" (or just "..." in case the format didn't with a
newline char) marker to the end of the string to clearly show
that it has been truncated.

Also include a unittest covering infof() to try and catch any bugs
introduced in this quite important function.

Closes #3216
Reviewed-by: Daniel Stenberg &lt;daniel@haxx.se&gt;
Reviewed-by: Marcel Raad &lt;Marcel.Raad@teamviewer.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The internal buffer in infof() is limited to 2048 bytes of payload plus
an additional byte for NULL termination. Servers with very long error
messages can however cause truncation of the string, which currently
isn't very clear, and leads to badly formatted output.

This appends a "...\n" (or just "..." in case the format didn't with a
newline char) marker to the end of the string to clearly show
that it has been truncated.

Also include a unittest covering infof() to try and catch any bugs
introduced in this quite important function.

Closes #3216
Reviewed-by: Daniel Stenberg &lt;daniel@haxx.se&gt;
Reviewed-by: Marcel Raad &lt;Marcel.Raad@teamviewer.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
