delta/curl.git/lib/vssh, branch bagder/test493-https github.com: bagder/curl.git libssh: fix "empty expression statement has no effect" warnings 2021-04-19T06:30:04+00:00 Daniel Stenberg daniel@haxx.se 2021-04-17T17:00:15+00:00 2426fa49ea30323d01db3ecff42c6d2c929943e4 ... by fixing macros to do-while constructs and moving out the calls to "break" outside of the actual macro. It also fixes the problem where the macro was used witin a loop and the break didn't do right. Reported-by: Emil Engler Fixes #6847 Closes #6909 
... by fixing macros to do-while constructs and moving out the calls to
"break" outside of the actual macro. It also fixes the problem where the
macro was used witin a loop and the break didn't do right.

Reported-by: Emil Engler
Fixes #6847
Closes #6909
libssh2: fix Value stored to 'sshp' is never read 2021-04-15T20:43:35+00:00 Daniel Stenberg daniel@haxx.se 2021-04-15T15:46:24+00:00 b532d35b5c97a2900f8511f3ecbf45c9342cfcba Pointed out by scan-build Closes #6900 
Pointed out by scan-build

Closes #6900
libssh: get rid of PATH_MAX 2021-04-06T03:21:19+00:00 Emil Engler me@emilengler.com 2021-04-01T16:24:53+00:00 c1abc6624d8fb1bd2286feeb8b623dd4850fadbe This removes the last occurrence of PATH_MAX inside our libssh implementation by calculating the path length from the string length of the two components. Closes #6829 
This removes the last occurrence of PATH_MAX inside our libssh
implementation by calculating the path length from the string length of
the two components.

Closes #6829
libssh2: kdb_callback: get the right struct pointer 2021-03-23T12:42:22+00:00 Daniel Stenberg daniel@haxx.se 2021-03-23T10:17:32+00:00 1803be5746aeff88cdd5a9f4a205917d9b15b964 After the recent conn/data refactor in this source file, this function was mistakenly still getting the old struct pointer which would lead to crash on servers with keyboard-interactive auth enabled. Follow-up to a304051620b92e12b (shipped in 7.75.0) Reported-by: Christian Schmitz Fixes #6691 Closes #6782 
After the recent conn/data refactor in this source file, this function
was mistakenly still getting the old struct pointer which would lead to
crash on servers with keyboard-interactive auth enabled.

Follow-up to a304051620b92e12b (shipped in 7.75.0)

Reported-by: Christian Schmitz
Fixes #6691
Closes #6782
libssh2:ssh_connect: clear session pointer after free 2021-03-21T10:22:08+00:00 Daniel Stenberg daniel@haxx.se 2021-03-20T23:10:04+00:00 012c19c33a57bd821aa433b488deaf7f30e7bb44 If libssh2_knownhost_init() returns NULL, like in an OOM situation, the ssh session was freed but the pointer wasn't cleared which made libcurl later call libssh2 to cleanup using the stale pointer. Fixes #6764 Closes #6766 
If libssh2_knownhost_init() returns NULL, like in an OOM situation, the
ssh session was freed but the pointer wasn't cleared which made libcurl
later call libssh2 to cleanup using the stale pointer.

Fixes #6764
Closes #6766
ftp: add 'list_only' to the transfer state struct 2021-02-09T13:06:28+00:00 Daniel Stenberg daniel@haxx.se 2021-02-08T15:40:34+00:00 528f71c2ecdbb03117af226978804148d69a1007 and rename it from 'ftp_list_only' since it is also used for SSH and POP3. The state is updated internally for 'type=D' FTP URLs. Added test case 1570 to verify. Closes #6578 
and rename it from 'ftp_list_only' since it is also used for SSH and
POP3. The state is updated internally for 'type=D' FTP URLs.

Added test case 1570 to verify.

Closes #6578
ftp: never set data->set.ftp_append outside setopt 2021-02-08T21:44:37+00:00 Daniel Stenberg daniel@haxx.se 2021-02-08T15:21:31+00:00 0c51036eb6ddef50a1730bdd33a4388b35343125 Since the set value then risks getting used like that when the easy handle is reused by the application. Also: renamed the struct field from 'ftp_append' to 'remote_append' since it is also used for SSH protocols. Closes #6579 
Since the set value then risks getting used like that when the easy
handle is reused by the application.

Also: renamed the struct field from 'ftp_append' to 'remote_append'
since it is also used for SSH protocols.

Closes #6579
libssh2: fix CURL_LIBSSH2_DEBUG-enabled build 2021-01-27T10:43:21+00:00 Daniel Stenberg daniel@haxx.se 2021-01-27T10:43:21+00:00 957180219023909e4cdfb7e4b6d92a5e0b390c8f Follow-up to 2dcc940959772a Reported-by: Gisle Vanem Bug: https://github.com/curl/curl/commit/2dcc940959772a652f6813fb6bd3092095a4877b#commitcomment-46420088 
Follow-up to 2dcc940959772a

Reported-by: Gisle Vanem
Bug: https://github.com/curl/curl/commit/2dcc940959772a652f6813fb6bd3092095a4877b#commitcomment-46420088
libssh2: move data from connection object to transfer object 2021-01-25T16:07:57+00:00 Daniel Stenberg daniel@haxx.se 2021-01-25T09:44:30+00:00 2dcc940959772a652f6813fb6bd3092095a4877b Readdir data, filenames and attributes are strictly related to the transfer and not the connection. This also reduces the total size of the fixed connectdata struct. Closes #6519 
Readdir data, filenames and attributes are strictly related to the
transfer and not the connection. This also reduces the total size of the
fixed connectdata struct.

Closes #6519
wolfssh: remove conn->data references 2021-01-21T15:43:51+00:00 Daniel Stenberg daniel@haxx.se 2021-01-21T12:46:59+00:00 5a19cb5a3c1b0345306bb3738a0cdf43ea72852b ... and repair recent build breakage Closes #6507 
... and repair recent build breakage

Closes #6507