delta/curl.git/lib/vauth/spnego_gssapi.c, branch bagder/https-proxy-tests github.com: bagder/curl.git vauth: return CURLE_AUTH_ERROR on gss_init_sec_context() failure 2019-08-26T11:43:21+00:00 Kamil Dudka kdudka@redhat.com 2019-08-14T07:47:17+00:00 7e513c1048fc506885ded033a37151309cc71af7 This is a follow-up to https://github.com/curl/curl/pull/3864 . Closes #4224 
This is a follow-up to https://github.com/curl/curl/pull/3864 .

Closes #4224
vauth: Use CURLE_AUTH_ERROR for auth function errors 2019-08-14T07:14:01+00:00 Jay Satiro raysatiro@yahoo.com 2019-05-11T06:23:09+00:00 dca6f73613d8b578687bd4aeeedd198f9644bb53 - Add new error code CURLE_AUTH_ERROR. Prior to this change auth function errors were signaled by CURLE_OUT_OF_MEMORY and CURLE_RECV_ERROR, and neither one was technically correct. Ref: https://github.com/curl/curl/pull/3848 Co-authored-by: Dominik Hölzl Closes https://github.com/curl/curl/pull/3864 
- Add new error code CURLE_AUTH_ERROR.

Prior to this change auth function errors were signaled by
CURLE_OUT_OF_MEMORY and CURLE_RECV_ERROR, and neither one was
technically correct.

Ref: https://github.com/curl/curl/pull/3848

Co-authored-by: Dominik Hölzl

Closes https://github.com/curl/curl/pull/3864
http_negotiate: Move the Negotiate state out of the negotiatedata structure 2019-05-14T23:32:42+00:00 Steve Holme steve_holme@hotmail.com 2019-05-13T20:42:35+00:00 e832d1ef74f260146cdab59cbac1d6969836663a Given that this member variable is not used by the SASL based protocols there is no need to have it here. Closes #3882 
Given that this member variable is not used by the SASL based protocols
there is no need to have it here.

Closes #3882
auth: Rename the various authentication clean up functions 2019-05-12T17:37:00+00:00 Steve Holme steve_holme@hotmail.com 2019-05-11T11:57:42+00:00 52dfab65d6822d1281bb62ebc5c46cd2b7501487 For consistency and to a avoid confusion. Closes #3869 
For consistency and to a avoid confusion.

Closes #3869
spnego_gssapi: fix return code on gss_init_sec_context() failure 2019-05-09T07:41:14+00:00 Kamil Dudka kdudka@redhat.com 2019-05-06T12:16:35+00:00 f65845c1eccc02385cdfb22bf2e521e670f7b295 Fixes #3726 Closes #3849 
Fixes #3726
Closes #3849
Negotiate: fix for HTTP POST with Negotiate 2019-03-14T08:26:03+00:00 Dominik Hölzl dominik.hoelzl@fabasoft.at 2018-09-10T07:18:01+00:00 6c6035532383e300c712e4c1cd9fdd749ed5cf59 * Adjusted unit tests 2056, 2057 * do not generally close connections with CURLAUTH_NEGOTIATE after every request * moved negotiatedata from UrlState to connectdata * Added stream rewind logic for CURLAUTH_NEGOTIATE * introduced negotiatedata::GSS_AUTHDONE and negotiatedata::GSS_AUTHSUCC * Consider authproblem state for CURLAUTH_NEGOTIATE * Consider reuse_forbid for CURLAUTH_NEGOTIATE * moved and adjusted negotiate authentication state handling from output_auth_headers into Curl_output_negotiate * Curl_output_negotiate: ensure auth done is always set * Curl_output_negotiate: Set auth done also if result code is GSS_S_CONTINUE_NEEDED/SEC_I_CONTINUE_NEEDED as this result code may also indicate the last challenge request (only works with disabled Expect: 100-continue and CURLOPT_KEEP_SENDING_ON_ERROR -> 1) * Consider "Persistent-Auth" header, detect if not present; Reset/Cleanup negotiate after authentication if no persistent authentication * apply changes introduced with #2546 for negotiate rewind logic Fixes #1261 Closes #1975 
* Adjusted unit tests 2056, 2057
* do not generally close connections with CURLAUTH_NEGOTIATE after every request
* moved negotiatedata from UrlState to connectdata
* Added stream rewind logic for CURLAUTH_NEGOTIATE
* introduced negotiatedata::GSS_AUTHDONE and negotiatedata::GSS_AUTHSUCC
* Consider authproblem state for CURLAUTH_NEGOTIATE
* Consider reuse_forbid for CURLAUTH_NEGOTIATE
* moved and adjusted negotiate authentication state handling from
  output_auth_headers into Curl_output_negotiate
* Curl_output_negotiate: ensure auth done is always set
* Curl_output_negotiate: Set auth done also if result code is
  GSS_S_CONTINUE_NEEDED/SEC_I_CONTINUE_NEEDED as this result code may
  also indicate the last challenge request (only works with disabled
  Expect: 100-continue and CURLOPT_KEEP_SENDING_ON_ERROR -> 1)
* Consider "Persistent-Auth" header, detect if not present;
  Reset/Cleanup negotiate after authentication if no persistent
  authentication
* apply changes introduced with #2546 for negotiate rewind logic

Fixes #1261
Closes #1975
comment: Fix multiple typos in function parameters 2018-10-03T08:27:27+00:00 Daniel Gustafsson daniel@yesql.se 2018-10-03T08:27:27+00:00 e182fc1613196540df12bcaa846e79f80aa5432c Ensure that the parameters in the comment match the actual names in the prototype. Closes #3079 Reviewed-by: Daniel Stenberg <daniel@haxx.se> 
Ensure that the parameters in the comment match the actual names in the
prototype.

Closes #3079
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
gssapi: fix memory leak of output token in multi round context 2017-08-04T22:23:24+00:00 Isaac Boukris iboukris@gmail.com 2017-07-21T23:00:46+00:00 0b11660234c4f9bbea7308402ad739dc3f153b08 When multiple rounds are needed to establish a security context (usually ntlm), we overwrite old token with a new one without free. Found by proposed gss tests using stub a gss implementation (by valgrind error), though I have confirmed the leak with a real gssapi implementation as well. Closes https://github.com/curl/curl/pull/1733 
When multiple rounds are needed to establish a security context
(usually ntlm), we overwrite old token with a new one without free.
Found by proposed gss tests using stub a gss implementation (by
valgrind error), though I have confirmed the leak with a real
gssapi implementation as well.

Closes https://github.com/curl/curl/pull/1733
vauth: Introduced Curl_auth_is_<mechansism>_supported() functions 2016-08-18T19:31:20+00:00 Steve Holme steve_holme@hotmail.com 2016-03-20T11:56:07+00:00 a0f212946b1e839a673973930034b98031f1507c As Windows SSPI authentication calls fail when a particular mechanism isn't available, introduced these functions for DIGEST, NTLM, Kerberos 5 and Negotiate to allow both HTTP and SASL authentication the opportunity to query support for a supported mechanism before selecting it. For now each function returns TRUE to maintain compatability with the existing code when called. 
As Windows SSPI authentication calls fail when a particular mechanism
isn't available, introduced these functions for DIGEST, NTLM, Kerberos 5
and Negotiate to allow both HTTP and SASL authentication the opportunity
to query support for a supported mechanism before selecting it.

For now each function returns TRUE to maintain compatability with the
existing code when called.
spnego: Corrected miss-placed * in Curl_auth_spnego_cleanup() declaration 2016-07-23T20:29:16+00:00 Steve Holme steve_holme@hotmail.com 2016-07-22T19:38:32+00:00 25bf71ab0757694e691ad77c48fa6c438df9416e Typo introduced in commit ad5e9bfd5d. 
Typo introduced in commit ad5e9bfd5d.