delta/curl.git/lib/transfer.c, branch bagder/ftp-over-httpsproxy

transfer: move retrycount from connect struct to easy handle

2020-08-10T21:20:17+00:00

This flag was applied to the connection struct that is released on
retry.  These changes move the retry counter into Curl_easy struct that
lives across retries and retains the new connection.

Reported-by: Cherish98 on github
Fixes #5794
Closes #5800

transfer: fix data_pending for builds with both h2 and h3 enabled

2020-07-28T21:48:49+00:00

Closes #5734

transfer: fix memory-leak with CURLOPT_CURLU in a duped handle

2020-07-12T14:36:02+00:00

Added test case 674 to reproduce and verify the bug report.

Fixes #5665
Reported-by: NobodyXu on github
Closes #5673

urldata: let the HTTP method be in the set.* struct

2020-06-02T14:30:36+00:00

When the method is updated inside libcurl we must still not change the
method as set by the user as then repeated transfers with that same
handle might not execute the same operation anymore!

This fixes the libcurl part of #5462

Test 1633 added to verify.

Closes #5499

transfer: remove k->str NULL check

2020-06-01T13:22:36+00:00

"Null-checking k->str suggests that it may be null, but it has already
been dereferenced on all paths leading to the check" - and it can't
legally be NULL at this point. Remove check.

Detected by Coverity CID 1463884

Closes #5495

url: alloc the download buffer at transfer start

2020-05-30T21:14:33+00:00

... and free it as soon as the transfer is done. It removes the extra
alloc when a new size is set with setopt() and reduces memory for unused
easy handles.

In addition: the closure_handle now doesn't use an allocated buffer at
all but the smallest supported size as a stack based one.

Closes #5472

transfer: close connection after excess data has been read

2020-05-27T06:16:35+00:00

For HTTP 1.x, it's a protocol error when the server sends more bytes
than announced. If this happens, don't reuse the connection, because the
start position of the next response is undefined.

Closes #5440

dynbuf: introduce internal generic dynamic buffer functions

2020-05-04T08:40:39+00:00

A common set of functions instead of many separate implementations for
creating buffers that can grow when appending data to them. Existing
functionality has been ported over.

In my early basic testing, the total number of allocations seem at
roughly the same amount as before, possibly a few less.

See docs/DYNBUF.md for a description of the API.

Closes #5300

transfer: Switch PUT to GET/HEAD on 303 redirect

2020-04-22T21:56:17+00:00

Prior to this change if there was a 303 reply to a PUT request then
the subsequent request to respond to that redirect would also be a PUT.
It was determined that was most likely incorrect based on the language
of the RFCs. Basically 303 means "see other" resource, which implies it
is most likely not the same resource, therefore we should not try to PUT
to that different resource.

Refer to the discussions in #5237 and #5248 for more information.

Fixes https://github.com/curl/curl/issues/5237
Closes https://github.com/curl/curl/pull/5248

http: don't consider upload done if the request isn't completely sent off

2020-04-08T06:14:23+00:00

Fixes #4919
Closes #5197