<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/curl.git/lib/telnet.c, branch bagder/https-proxy-tests</title>
<subtitle>github.com: bagder/curl.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/'/>
<entry>
<title>build: Disable Visual Studio warning "conditional expression is constant"</title>
<updated>2019-12-02T00:01:02+00:00</updated>
<author>
<name>Jay Satiro</name>
<email>raysatiro@yahoo.com</email>
</author>
<published>2019-11-30T08:29:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=9c1806ae4684ec5ef1aeb39bb9f15cece1c27256'/>
<id>9c1806ae4684ec5ef1aeb39bb9f15cece1c27256</id>
<content type='text'>
- Disable warning C4127 "conditional expression is constant" globally
  in curl_setup.h for when building with Microsoft's compiler.

This mainly affects building with the Visual Studio project files found
in the projects dir.

Prior to this change the cmake and winbuild build systems already
disabled 4127 globally for when building with Microsoft's compiler.
Also, 4127 was already disabled for all build systems in the limited
circumstance of the WHILE_FALSE macro which disabled the warning
specifically for while(0). This commit removes the WHILE_FALSE macro and
all other cruft in favor of disabling globally in curl_setup.

Background:

We have various macros that cause 0 or 1 to be evaluated, which would
cause warning C4127 in Visual Studio. For example this causes it:

    #define Curl_resolver_asynch() 1

Full behavior is not clearly defined and inconsistent across versions.
However it is documented that since VS 2015 Update 3 Microsoft has
addressed this somewhat but not entirely, not warning on while(true) for
example.

Prior to this change some C4127 warnings occurred when I built with
Visual Studio using the generated projects in the projects dir.

Closes https://github.com/curl/curl/pull/4658
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Disable warning C4127 "conditional expression is constant" globally
  in curl_setup.h for when building with Microsoft's compiler.

This mainly affects building with the Visual Studio project files found
in the projects dir.

Prior to this change the cmake and winbuild build systems already
disabled 4127 globally for when building with Microsoft's compiler.
Also, 4127 was already disabled for all build systems in the limited
circumstance of the WHILE_FALSE macro which disabled the warning
specifically for while(0). This commit removes the WHILE_FALSE macro and
all other cruft in favor of disabling globally in curl_setup.

Background:

We have various macros that cause 0 or 1 to be evaluated, which would
cause warning C4127 in Visual Studio. For example this causes it:

    #define Curl_resolver_asynch() 1

Full behavior is not clearly defined and inconsistent across versions.
However it is documented that since VS 2015 Update 3 Microsoft has
addressed this somewhat but not entirely, not warning on while(true) for
example.

Prior to this change some C4127 warnings occurred when I built with
Visual Studio using the generated projects in the projects dir.

Closes https://github.com/curl/curl/pull/4658
</pre>
</div>
</content>
</entry>
<entry>
<title>urldata: simplify bytecounters</title>
<updated>2019-03-01T16:30:34+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2019-02-28T10:36:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=65eb65fde64bd5faff6d6a7740f9436336e290e0'/>
<id>65eb65fde64bd5faff6d6a7740f9436336e290e0</id>
<content type='text'>
- no need to have them protocol specific

- no need to set pointers to them with the Curl_setup_transfer() call

- make Curl_setup_transfer() operate on a transfer pointer, not
  connection

- switch some counters from long to the more proper curl_off_t type

Closes #3627
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- no need to have them protocol specific

- no need to set pointers to them with the Curl_setup_transfer() call

- make Curl_setup_transfer() operate on a transfer pointer, not
  connection

- switch some counters from long to the more proper curl_off_t type

Closes #3627
</pre>
</div>
</content>
</entry>
<entry>
<title>snprintf: renamed and we now only use msnprintf()</title>
<updated>2018-11-23T07:26:51+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-11-22T08:01:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=dcd6f810255785d52b89150e18460fb0899d4f7e'/>
<id>dcd6f810255785d52b89150e18460fb0899d4f7e</id>
<content type='text'>
The function does not return the same value as snprintf() normally does,
so readers may be mislead into thinking the code works differently than
it actually does. A different function name makes this easier to detect.

Reported-by: Tomas Hoger
Assisted-by: Daniel Gustafsson
Fixes #3296
Closes #3297
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The function does not return the same value as snprintf() normally does,
so readers may be mislead into thinking the code works differently than
it actually does. A different function name makes this easier to detect.

Reported-by: Tomas Hoger
Assisted-by: Daniel Gustafsson
Fixes #3296
Closes #3297
</pre>
</div>
</content>
</entry>
<entry>
<title>curl-compilers: enable -Wimplicit-fallthrough=4 for GCC</title>
<updated>2018-08-21T16:53:45+00:00</updated>
<author>
<name>Marcel Raad</name>
<email>Marcel.Raad@teamviewer.com</email>
</author>
<published>2018-07-09T16:52:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=15ed9f87e3a1f91bd7b4a5291edf268b843e5987'/>
<id>15ed9f87e3a1f91bd7b4a5291edf268b843e5987</id>
<content type='text'>
This enables level 4 instead of the default level 3, which of the
currently used comments only allows /* FALLTHROUGH */ to silence the
warning.

Closes https://github.com/curl/curl/pull/2747
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This enables level 4 instead of the default level 3, which of the
currently used comments only allows /* FALLTHROUGH */ to silence the
warning.

Closes https://github.com/curl/curl/pull/2747
</pre>
</div>
</content>
</entry>
<entry>
<title>Silence GCC 8 cast-function-type warnings</title>
<updated>2018-08-11T17:19:03+00:00</updated>
<author>
<name>Marcel Raad</name>
<email>Marcel.Raad@teamviewer.com</email>
</author>
<published>2018-08-09T15:19:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=25d2a1bae7871986eabdbe68dc05c5b6473ad4d7'/>
<id>25d2a1bae7871986eabdbe68dc05c5b6473ad4d7</id>
<content type='text'>
On Windows, casting between unrelated function types is fine and
sometimes even necessary, so just use an intermediate cast to
(void (*) (void)) to silence the warning as described in [0].

[0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html

Closes https://github.com/curl/curl/pull/2860
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On Windows, casting between unrelated function types is fine and
sometimes even necessary, so just use an intermediate cast to
(void (*) (void)) to silence the warning as described in [0].

[0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html

Closes https://github.com/curl/curl/pull/2860
</pre>
</div>
</content>
</entry>
<entry>
<title>telnet: Remove unused macros TELOPTS and TELCMDS</title>
<updated>2018-08-09T10:36:58+00:00</updated>
<author>
<name>Rikard Falkeborn</name>
<email>rikard.falkeborn@gmail.com</email>
</author>
<published>2018-08-05T19:53:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=489ac017568a3c99c6ce9070404f74f9fd22a675'/>
<id>489ac017568a3c99c6ce9070404f74f9fd22a675</id>
<content type='text'>
Their usage was removed in 3a145180cc754a5959ca971ef3cd243c5c83fc51.

Closes #2852
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Their usage was removed in 3a145180cc754a5959ca971ef3cd243c5c83fc51.

Closes #2852
</pre>
</div>
</content>
</entry>
<entry>
<title>telnet: fix clang warnings</title>
<updated>2018-07-01T10:45:27+00:00</updated>
<author>
<name>Gisle Vanem</name>
<email>gisle.vanem@gmail.com</email>
</author>
<published>2018-06-29T21:22:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=ab4cf99694fc5a028c4eb7abdc4891919b57a32e'/>
<id>ab4cf99694fc5a028c4eb7abdc4891919b57a32e</id>
<content type='text'>
telnet.c(1401,28): warning: cast from function call of type 'int' to
non-matching type 'HANDLE' (aka 'void *') [-Wbad-function-cast]

Fixes #2696
Closes #2700
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
telnet.c(1401,28): warning: cast from function call of type 'int' to
non-matching type 'HANDLE' (aka 'void *') [-Wbad-function-cast]

Fixes #2696
Closes #2700
</pre>
</div>
</content>
</entry>
<entry>
<title>cppcheck: fix warnings</title>
<updated>2018-06-11T09:14:48+00:00</updated>
<author>
<name>Marian Klymov</name>
<email>nekto1989@gmail.com</email>
</author>
<published>2018-06-02T20:52:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=c45360d4633850839bb9c2d77dbf8a8285e9ad49'/>
<id>c45360d4633850839bb9c2d77dbf8a8285e9ad49</id>
<content type='text'>
- Get rid of variable that was generating false positive warning
(unitialized)

- Fix issues in tests

- Reduce scope of several variables all over

etc

Closes #2631
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Get rid of variable that was generating false positive warning
(unitialized)

- Fix issues in tests

- Reduce scope of several variables all over

etc

Closes #2631
</pre>
</div>
</content>
</entry>
<entry>
<title>spelling fixes</title>
<updated>2018-06-03T12:14:45+00:00</updated>
<author>
<name>Viktor Szakats</name>
<email>vszakats@users.noreply.github.com</email>
</author>
<published>2018-06-03T12:14:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=4bd91bc4742dbf194dd7a63519aa1ed32e4db47d'/>
<id>4bd91bc4742dbf194dd7a63519aa1ed32e4db47d</id>
<content type='text'>
Detected using the `codespell` tool (version 1.13.0).

Also secure and fix an URL.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Detected using the `codespell` tool (version 1.13.0).

Also secure and fix an URL.
</pre>
</div>
</content>
</entry>
<entry>
<title>strictness: correct {infof, failf} format specifiers</title>
<updated>2018-05-31T09:34:32+00:00</updated>
<author>
<name>Rikard Falkeborn</name>
<email>rikard.falkeborn@gmail.com</email>
</author>
<published>2018-05-28T19:46:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=8ea5d41fe0167802c74a049e8409a85fb68083be'/>
<id>8ea5d41fe0167802c74a049e8409a85fb68083be</id>
<content type='text'>
Closes #2623
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes #2623
</pre>
</div>
</content>
</entry>
</feed>
