delta/curl.git/lib/ssh.c, branch bagder/timerfunction-not-recursive

ssh: log the libssh2 error message when ssh session startup fails

2019-01-17T14:03:16+00:00

When a ssh session startup fails, it is useful to know why it has
failed. This commit changes the message from:
   "Failure establishing ssh session"
to something like this, for example:
   "Failure establishing ssh session: -5, Unable to exchange encryption keys"

Closes #3481

snprintf: renamed and we now only use msnprintf()

2018-11-23T07:26:51+00:00

The function does not return the same value as snprintf() normally does,
so readers may be mislead into thinking the code works differently than
it actually does. A different function name makes this easier to detect.

Reported-by: Tomas Hoger
Assisted-by: Daniel Gustafsson
Fixes #3296
Closes #3297

ssh: free the session on init failures

2018-10-26T13:39:15+00:00

Ensure to clear the session object in case the libssh2 initialization
fails.

It could be argued that the libssh2 error function should be called to
get a proper error message in this case. But since the only error path
in libssh2_knownhost_init() is memory a allocation failure it's safest
to avoid since the libssh2 error handling allocates memory.

Closes #3179
Reviewed-by: Daniel Stenberg

sftp: don't send post-qoute sequence when retrying a connection

2018-09-04T09:00:17+00:00

Fixes #2939
Closes #2940

all: s/int/size_t cleanup

2018-09-01T08:40:42+00:00

Assisted-by: Rikard Falkeborn

Closes #2922

curl-compilers: enable -Wimplicit-fallthrough=4 for GCC

2018-08-21T16:53:45+00:00

This enables level 4 instead of the default level 3, which of the
currently used comments only allows /* FALLTHROUGH */ to silence the
warning.

Closes https://github.com/curl/curl/pull/2747

Curl_debug: remove dead printhost code

2018-06-12T14:00:27+00:00

The struct field is never set (since 5e0d9aea3) so remove the use of it
and remove the connectdata pointer from the prototype.

Reported-by: Tejas
Bug: https://curl.haxx.se/mail/lib-2018-06/0054.html
Closes #2647

ssh: show libSSH2 error code when closing fails

2018-04-16T14:46:08+00:00

Closes #2500

ssh: add two missing state names

2018-02-16T08:12:42+00:00

The list of state names (used in debug builds) was out of sync in
relation to the list of states (used in all builds).

I now added an assert to make sure the sizes of the two lists match, to
aid in detecting this mistake better in the future.

Regression since c92d2e14cf, shipped in 7.58.0.

Reported-by: Somnath Kundu

Fixes #2312
Closes #2313

TODO fixed: Detect when called from within callbacks

2018-02-15T08:36:03+00:00

Closes #2302