delta/curl.git/lib/select.h, branch bagder/ftp-over-httpsproxy

select.h: make socket validation macros test for INVALID_SOCKET

2020-08-25T09:17:06+00:00

With Winsock the valid range is [0..INVALID_SOCKET-1] according to
https://docs.microsoft.com/en-us/windows/win32/winsock/socket-data-type-2

Reviewed-by: Jay Satiro
Reviewed-by: Marcel Raad
Reviewed-by: Daniel Stenberg

Closes #5760

select: use timediff_t instead of time_t and int for timeout_ms

2020-05-30T08:20:40+00:00

Make all functions in select.[ch] take timeout_ms as timediff_t
which should always be large enough and signed on all platforms
to take all possible timeout values and avoid type conversions.

Reviewed-by: Jay Satiro
Reviewed-by: Daniel Stenberg

Replaces #5107 and partially #5262
Related to #5240 and #5286
Closes #5343

checksrc: enhance the ASTERISKSPACE and update code accordingly

2020-05-13T22:02:05+00:00

Fine: "struct hello *world"

Not fine: "struct hello* world" (and variations)

Closes #5386

select: make Curl_socket_check take timediff_t timeout

2020-04-23T13:57:23+00:00

Coverity found CID 1461718:

Integer handling issues (CONSTANT_EXPRESSION_RESULT) "timeout_ms >
9223372036854775807L" is always false regardless of the values of its
operands. This occurs as the logical second operand of "||".

Closes #5240

select: remove typecast from SOCKET_WRITABLE/READABLE macros

2020-04-06T22:09:34+00:00

So that they don't hide conversions-by-mistake

Reviewed-by: Jay Satiro
Closes #5190

select: move duplicate select preparation code into Curl_select

2020-03-15T10:08:27+00:00

Reviewed by Daniel Stenberg
Reviewed by Marcel Raad
Closes #5078

global_init: assume the EINTR bit by default

2020-01-26T17:27:18+00:00

- Removed from global_init since it isn't thread-safe. The symbol will
  still remain to not break compiles, it just won't have any effect going
  forward.

- make the internals NOT loop on EINTR (the opposite from previously).
  It only risks returning from the select/poll/wait functions early, and that
  should be risk-free.

Closes #4840

build: Disable Visual Studio warning "conditional expression is constant"

2019-12-02T00:01:02+00:00

- Disable warning C4127 "conditional expression is constant" globally
  in curl_setup.h for when building with Microsoft's compiler.

This mainly affects building with the Visual Studio project files found
in the projects dir.

Prior to this change the cmake and winbuild build systems already
disabled 4127 globally for when building with Microsoft's compiler.
Also, 4127 was already disabled for all build systems in the limited
circumstance of the WHILE_FALSE macro which disabled the warning
specifically for while(0). This commit removes the WHILE_FALSE macro and
all other cruft in favor of disabling globally in curl_setup.

Background:

We have various macros that cause 0 or 1 to be evaluated, which would
cause warning C4127 in Visual Studio. For example this causes it:

    #define Curl_resolver_asynch() 1

Full behavior is not clearly defined and inconsistent across versions.
However it is documented that since VS 2015 Update 3 Microsoft has
addressed this somewhat but not entirely, not warning on while(true) for
example.

Prior to this change some C4127 warnings occurred when I built with
Visual Studio using the generated projects in the projects dir.

Closes https://github.com/curl/curl/pull/4658

timediff: make it 64 bit (if possible) even with 32 bit time_t

2019-08-01T05:43:24+00:00

... to make it hold microseconds too.

Fixes #4165
Closes #4168

whitespace fixes

2018-09-23T22:24:02+00:00

- replace tabs with spaces where possible
- remove line ending spaces
- remove double/triple newlines at EOF
- fix a non-UTF-8 character
- cleanup a few indentations/line continuations
  in manual examples

Closes https://github.com/curl/curl/pull/3037