delta/curl.git/lib/pingpong.c, branch bagder/https-proxy-tests

timediff: make it 64 bit (if possible) even with 32 bit time_t

2019-08-01T05:43:24+00:00

... to make it hold microseconds too.

Fixes #4165
Closes #4168

cleanup: remove the 'numsocks' argument used in many places

2019-07-30T21:16:44+00:00

It was used (intended) to pass in the size of the 'socks' array that is
also passed to these functions, but was rarely actually checked/used and
the array is defined to a fixed size of MAX_SOCKSPEREASYHANDLE entries
that should be used instead.

Closes #4169

pingpong: ignore regular timeout in disconnect phase

2018-12-17T11:33:00+00:00

The timeout set with CURLOPT_TIMEOUT is no longer used when
disconnecting from one of the pingpong protocols (FTP, IMAP, SMTP,
POP3).

Reported-by: jasal82 on github

Fixes #3264
Closes #3374

Curl_debug: remove dead printhost code

2018-06-12T14:00:27+00:00

The struct field is never set (since 5e0d9aea3) so remove the use of it
and remove the connectdata pointer from the prototype.

Reported-by: Tejas
Bug: https://curl.haxx.se/mail/lib-2018-06/0054.html
Closes #2647

cppcheck: fix warnings

2018-06-11T09:14:48+00:00

- Get rid of variable that was generating false positive warning
(unitialized)

- Fix issues in tests

- Reduce scope of several variables all over

etc

Closes #2631

pingpong: fix response cache memcpy overflow

2018-05-14T05:40:31+00:00

Response data for a handle with a large buffer might be cached and then
used with the "closure" handle when it has a smaller buffer and then the
larger cache will be copied and overflow the new smaller heap based
buffer.

Reported-by: Dario Weisser
CVE: CVE-2018-1000300
Bug: https://curl.haxx.se/docs/adv_2018-82c2.html

time: rename Curl_tvnow to Curl_now

2017-10-25T16:48:05+00:00

... since the 'tv' stood for timeval and this function does not return a
timeval struct anymore.

Also, cleaned up the Curl_timediff*() functions to avoid typecasts and
clean up the descriptive comments.

Closes #2011

timediff: return timediff_t from the time diff functions

2017-10-25T07:54:37+00:00

... to cater for systems with unsigned time_t variables.

- Renamed the functions to curlx_timediff and Curl_timediff_us.

- Added overflow protection for both of them in either direction for
  both 32 bit and 64 bit time_ts

- Reprefixed the curlx_time functions to use Curl_*

Reported-by: Peter Piekarski
Fixes #2004
Closes #2005

pingpong: return error when trying to send without connection

2017-10-06T22:20:31+00:00

When imap_done() got called before a connection is setup, it would try
to "finish up" and dereffed a NULL pointer.

Test case 1553 managed to reproduce. I had to actually use a host name
to try to resolve to slow it down, as using the normal local server IP
will make libcurl get a connection in the first curl_multi_perform()
loop and then the bug doesn't trigger.

Fixes #1953
Assisted-by: Max Dymond

code style: use spaces around pluses

2017-09-11T07:29:50+00:00