delta/curl.git/lib/multi.c, branch bagder/chunk-encoding-data

urldata: make magic be the first struct field

2021-01-20T07:51:01+00:00

By making the `magic` identifier the same size and at the same place
within the structs (easy, multi, share), libcurl will be able to more
reliably detect and safely error out if an application passes in the
wrong handle to APIs. Easier to detect and less likely to cause crashes
if done.

Such mixups can't be detected at compile-time due to them being
typedefed void pointers - unless `CURL_STRICTER` is defined.

Closes #6484

transfer: remove conn->data use

2021-01-19T16:07:02+00:00

Closes #6486

lib: more conn->data cleanups

2021-01-19T08:14:51+00:00

Closes #6479

lib: pass in 'struct Curl_easy *' to most functions

2021-01-17T22:56:09+00:00

... in most cases instead of 'struct connectdata *' but in some cases in
addition to.

- We mostly operate on transfers and not connections.

- We need the transfer handle to log, store data and more. Everything in
  libcurl is driven by a transfer (the CURL * in the public API).

- This work clarifies and separates the transfers from the connections
  better.

- We should avoid "conn->data". Since individual connections can be used
  by many transfers when multiplexing, making sure that conn->data
  points to the current and correct transfer at all times is difficult
  and has been notoriously error-prone over the years. The goal is to
  ultimately remove the conn->data pointer for this reason.

Closes #6425

multi: set the PRETRANSFER time-stamp when we switch to PERFORM

2021-01-14T22:16:39+00:00

... instead of at end of the DO state. This makes the timer more
accurate for the protocols that use the DOING state (such as FTP), and
simplifies how the function (now called init_perform) is called.

The timer will then include the entire procedure up to PERFORM -
including all instructions for getting the transfer started.

Closes #6454

multi: remove Curl_ prefix from static functions

2021-01-14T07:09:09+00:00

multi_runsingle: bail out early on data->conn == NULL

2021-01-11T11:33:23+00:00

As that's a significant error condition and scan-build warns for NULL
pointer dereferences if we don't.

Closes #6433

multi: skip DONE state if there's no connection left for ftp wildcard

2021-01-11T11:33:11+00:00

... to avoid running in that state with data->conn being NULL.

httpauth: make multi-request auth work with custom port

2021-01-02T22:40:47+00:00

When doing HTTP authentication and a port number set with CURLOPT_PORT,
the code would previously have the URL's port number override as if it
had been a redirect to an absolute URL.

Added test 1568 to verify.

Reported-by: UrsusArctos on github
Fixes #6397
Closes #6400

multi: when erroring in TOOFAST state, act as for PERFORM

2020-12-17T12:57:27+00:00

When failing in TOOFAST, the multi_done() wasn't called so the same
cleanup and handling wasn't done like when it fails in PERFORM, which in
the case of FTP could mean that the control connection wouldn't be
marked as "dead" for the CURLE_ABORTED_BY_CALLBACK case. Which caused
ftp_disconnect() to use it to send "QUIT", which could end up waiting
for a response a long time before giving up!

Reported-by: Tomas Berger
Fixes #6333
Closes #6337