<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/curl.git/lib/http2.c, branch bagder/unify-sizeof</title>
<subtitle>github.com: bagder/curl.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/'/>
<entry>
<title>checksrc: make sure sizeof() is used *with* parentheses</title>
<updated>2018-05-14T08:59:11+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-05-11T21:40:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=eaf3200f7f08cd7ee5afede3b5576cdac0266665'/>
<id>eaf3200f7f08cd7ee5afede3b5576cdac0266665</id>
<content type='text'>
... and unify the source code to adhere.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
... and unify the source code to adhere.
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: getsock fix for uploads</title>
<updated>2018-05-14T06:22:46+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-05-12T19:58:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=7d6e01441a161c81b19626bdf2b85dafece5f1b8'/>
<id>7d6e01441a161c81b19626bdf2b85dafece5f1b8</id>
<content type='text'>
When there's an upload in progress, make sure to wait for the socket to
become writable.

Detected-by: steini2000 on github
Bug: #2520
Closes #2567
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When there's an upload in progress, make sure to wait for the socket to
become writable.

Detected-by: steini2000 on github
Bug: #2520
Closes #2567
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: fix null pointer dereference in http2_connisdead</title>
<updated>2018-04-26T21:23:02+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-04-26T14:07:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=1d71ce845a6ac3887205c2842fad0a476f7cf3ec'/>
<id>1d71ce845a6ac3887205c2842fad0a476f7cf3ec</id>
<content type='text'>
This function can get called on a connection that isn't setup enough to
have the 'recv_underlying' function pointer initialized so it would try
to call the NULL pointer.

Reported-by: Dario Weisser

Follow-up to db1b2c7fe9b093f8 (never shipped in a release)
Closes #2536
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This function can get called on a connection that isn't setup enough to
have the 'recv_underlying' function pointer initialized so it would try
to call the NULL pointer.

Reported-by: Dario Weisser

Follow-up to db1b2c7fe9b093f8 (never shipped in a release)
Closes #2536
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: get rid of another strstr()</title>
<updated>2018-04-26T12:55:26+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-04-26T08:41:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=2ef1662e4bc20f1641bc678141c2df0e42e21e3f'/>
<id>2ef1662e4bc20f1641bc678141c2df0e42e21e3f</id>
<content type='text'>
Follow-up to 1514c44655e12e: replace another strstr() call done on a
buffer that might not be zero terminated - with a memchr() call, even if
we know the substring will be found.

Assisted-by: Max Dymond

Detected by OSS-Fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8021

Closes #2534
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Follow-up to 1514c44655e12e: replace another strstr() call done on a
buffer that might not be zero terminated - with a memchr() call, even if
we know the substring will be found.

Assisted-by: Max Dymond

Detected by OSS-Fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8021

Closes #2534
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: convert an assert to run-time check</title>
<updated>2018-04-23T11:51:32+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-04-21T10:33:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=0a3589ccd0dbf5f3a826b669517ccc12893fa153'/>
<id>0a3589ccd0dbf5f3a826b669517ccc12893fa153</id>
<content type='text'>
Fuzzing has proven we can reach code in on_frame_recv with status_code
not having been set, so let's detect that in run-time (instead of with
assert) and error error accordingly.

(This should no longer happen with the latest nghttp2)

Detected by OSS-Fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7903
Closes #2514
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fuzzing has proven we can reach code in on_frame_recv with status_code
not having been set, so let's detect that in run-time (instead of with
assert) and error error accordingly.

(This should no longer happen with the latest nghttp2)

Detected by OSS-Fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7903
Closes #2514
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: handle GOAWAY properly</title>
<updated>2018-04-20T20:19:23+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-04-19T18:03:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=d122df5972fc01e39ae28e6bca705237d7e3318a'/>
<id>d122df5972fc01e39ae28e6bca705237d7e3318a</id>
<content type='text'>
When receiving REFUSED_STREAM, mark the connection for close and retry
streams accordingly on another/fresh connection.

Reported-by: Terry Wu
Fixes #2416
Fixes #1618
Closes #2510
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When receiving REFUSED_STREAM, mark the connection for close and retry
streams accordingly on another/fresh connection.

Reported-by: Terry Wu
Fixes #2416
Fixes #1618
Closes #2510
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: clear the "drain counter" when a stream is closed</title>
<updated>2018-04-20T20:18:19+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-04-19T18:01:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=7645c6bd5ea6c337414a264b37f50995b0f9e7d2'/>
<id>7645c6bd5ea6c337414a264b37f50995b0f9e7d2</id>
<content type='text'>
This fixes the notorious "httpc-&gt;drain_total &gt;= data-&gt;state.drain"
assert.

Reported-by: Anders Bakken

Fixes #1680
Closes #2509
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes the notorious "httpc-&gt;drain_total &gt;= data-&gt;state.drain"
assert.

Reported-by: Anders Bakken

Fixes #1680
Closes #2509
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: avoid strstr() on data not zero terminated</title>
<updated>2018-04-20T20:16:50+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-04-20T14:32:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=1514c44655e12e93e453bbc9e1934cf6d30d3817'/>
<id>1514c44655e12e93e453bbc9e1934cf6d30d3817</id>
<content type='text'>
It's not strictly clear if the API contract allows us to call strstr()
on a string that isn't zero terminated even when we know it will find
the substring, and clang's ASAN check dislikes us for it.

Also added a check of the return code in case it fails, even if I can't
think of a situation how that can trigger.

Detected by OSS-Fuzz
Closes #2513
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7760
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's not strictly clear if the API contract allows us to call strstr()
on a string that isn't zero terminated even when we know it will find
the substring, and clang's ASAN check dislikes us for it.

Also added a check of the return code in case it fails, even if I can't
think of a situation how that can trigger.

Detected by OSS-Fuzz
Closes #2513
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7760
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: handle on_begin_headers() called more than once</title>
<updated>2018-04-19T06:06:40+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-04-18T21:51:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=6d3c9c8ab4754ea21622d65f11df403bbaf46e2d'/>
<id>6d3c9c8ab4754ea21622d65f11df403bbaf46e2d</id>
<content type='text'>
This triggered an assert if called more than once in debug mode (and a
memory leak if not debug build). With the right sequence of HTTP/2
headers incoming it can happen.

Detected by OSS-Fuzz

Closes #2507
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7764
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This triggered an assert if called more than once in debug mode (and a
memory leak if not debug build). With the right sequence of HTTP/2
headers incoming it can happen.

Detected by OSS-Fuzz

Closes #2507
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7764
</pre>
</div>
</content>
</entry>
<entry>
<title>http2: read pending frames (including GOAWAY) in connection-check</title>
<updated>2018-03-21T23:09:15+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2018-03-19T15:28:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=db1b2c7fe9b093f8c3d33304a47657ea4a6e65b4'/>
<id>db1b2c7fe9b093f8c3d33304a47657ea4a6e65b4</id>
<content type='text'>
If a connection has received a GOAWAY frame while not being used, the
function now reads frames off the connection before trying to reuse it
to avoid reusing connections the server has told us not to use.

Reported-by: Alex Baines
Fixes #1967
Closes #2402
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If a connection has received a GOAWAY frame while not being used, the
function now reads frames off the connection before trying to reuse it
to avoid reusing connections the server has told us not to use.

Reported-by: Alex Baines
Fixes #1967
Closes #2402
</pre>
</div>
</content>
</entry>
</feed>
