delta/curl.git/lib/ftp.c, branch bagder/test493-https

ftp: fix memory leak in ftp_done

2021-03-12T18:53:05+00:00

If after a transfer is complete Curl_GetFTPResponse() returns an error,
curl would not free the ftp->pathalloc block.

Found by torture-testing test 576

Closes #6737

FTP: allow SIZE to fail when doing (resumed) upload

2021-03-11T15:13:11+00:00

Added test 362 to verify.

Reported-by: Jordan Brown
Regression since 7ea2e1d0c5a7f (7.73.0)
Fixes #6715
Closes #6725

ftp: fix Codacy/cppcheck warning about null pointer arithmetic

2021-02-10T15:46:52+00:00

Increment `bytes` only if it is non-null.

Closes https://github.com/curl/curl/pull/6576

ftp: add 'list_only' to the transfer state struct

2021-02-09T13:06:28+00:00

and rename it from 'ftp_list_only' since it is also used for SSH and
POP3. The state is updated internally for 'type=D' FTP URLs.

Added test case 1570 to verify.

Closes #6578

ftp: add 'prefer_ascii' to the transfer state struct

2021-02-09T13:06:28+00:00

... and make sure the code never updates 'set.prefer_ascii' as it breaks
handle reuse which should use the setting as the user specified it.

Added test 1569 to verify: it first makes an FTP transfer with ';type=A'
and then another without type on the same handle and the second should
then use binary. Previously, curl failed this.

Closes #6578

ftp: never set data->set.ftp_append outside setopt

2021-02-08T21:44:37+00:00

Since the set value then risks getting used like that when the easy
handle is reused by the application.

Also: renamed the struct field from 'ftp_append' to 'remote_append'
since it is also used for SSH protocols.

Closes #6579

ftp: avoid SIZE when asking for a TYPE A file

2021-02-04T22:06:03+00:00

... as we ignore it anyway because servers don't report the correct size
and proftpd even blatantly returns a 550.

Updates a set of tests accordingly.

Reported-by: awesomenode on github
Fixes #6564
Closes #6565

pingpong: rename the curl_pp_transfer enum to use PP prefix

2021-02-04T22:06:03+00:00

Using an FTP prefix for PP provided functionality was misleading.

urldata: remove the duplicate 'ip_addr_str' field

2021-01-27T08:18:51+00:00

... as the numerical IP address is already stored and kept in 'primary_ip'.

Closes #6534

lib: remove conn->data uses

2021-01-26T14:19:41+00:00

Closes #6515