delta/curl.git/lib/ftp.c, branch bagder/https-proxyu-req-http github.com: bagder/curl.git ftp: separate FTPS from FTP over "HTTPS proxy" 2020-09-24T12:09:20+00:00 Daniel Stenberg daniel@haxx.se 2020-09-21T07:15:51+00:00 1397a7de6e312e019a3b339f855ba0a5cafa9127 When using HTTPS proxy, SSL is used but not in the view of the FTP protocol handler itself so separate the connection's use of SSL from the FTP control connection's sue. Reported-by: Mingtao Yang Fixes #5523 Closes #6006 
When using HTTPS proxy, SSL is used but not in the view of the FTP
protocol handler itself so separate the connection's use of SSL from the
FTP control connection's sue.

Reported-by: Mingtao Yang
Fixes #5523
Closes #6006
pingpong: use a dynbuf for the *_pp_sendf() function 2020-09-23T13:14:09+00:00 Daniel Stenberg daniel@haxx.se 2020-09-23T07:22:02+00:00 675eeb1c941706070381faaad8ee1a5d75cff4a4 ... reuses the same dynamic buffer instead of doing repeated malloc/free cycles. Test case 100 (FTP dir list PASV) does 7 fewer memory allocation calls after this change in my test setup (132 => 125), curl 7.72.0 needed 140 calls for this. Test case 103 makes 9 less allocations now (130). Down from 149 in 7.72.0. Closes #6004 
... reuses the same dynamic buffer instead of doing repeated malloc/free
cycles.

Test case 100 (FTP dir list PASV) does 7 fewer memory allocation calls
after this change in my test setup (132 => 125), curl 7.72.0 needed 140
calls for this.

Test case 103 makes 9 less allocations now (130). Down from 149 in
7.72.0.

Closes #6004
curl_krb5.h: rename from krb5.h 2020-09-22T11:46:22+00:00 Daniel Stenberg daniel@haxx.se 2020-09-22T09:22:34+00:00 1ee289f7b50a414ab4599dae796e286d617bc79e Follow-up from f4873ebd0be32cf Turns out some older openssl installations go bananas otherwise. Reported-by: Tom van der Woerdt Fixes #5995 Closes #5996 
Follow-up from f4873ebd0be32cf

Turns out some older openssl installations go bananas otherwise.
Reported-by: Tom van der Woerdt
Fixes #5995
Closes #5996
krb5: merged security.c and krb specific FTP functions in here 2020-09-21T21:31:39+00:00 Daniel Stenberg daniel@haxx.se 2020-09-21T11:59:33+00:00 f4873ebd0be32cf9ae2c389e0b328f0e03211c84 These two files were always tightly connected and it was hard to understand what went into which. This also allows us to make the ftpsend() function static (moved from ftp.c). Removed security.c Renamed curl_sec.h to krb5.h Closes #5987 
These two files were always tightly connected and it was hard to
understand what went into which. This also allows us to make the
ftpsend() function static (moved from ftp.c).

Removed security.c
Renamed curl_sec.h to krb5.h

Closes #5987
Curl_handler: add 'family' to each protocol 2020-09-21T21:30:16+00:00 Daniel Stenberg daniel@haxx.se 2020-09-21T11:45:24+00:00 6434a73984b2527194d6409021693c7032d17570 Makes get_protocol_family() faster and it moves the knowledge about the "families" to each protocol handler, where it belongs. Closes #5986 
Makes get_protocol_family() faster and it moves the knowledge about the
"families" to each protocol handler, where it belongs.

Closes #5986
ftp: avoid risk of reading uninitialized integers 2020-09-18T06:26:49+00:00 Daniel Stenberg daniel@haxx.se 2020-09-17T14:16:38+00:00 3d8731c8f52cf1ed40bbabd319a3b732cdbcd3d2 If the received PASV response doesn't match the expected pattern, we could end up reading uninitialized integers for IP address and port number. Issue pointed out by muse.dev Closes #5972 
If the received PASV response doesn't match the expected pattern, we
could end up reading uninitialized integers for IP address and port
number.

Issue pointed out by muse.dev
Closes #5972
ftp: get rid of the PPSENDF macro 2020-09-18T05:56:16+00:00 Daniel Stenberg daniel@haxx.se 2020-09-17T13:15:08+00:00 cc372af1e9cd12d5dbb4d0380a47a8e017896da8 The use of such a macro hides some of what's actually going on to the reader and is generally disapproved of in the project. Closes #5971 
The use of such a macro hides some of what's actually going on to the
reader and is generally disapproved of in the project.

Closes #5971
ftp: a 550 response to SIZE returns CURLE_REMOTE_FILE_NOT_FOUND 2020-09-14T10:53:12+00:00 Daniel Stenberg daniel@haxx.se 2020-09-12T16:27:08+00:00 7ea2e1d0c5a7fc7e2797a2d3c2a2429d6e09e581 This is primarily interesting for cases where CURLOPT_NOBODY is set as previously curl would not return an error for this case. MDTM getting 550 now also returns this error (it returned CURLE_FTP_COULDNT_RETR_FILE before) in order to unify return codes for missing files across protocols and specific FTP commands. libcurl already returns error on a 550 as a MDTM response (when CURLOPT_FILETIME is set). If CURLOPT_NOBODY is not set, an error would happen subsequently anyway since the RETR command would fail. Add test 1913 and 1914 to verify. Updated several tests accordingly due to the updated SIZE behavior. Reported-by: Tomas Berger Fixes #5953 Closes #5957 
This is primarily interesting for cases where CURLOPT_NOBODY is set as
previously curl would not return an error for this case.

MDTM getting 550 now also returns this error (it returned
CURLE_FTP_COULDNT_RETR_FILE before) in order to unify return codes for
missing files across protocols and specific FTP commands.

libcurl already returns error on a 550 as a MDTM response (when
CURLOPT_FILETIME is set). If CURLOPT_NOBODY is not set, an error would
happen subsequently anyway since the RETR command would fail.

Add test 1913 and 1914 to verify. Updated several tests accordingly due
to the updated SIZE behavior.

Reported-by: Tomas Berger
Fixes #5953
Closes #5957
ftp: don't do ssl_shutdown instead of ssl_close 2020-08-10T12:32:06+00:00 Daniel Stenberg daniel@haxx.se 2020-08-10T08:56:20+00:00 aecce3551cbb62a7980e8d22b40eabc091f896a0 The shutdown function is for downgrading a connection from TLS to plain, and this is not requested here. Have ssl_close reset the TLS connection state. This partially reverts commit f002c850d98d Reported-by: Rasmus Melchior Jacobsen Reported-by: Denis Goleshchikhin Fixes #5797 
The shutdown function is for downgrading a connection from TLS to plain,
and this is not requested here.

Have ssl_close reset the TLS connection state.

This partially reverts commit f002c850d98d

Reported-by: Rasmus Melchior Jacobsen
Reported-by: Denis Goleshchikhin
Fixes #5797
terminology: call them null-terminated strings 2020-06-27T22:31:24+00:00 Daniel Stenberg daniel@haxx.se 2020-06-25T09:38:25+00:00 032e838b73578e9a5e8d2cf2ca0f5f2097006060 Updated terminology in docs, comments and phrases to refer to C strings as "null-terminated". Done to unify with how most other C oriented docs refer of them and what users in general seem to prefer (based on a single highly unscientific poll on twitter). Reported-by: coinhubs on github Fixes #5598 Closes #5608 
Updated terminology in docs, comments and phrases to refer to C strings
as "null-terminated". Done to unify with how most other C oriented docs
refer of them and what users in general seem to prefer (based on a
single highly unscientific poll on twitter).

Reported-by: coinhubs on github
Fixes #5598
Closes #5608