delta/curl.git/lib/cookie.c, branch bagder/https-proxyu-req-http

terminology: call them null-terminated strings

2020-06-27T22:31:24+00:00

Updated terminology in docs, comments and phrases to refer to C strings
as "null-terminated". Done to unify with how most other C oriented docs
refer of them and what users in general seem to prefer (based on a
single highly unscientific poll on twitter).

Reported-by: coinhubs on github
Fixes #5598
Closes #5608

cookie: get_top_domain() sets zero length for null domains

2020-03-08T16:30:55+00:00

This silents a compilation warning with gcc -O3.

cookie: remove unnecessary check for 'out != 0'

2020-02-26T22:50:03+00:00

... as it will always be non-NULL at this point.

Detected by Coverity: CID 1459009

cleanup: comment typos

2020-02-21T07:38:00+00:00

Spotted by 'codespell'

Closes #4957

rename: a new file for Curl_rename()

2020-02-18T06:49:15+00:00

And make the cookie save function use it.

cookies: make saving atomic with a rename

2020-02-17T21:45:42+00:00

Saves the file as "[filename].[8 random hex digits].tmp" and renames
away the extension when done.

Co-authored-by: Jay Satiro
Reported-by: Mike Frysinger
Fixes #4914
Closes #4926

cookie: check Secure- and Host- case sensitively

2020-01-29T15:01:23+00:00

While most keywords in cookies are case insensitive, these prefixes are
specified explicitly to get checked "with a case-sensitive match".

(From the 6265bis document in progress)

Ref: https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-04
Closes #4864

build: Disable Visual Studio warning "conditional expression is constant"

2019-12-02T00:01:02+00:00

- Disable warning C4127 "conditional expression is constant" globally
  in curl_setup.h for when building with Microsoft's compiler.

This mainly affects building with the Visual Studio project files found
in the projects dir.

Prior to this change the cmake and winbuild build systems already
disabled 4127 globally for when building with Microsoft's compiler.
Also, 4127 was already disabled for all build systems in the limited
circumstance of the WHILE_FALSE macro which disabled the warning
specifically for while(0). This commit removes the WHILE_FALSE macro and
all other cruft in favor of disabling globally in curl_setup.

Background:

We have various macros that cause 0 or 1 to be evaluated, which would
cause warning C4127 in Visual Studio. For example this causes it:

    #define Curl_resolver_asynch() 1

Full behavior is not clearly defined and inconsistent across versions.
However it is documented that since VS 2015 Update 3 Microsoft has
addressed this somewhat but not entirely, not warning on while(true) for
example.

Prior to this change some C4127 warnings occurred when I built with
Visual Studio using the generated projects in the projects dir.

Closes https://github.com/curl/curl/pull/4658

parsedate: offer a getdate_capped() alternative

2019-11-29T10:01:24+00:00

... and use internally. This function will return TIME_T_MAX instead of
failure if the parsed data is found to be larger than what can be
represented. TIME_T_MAX being the largest value curl can represent.

Reviewed-by: Daniel Gustafsson
Reported-by: JanB on github
Fixes #4152
Closes #4651

curl_setup_once: consistently use WHILE_FALSE in macros

2019-11-28T15:02:13+00:00

The WHILE_FALSE construction is used to avoid compiler warnings in
macro constructions. This fixes a few instances where it was not
used in order to keep the code consistent.

Closes #4649
Reviewed-by: Daniel Stenberg