delta/curl.git/lib/content_encoding.c, branch bagder/timerfunction-not-recursive

content_encoding: accept up to 4 unknown trailer bytes after raw deflate data

2018-07-12T20:46:15+00:00

Some servers issue raw deflate data that may be followed by an undocumented
trailer. This commit makes curl tolerate such a trailer of up to 4 bytes
before considering the data is in error.

Reported-by: clbr on github
Fixes #2719

cppcheck: fix warnings

2018-06-11T09:14:48+00:00

- Get rid of variable that was generating false positive warning
(unitialized)

- Fix issues in tests

- Reduce scope of several variables all over

etc

Closes #2631

content_encoding: handle zlib versions too old for Z_BLOCK

2018-05-25T08:04:08+00:00

Fallback on Z_SYNC_FLUSH when Z_BLOCK is not available.

Fixes #2606
Closes #2608

all: Refactor malloc+memset to use calloc

2018-04-15T07:00:37+00:00

When a zeroed out allocation is required, use calloc() rather than
malloc() followed by an explicit memset(). The result will be the
same, but using calloc() everywhere increases consistency in the
codebase and avoids the risk of subtle bugs when code is injected
between malloc and memset by accident.

Closes https://github.com/curl/curl/pull/2497

content_encoding: Add "none" alias to "identity"

2018-02-09T08:11:18+00:00

Some servers return a "content-encoding" header with a non-standard
"none" value.

Add "none" as an alias to "identity" as a work-around, to avoid
unrecognised content encoding type errors.

Signed-off-by: Mohammad AlSaleh 

Closes https://github.com/curl/curl/pull/2298

brotli: data at the end of content can be lost

2017-12-27T12:00:54+00:00

Decoding loop implementation did not concern the case when all
received data is consumed by Brotli decoder and the size of decoded
data internally hold by Brotli decoder is greater than CURL_MAX_WRITE_SIZE.
For content with unencoded length greater than CURL_MAX_WRITE_SIZE this
can result in the loss of data at the end of content.

Closes #2194

content_encoding: rework zlib_inflate

2017-12-20T15:02:42+00:00

- When zlib version is < 1.2.0.4, process gzip trailer before considering
extra data as an error.
- Inflate with Z_BLOCK instead of Z_SYNC_FLUSH to maximize correct data
and minimize corrupt data output.
- Do not try to restart deflate decompression in raw mode if output has
started or if the leading data is not available anymore.
- New test 232 checks inflating raw-deflated content.

Closes #2068

brotli: allow compiling with version 0.6.0.

2017-12-20T14:30:35+00:00

Some error codes were not yet defined in brotli 0.6.0: do not issue code
for them in this case.

zlib/brotli: only include header files in modules needing them

2017-11-13T13:20:41+00:00

There is a conflict on symbol 'free_func' between openssl/crypto.h and
zlib.h on AIX. This is an attempt to resolve it.

Bug: https://curl.haxx.se/mail/lib-2017-11/0032.html
Reported-By: Michael Felt

content_encoding: fix inflate_stream for no bytes available

2017-11-09T06:36:50+00:00

- Don't call zlib's inflate() when avail_in stream bytes is 0.

This is a follow up to the parent commit 19e66e5. Prior to that change
libcurl's inflate_stream could call zlib's inflate even when no bytes
were available, causing inflate to return Z_BUF_ERROR, and then
inflate_stream would treat that as a hard error and return
CURLE_BAD_CONTENT_ENCODING.

According to the zlib FAQ, Z_BUF_ERROR is not fatal.

This bug would happen randomly since packet sizes are arbitrary. A test
of 10,000 transfers had 55 fail (ie 0.55%).

Ref: https://zlib.net/zlib_faq.html#faq05

Closes https://github.com/curl/curl/pull/2060