delta/curl.git/lib/conncache.c, branch bagder/https-proxy-tests

conncache: various concept cleanups

2020-04-30T12:27:54+00:00

More connection cache accesses are protected by locks.

CONNCACHE_* is a beter prefix for the connection cache lock macros.

Curl_attach_connnection: now called as soon as there's a connection
struct available and before the connection is added to the connection
cache.

Curl_disconnect: now assumes that the connection is already removed from
the connection cache.

Ref: #4915
Closes #5009

conncache: removed unused Curl_conncache_bundle_size()

2020-01-24T09:29:06+00:00

conncache: CONNECT_ONLY connections assumed always in-use

2019-12-11T08:25:56+00:00

This makes them never to be considered "the oldest" to be discarded when
reaching the connection cache limit. The reasoning here is that
CONNECT_ONLY is primarily used in combination with using the
connection's socket post connect and since that is used outside of
curl's knowledge we must assume that it is in use until explicitly
closed.

Reported-by: Pavel Pavlov
Reported-by: Pavel Löbl
Fixes #4426
Fixes #4369
Closes #4696

conncache: fix multi-thread use of shared connection cache

2019-12-09T14:30:09+00:00

It could accidentally let the connection get used by more than one
thread, leading to double-free and more.

Reported-by: Christopher Reid
Fixes #4544
Closes #4557

url: make Curl_close() NULLify the pointer too

2019-10-30T08:36:21+00:00

This is the common pattern used in the code and by a unified approach we
avoid mistakes.

Closes #4534

conncache: Remove the DEBUGASSERT on length check

2019-05-29T21:07:43+00:00

We trust the calling code as this is an internal function.

Closes #3962

url: default conn->port to the same as conn->remote_port

2019-05-28T21:00:42+00:00

... so that it has a sensible value when ConnectionExists() is called which
needs it set to differentiate host "bundles" correctly on port number!

Also, make conncache:hashkey() use correct port for bundles that are proxy vs
host connections.

Probably a regression from 7.62.0

Reported-by: Tom van der Woerdt
Fixes #3956
Closes #3957

conncache: make "bundles" per host name when doing proxy tunnels

2019-05-28T14:23:59+00:00

Only HTTP proxy use where multiple host names can be used over the same
connection should use the proxy host name for bundles.

Reported-by: Tom van der Woerdt
Fixes #3951
Closes #3955

CURLOPT_MAXAGE_CONN: set the maximum allowed age for conn reuse

2019-04-21T21:06:23+00:00

... and disconnect too old ones instead of trying to reuse.

Default max age is set to 118 seconds.

Ref: #3722
Closes #3782

conncache: use conn->data to know if a transfer owns it

2019-03-17T17:07:20+00:00

- make sure an already "owned" connection isn't returned unless
  multiplexed.

- clear ->data when returning the connection to the cache again

Regression since 7.62.0 (probably in commit 1b76c38904f0)

Bug: https://curl.haxx.se/mail/lib-2019-03/0064.html

Closes #3686