delta/curl.git, branch karpenko/sclient-cert-store-open

schannel: client certificate store opening fix

2018-08-23T12:47:31+00:00

1) Using CERT_STORE_OPEN_EXISTING_FLAG ( or CERT_STORE_READONLY_FLAG )
while opening certificate store would be sufficient in this scenario and
less-demanding in sense of required user credentials ( for example,
IIS_IUSRS will get "Access Denied" 0x05 error for existing CertOpenStore
call without any of flags mentioned above ),

2) as 'cert_store_name' is a DWORD, attempt to format its value like a
string ( in "Failed to open cert store" error message ) will throw null
pointer exception

3) adding GetLastError(), in my opinion, will make error message more
useful.

Bug: https://curl.haxx.se/mail/lib-2018-08/0198.html

libcurl-thread.3: expand somewhat on the NO_SIGNAL motivation

2018-08-23T06:29:55+00:00

Multi-threaded applictions basically MUST set CURLOPT_NO_SIGNAL to 1L to
avoid the risk of getting a SIGPIPE.

Either way, a multi-threaded application that uses libcurl/openssl needs
to have a signhandler for or ignore SIGPIPE on its own.

Based on discussions in #2800
Closes #2904

RELEASE-NOTES: synced

2018-08-22T12:11:22+00:00

Tests: fixes for Windows

2018-08-22T10:26:21+00:00

- test 1268 requires unix sockets
- test 2072 must be disabled also for MSYS/MinGW

http2: abort the send_callback if not setup yet

2018-08-22T07:47:22+00:00

When Curl_http2_done() gets called before the http2 data is setup all
the way, we cannot send anything and this should just return an error.

Detected by OSS-Fuzz
Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10012

http2: remove four unused nghttp2 callbacks

2018-08-21T21:24:30+00:00

Closes #2903

x509asn1: use FALLTHROUGH

2018-08-21T20:26:36+00:00

... as no other comments are accepted since 014ed7c22f51463

test1148: disable if decimal separator is not point

2018-08-21T17:00:48+00:00

Modifying the locale with environment variables doesn't work for native
Windows applications. Just disable the test in this case if the decimal
separator is something different than a point. Use a precheck with a
small C program to achieve that.

Closes https://github.com/curl/curl/pull/2786

Enable more GCC warnings

2018-08-21T16:53:46+00:00

This enables the following additional warnings:
-Wold-style-definition
-Warray-bounds=2 instead of the default 1
-Wformat=2, but only for GCC 4.8+ as Wno-format-nonliteral is not
 respected for older versions
-Wunused-const-variable, which enables level 2 instead of the default 1
-Warray-bounds also in debug mode through -ftree-vrp
-Wnull-dereference also in debug mode through
 -fdelete-null-pointer-checks

Closes https://github.com/curl/curl/pull/2747

curl-compilers: enable -Wimplicit-fallthrough=4 for GCC

2018-08-21T16:53:45+00:00

This enables level 4 instead of the default level 3, which of the
currently used comments only allows /* FALLTHROUGH */ to silence the
warning.

Closes https://github.com/curl/curl/pull/2747