delta/curl.git, branch bagder/tool-avoid-curl-prefix

tool: do not declare functions with Curl_ prefix

2020-04-13T21:47:34+00:00

To avoid collision risks with private libcurl symbols when linked with
static versions (or just versions not hiding internal symbols).

Reported-by: hydra3333 on github
Fixes #5219

cmake: add aliases so exported target names are available in tree

2020-04-13T21:27:35+00:00

Reviewed-by: Brad King
Closes #5206

version: increase buffer space for ssl version output

2020-04-13T20:26:53+00:00

To avoid it getting truncated, especially when several SSL backends are
built-in.

Reported-by: Gisle Vanem
Fixes #5222
Closes #5226

cirrus: no longer ignore test 504 which is working again

2020-04-13T18:27:00+00:00

The test is working again, because TCP blackholing is disabled.

appveyor: completely disable tests that fail to timeout early

2020-04-13T17:35:30+00:00

The tests changed from ignored to disabled are tests that are
about connecting to non-listening socket. On AppVeyor these
tests are not reliable, because for some unknown reason the
connect is not timing out before the test time limit is reached.

test1908: avoid using fixed port number in test data

2020-04-12T23:05:01+00:00

Closes #5225

schannel: Fix blocking timeout logic

2020-04-12T22:32:17+00:00

- Fix schannel_send for the case when no timeout was set.

Prior to this change schannel would error if the socket was not ready
to send data and no timeout was set.

This commit is similar to parent commit 89dc6e0 which recently made the
same change for SOCKS, for the same reason. Basically it was not well
understood that when Curl_timeleft returns 0 it is not a timeout of 0 ms
but actually means no timeout.

Fixes https://github.com/curl/curl/issues/5177
Closes https://github.com/curl/curl/pull/5221

socks: Fix blocking timeout logic

2020-04-12T22:32:16+00:00

- Document in Curl_timeleft's comment block that returning 0 signals no
  timeout (ie there's infinite time left).

- Fix SOCKS' Curl_blockread_all for the case when no timeout was set.

Prior to this change if the timeout had a value of 0 and that was passed
to SOCKET_READABLE it would return right away instead of blocking. That
was likely because it was not well understood that when Curl_timeleft
returns 0 it is not a timeout of 0 ms but actually means no timeout.

Ref: https://github.com/curl/curl/pull/5214#issuecomment-612512360

Closes https://github.com/curl/curl/pull/5220

gopher: check remaining time left during write busy loop

2020-04-12T22:32:14+00:00

Prior to this change gopher's blocking code would block forever,
ignoring any set timeout value.

Assisted-by: Jay Satiro
Reviewed-by: Daniel Stenberg

Similar to #5220 and #5221
Closes #5214

gnutls: ensure TLS 1.3 when SRP isn't requested

2020-04-12T22:06:02+00:00

When SRP is requested in the priority string, GnuTLS will disable
support for TLS 1.3. Before this change, curl would always add +SRP to
the priority list, effectively always disabling TLS 1.3 support.

With this change, +SRP is only added to the priority list when SRP
authentication is also requested. This also allows updating the error
handling here to not have to retry without SRP. This is because SRP is
only added when requested and in that case a retry is not needed.

Closes #5223