<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/curl.git, branch bagder/get-line-when-needed</title>
<subtitle>github.com: bagder/curl.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/'/>
<entry>
<title>fixup the #if line</title>
<updated>2020-08-25T13:14:48+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2020-08-25T13:14:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=50dab960dd7787d807f34f8b89bb45712ba0847a'/>
<id>50dab960dd7787d807f34f8b89bb45712ba0847a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>curl_get_line: build only if cookies or alt-svc are enabled</title>
<updated>2020-08-25T12:52:02+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2020-08-14T13:43:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=255d2fb8d6c2b04b65e57a6e876a3259c32ccf21'/>
<id>255d2fb8d6c2b04b65e57a6e876a3259c32ccf21</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>lib1560: verify "redirect" to double-slash leading URL</title>
<updated>2020-08-25T11:06:34+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2020-08-25T07:56:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=259a81555d4081952f6b7e30b5fa86fff356869b'/>
<id>259a81555d4081952f6b7e30b5fa86fff356869b</id>
<content type='text'>
Closes #5849
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes #5849
</pre>
</div>
</content>
</entry>
<entry>
<title>multi: expand pre-check for socket readiness</title>
<updated>2020-08-25T10:11:45+00:00</updated>
<author>
<name>Marc Hoersken</name>
<email>info@marc-hoersken.de</email>
</author>
<published>2020-07-26T19:26:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=3334ee6bcb2b23c583f4601dc24d122bb9719f17'/>
<id>3334ee6bcb2b23c583f4601dc24d122bb9719f17</id>
<content type='text'>
Check readiness of all sockets before waiting on them
to avoid locking in case the one-time event FD_WRITE
was already consumed by a previous wait operation.

More information about WinSock network events:
https://docs.microsoft.com/en-us/windows/win32/api/
   winsock2/nf-winsock2-wsaeventselect#return-value

Closes #5634
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Check readiness of all sockets before waiting on them
to avoid locking in case the one-time event FD_WRITE
was already consumed by a previous wait operation.

More information about WinSock network events:
https://docs.microsoft.com/en-us/windows/win32/api/
   winsock2/nf-winsock2-wsaeventselect#return-value

Closes #5634
</pre>
</div>
</content>
</entry>
<entry>
<title>multi: implement wait using winsock events</title>
<updated>2020-08-25T10:11:24+00:00</updated>
<author>
<name>rcombs</name>
<email>rcombs@rcombs.me</email>
</author>
<published>2020-05-13T23:49:57+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=d2a7d7c185f98df8f3e585e5620cbc0482e45fac'/>
<id>d2a7d7c185f98df8f3e585e5620cbc0482e45fac</id>
<content type='text'>
This avoids using a pair of TCP ports to provide wakeup functionality
for every multi instance on Windows, where socketpair() is emulated
using a TCP socket on loopback which could in turn lead to socket
resource exhaustion.

A previous version of this patch failed to account for how in WinSock,
FD_WRITE is set only once when writing becomes possible and not again
until after a send has failed due to the buffer filling. This contrasts
to how FD_READ and FD_OOB continue to be set until the conditions they
refer to no longer apply. This meant that if a user wrote some data to
a socket, but not enough data to completely fill its send buffer, then
waited on that socket to become writable, we'd erroneously stall until
their configured timeout rather than returning immediately.

This version of the patch addresses that issue by checking each socket
we're waiting on to become writable with select() before the wait, and
zeroing the timeout if it's already writable.

Assisted-by: Marc Hörsken
Reviewed-by: Marcel Raad
Reviewed-by: Daniel Stenberg
Tested-by: Gergely Nagy
Tested-by: Rasmus Melchior Jacobsen
Tested-by: Tomas Berger

Replaces #5397
Reverts #5632
Closes #5634
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This avoids using a pair of TCP ports to provide wakeup functionality
for every multi instance on Windows, where socketpair() is emulated
using a TCP socket on loopback which could in turn lead to socket
resource exhaustion.

A previous version of this patch failed to account for how in WinSock,
FD_WRITE is set only once when writing becomes possible and not again
until after a send has failed due to the buffer filling. This contrasts
to how FD_READ and FD_OOB continue to be set until the conditions they
refer to no longer apply. This meant that if a user wrote some data to
a socket, but not enough data to completely fill its send buffer, then
waited on that socket to become writable, we'd erroneously stall until
their configured timeout rather than returning immediately.

This version of the patch addresses that issue by checking each socket
we're waiting on to become writable with select() before the wait, and
zeroing the timeout if it's already writable.

Assisted-by: Marc Hörsken
Reviewed-by: Marcel Raad
Reviewed-by: Daniel Stenberg
Tested-by: Gergely Nagy
Tested-by: Rasmus Melchior Jacobsen
Tested-by: Tomas Berger

Replaces #5397
Reverts #5632
Closes #5634
</pre>
</div>
</content>
</entry>
<entry>
<title>select: reduce duplication of Curl_poll in Curl_socket_check</title>
<updated>2020-08-25T09:21:44+00:00</updated>
<author>
<name>Marc Hoersken</name>
<email>info@marc-hoersken.de</email>
</author>
<published>2020-04-19T18:27:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=17f58c8d98a0de2e88d49cdba1cc1e0145cada91'/>
<id>17f58c8d98a0de2e88d49cdba1cc1e0145cada91</id>
<content type='text'>
Change Curl_socket_check to use select-fallback in Curl_poll
instead of implementing it in Curl_socket_check and Curl_poll.

Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro

Replaces #5262 and #5492
Closes #5707
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change Curl_socket_check to use select-fallback in Curl_poll
instead of implementing it in Curl_socket_check and Curl_poll.

Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro

Replaces #5262 and #5492
Closes #5707
</pre>
</div>
</content>
</entry>
<entry>
<title>select: fix poll-based check not detecting connect failure</title>
<updated>2020-08-25T09:20:58+00:00</updated>
<author>
<name>Marc Hoersken</name>
<email>info@marc-hoersken.de</email>
</author>
<published>2020-07-21T18:17:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=e21bd22f842dc07ee953fac6a1edd0c054f123d4'/>
<id>e21bd22f842dc07ee953fac6a1edd0c054f123d4</id>
<content type='text'>
This commit changes Curl_socket_check to use POLLPRI to
check for connect failure on the write socket, because
POLLPRI maps to fds_err. This is in line with select(2).

The select-based socket check correctly checks for connect
failures by adding the write socket also to fds_err.

The poll-based implementation (which internally can itself
fallback to select again) did not previously check for
connect failure by using POLLPRI with the write socket.

See the follow up commit to this for more information.

This commit makes sure connect failures can be detected
and handled if HAVE_POLL_FINE is defined, eg. on msys2-devel.

Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro

Replaces #5509
Prepares #5707
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit changes Curl_socket_check to use POLLPRI to
check for connect failure on the write socket, because
POLLPRI maps to fds_err. This is in line with select(2).

The select-based socket check correctly checks for connect
failures by adding the write socket also to fds_err.

The poll-based implementation (which internally can itself
fallback to select again) did not previously check for
connect failure by using POLLPRI with the write socket.

See the follow up commit to this for more information.

This commit makes sure connect failures can be detected
and handled if HAVE_POLL_FINE is defined, eg. on msys2-devel.

Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro

Replaces #5509
Prepares #5707
</pre>
</div>
</content>
</entry>
<entry>
<title>select.h: make socket validation macros test for INVALID_SOCKET</title>
<updated>2020-08-25T09:17:06+00:00</updated>
<author>
<name>Marc Hoersken</name>
<email>info@marc-hoersken.de</email>
</author>
<published>2020-08-03T13:54:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=0f7c332f9f36f792a7903760b2a8db45091ed8b6'/>
<id>0f7c332f9f36f792a7903760b2a8db45091ed8b6</id>
<content type='text'>
With Winsock the valid range is [0..INVALID_SOCKET-1] according to
https://docs.microsoft.com/en-us/windows/win32/winsock/socket-data-type-2

Reviewed-by: Jay Satiro
Reviewed-by: Marcel Raad
Reviewed-by: Daniel Stenberg

Closes #5760
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
With Winsock the valid range is [0..INVALID_SOCKET-1] according to
https://docs.microsoft.com/en-us/windows/win32/winsock/socket-data-type-2

Reviewed-by: Jay Satiro
Reviewed-by: Marcel Raad
Reviewed-by: Daniel Stenberg

Closes #5760
</pre>
</div>
</content>
</entry>
<entry>
<title>docs: --output-dir is added in 7.73.0, nothing else</title>
<updated>2020-08-24T20:49:32+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2020-08-24T20:49:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=3a9042ea14b302da0606e1b2f46e1eda29f627c3'/>
<id>3a9042ea14b302da0606e1b2f46e1eda29f627c3</id>
<content type='text'>
Follow-up to 5620d2cc78c0
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Follow-up to 5620d2cc78c0
</pre>
</div>
</content>
</entry>
<entry>
<title>curl: add --output-dir</title>
<updated>2020-08-24T20:41:37+00:00</updated>
<author>
<name>Daniel Stenberg</name>
<email>daniel@haxx.se</email>
</author>
<published>2020-08-24T06:31:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/curl.git/commit/?id=5620d2cc78c018f6ae15ba9aab371aa388146df0'/>
<id>5620d2cc78c018f6ae15ba9aab371aa388146df0</id>
<content type='text'>
Works with --create-dirs and with -J

Add test 3008, 3009, 3011, 3012 and 3013 to verify.

Closes #5637
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Works with --create-dirs and with -J

Add test 3008, 3009, 3011, 3012 and 3013 to verify.

Closes #5637
</pre>
</div>
</content>
</entry>
</feed>
